You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Alexander Kolbasov <ak...@gmail.com> on 2017/05/02 17:44:11 UTC
Review Request 58926: SENTRY-1747: HMSFollower shouldn't create local
hive during tests
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58926/
-----------------------------------------------------------
Review request for sentry, Hao Hao, kalyan kumar kalvagadda, Sergio Pena, and Vamsee Yarlagadda.
Bugs: SENTRY-1747
https://issues.apache.org/jira/browse/SENTRY-1747
Repository: sentry
Description
-------
SENTRY-1747: HMSFollower shouldn't create local hive during tests
Diffs
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java ec8676e5c4e4030b4a8d819bec028694b96fd189
Diff: https://reviews.apache.org/r/58926/diff/1/
Testing
-------
Thanks,
Alexander Kolbasov
Re: Review Request 58926: SENTRY-1747: HMSFollower shouldn't create
local hive during tests
Posted by Na Li <li...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58926/#review173627
-----------------------------------------------------------
Fix it, then Ship it!
Ship It!
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java
Lines 130 (patched)
<https://reviews.apache.org/r/58926/#comment246627>
do we have situation that needs to use local Hive metastore?
- Na Li
On May 2, 2017, 5:44 p.m., Alexander Kolbasov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58926/
> -----------------------------------------------------------
>
> (Updated May 2, 2017, 5:44 p.m.)
>
>
> Review request for sentry, Hao Hao, kalyan kumar kalvagadda, Sergio Pena, and Vamsee Yarlagadda.
>
>
> Bugs: SENTRY-1747
> https://issues.apache.org/jira/browse/SENTRY-1747
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1747: HMSFollower shouldn't create local hive during tests
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java ec8676e5c4e4030b4a8d819bec028694b96fd189
>
>
> Diff: https://reviews.apache.org/r/58926/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Kolbasov
>
>
Re: Review Request 58926: SENTRY-1747: HMSFollower shouldn't create
local hive during tests
Posted by Sergio Pena <se...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58926/#review173634
-----------------------------------------------------------
Ship it!
The patch looks good.
What kind of tests did you run to validate this?
- Sergio Pena
On May 2, 2017, 5:44 p.m., Alexander Kolbasov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58926/
> -----------------------------------------------------------
>
> (Updated May 2, 2017, 5:44 p.m.)
>
>
> Review request for sentry, Hao Hao, kalyan kumar kalvagadda, Sergio Pena, and Vamsee Yarlagadda.
>
>
> Bugs: SENTRY-1747
> https://issues.apache.org/jira/browse/SENTRY-1747
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1747: HMSFollower shouldn't create local hive during tests
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java ec8676e5c4e4030b4a8d819bec028694b96fd189
>
>
> Diff: https://reviews.apache.org/r/58926/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Kolbasov
>
>
Re: Review Request 58926: SENTRY-1747: HMSFollower shouldn't create
local hive during tests
Posted by kalyan kumar kalvagadda <kk...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58926/#review173639
-----------------------------------------------------------
Ship it!
Ship It!
- kalyan kumar kalvagadda
On May 2, 2017, 5:44 p.m., Alexander Kolbasov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58926/
> -----------------------------------------------------------
>
> (Updated May 2, 2017, 5:44 p.m.)
>
>
> Review request for sentry, Hao Hao, kalyan kumar kalvagadda, Sergio Pena, and Vamsee Yarlagadda.
>
>
> Bugs: SENTRY-1747
> https://issues.apache.org/jira/browse/SENTRY-1747
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1747: HMSFollower shouldn't create local hive during tests
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java ec8676e5c4e4030b4a8d819bec028694b96fd189
>
>
> Diff: https://reviews.apache.org/r/58926/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Kolbasov
>
>
Re: Review Request 58926: SENTRY-1747: HMSFollower shouldn't create
local hive during tests
Posted by Vamsee Yarlagadda <va...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58926/#review173632
-----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java
Lines 132 (patched)
<https://reviews.apache.org/r/58926/#comment246632>
Do you think this is something we need to raise an error even outside of tests?
- Vamsee Yarlagadda
On May 2, 2017, 5:44 p.m., Alexander Kolbasov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58926/
> -----------------------------------------------------------
>
> (Updated May 2, 2017, 5:44 p.m.)
>
>
> Review request for sentry, Hao Hao, kalyan kumar kalvagadda, Sergio Pena, and Vamsee Yarlagadda.
>
>
> Bugs: SENTRY-1747
> https://issues.apache.org/jira/browse/SENTRY-1747
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1747: HMSFollower shouldn't create local hive during tests
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java ec8676e5c4e4030b4a8d819bec028694b96fd189
>
>
> Diff: https://reviews.apache.org/r/58926/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Kolbasov
>
>