[jira] Updated: (GERONIMO-3714) Monitoring console does no error checking on add/edit graph timeframe

["Viet Hung Nguyen (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/GERONIMO-3714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Viet Hung Nguyen updated GERONIMO-3714:
---------------------------------------

    Attachment: geronimo-3714.patch

The root cause of this is because the "skipCount" value is equal to 0 in some instances because of integer division. With skipCount = 0, it is meaningless to the method getSpecificStatistics() in the agent. Whenever this happens, I set skipCount = 1, meaning, grab each snapshot without skipping any in between. 

Additionally, I also reformatted the MRCConnector.java to abide by the Apache Geronimo coding standards specified at http://geronimo.apache.org/coding-standards.html.

> Monitoring console does no error checking on add/edit graph timeframe
> ---------------------------------------------------------------------
>
>                 Key: GERONIMO-3714
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3714
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: monitoring
>    Affects Versions: 2.1
>            Reporter: Erik B. Craig
>            Assignee: Viet Hung Nguyen
>         Attachments: geronimo-3714.patch
>
>
> Currently the Monitoring console does no error checking on add/edit graph timeframe, it is therefore possible to define graphs that will break the page.
> There should be javascript checks to prevent the user from entering values anything less than 3*(snapshot duration) and anything more than the archive cutoff point, UNLESS 'show archive' is checked 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.