You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Owen O'Malley (JIRA)" <ji...@apache.org> on 2010/02/21 00:06:28 UTC
[jira] Created: (HADOOP-6579) A utility for reading and writing
tokens into a URL safe string.
A utility for reading and writing tokens into a URL safe string.
----------------------------------------------------------------
Key: HADOOP-6579
URL: https://issues.apache.org/jira/browse/HADOOP-6579
Project: Hadoop Common
Issue Type: Improvement
Components: security
Reporter: Owen O'Malley
Assignee: Owen O'Malley
Fix For: 0.22.0
We need to include HDFS delegation tokens in the URLs while browsing the file system. Therefore, we need a url-safe way to encode and decode them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6579) A utility for reading and writing
tokens into a URL safe string.
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-6579:
----------------------------------
Attachment: (was: c-6579.patch)
> A utility for reading and writing tokens into a URL safe string.
> ----------------------------------------------------------------
>
> Key: HADOOP-6579
> URL: https://issues.apache.org/jira/browse/HADOOP-6579
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.22.0
>
> Attachments: c-6579-hdfs.patch, c-6579-mr.patch, c-6579.patch
>
>
> We need to include HDFS delegation tokens in the URLs while browsing the file system. Therefore, we need a url-safe way to encode and decode them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6579) A utility for reading and writing
tokens into a URL safe string.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12836279#action_12836279 ]
Hadoop QA commented on HADOOP-6579:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12436467/c-6579.patch
against trunk revision 912207.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/22/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/22/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/22/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/22/console
This message is automatically generated.
> A utility for reading and writing tokens into a URL safe string.
> ----------------------------------------------------------------
>
> Key: HADOOP-6579
> URL: https://issues.apache.org/jira/browse/HADOOP-6579
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.22.0
>
> Attachments: c-6579-hdfs.patch, c-6579-mr.patch, c-6579.patch
>
>
> We need to include HDFS delegation tokens in the URLs while browsing the file system. Therefore, we need a url-safe way to encode and decode them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6579) A utility for reading and writing
tokens into a URL safe string.
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-6579:
----------------------------------
Status: Patch Available (was: Open)
> A utility for reading and writing tokens into a URL safe string.
> ----------------------------------------------------------------
>
> Key: HADOOP-6579
> URL: https://issues.apache.org/jira/browse/HADOOP-6579
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.22.0
>
> Attachments: c-6579-hdfs.patch, c-6579-mr.patch, c-6579.patch, c-6579.patch, c-6579.patch
>
>
> We need to include HDFS delegation tokens in the URLs while browsing the file system. Therefore, we need a url-safe way to encode and decode them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6579) A utility for reading and writing
tokens into a URL safe string.
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838194#action_12838194 ]
Devaraj Das commented on HADOOP-6579:
-------------------------------------
+1 (except that the test failure needs to be checked)
> A utility for reading and writing tokens into a URL safe string.
> ----------------------------------------------------------------
>
> Key: HADOOP-6579
> URL: https://issues.apache.org/jira/browse/HADOOP-6579
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.22.0
>
> Attachments: c-6579-hdfs.patch, c-6579-mr.patch, c-6579.patch, c-6579.patch, c-6579.patch
>
>
> We need to include HDFS delegation tokens in the URLs while browsing the file system. Therefore, we need a url-safe way to encode and decode them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6579) A utility for reading and writing
tokens into a URL safe string.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853665#action_12853665 ]
Hudson commented on HADOOP-6579:
--------------------------------
Integrated in Hdfs-Patch-h2.grid.sp2.yahoo.net #146 (See [http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/146/])
> A utility for reading and writing tokens into a URL safe string.
> ----------------------------------------------------------------
>
> Key: HADOOP-6579
> URL: https://issues.apache.org/jira/browse/HADOOP-6579
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.22.0
>
> Attachments: c-6579-hdfs.patch, c-6579-mr.patch, c-6579.patch, c-6579.patch, c-6579.patch, c-6579.patch, c-6579.patch
>
>
> We need to include HDFS delegation tokens in the URLs while browsing the file system. Therefore, we need a url-safe way to encode and decode them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6579) A utility for reading and writing
tokens into a URL safe string.
Posted by "Philip Zeyliger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837952#action_12837952 ]
Philip Zeyliger commented on HADOOP-6579:
-----------------------------------------
Hi Owen,
Trying to keep up with some of the security jiras. You're producing a lot of code, thereby making it tricky :)
I think, in general, it's not that useful to write arbitrary writables to base64-encoded strings. Most browsers limit how long URL strings can be, so you've got to be pretty careful about what you're up to. Would you consider instead making this more specific, by moving this code into Token.getAsUrlSafeString() and (static) Token.fromUrlSafeString()? Or, equivalently, leave the code here, but in redirectToRandomDataNode() (patch in HDFS-991), use a method on the Token instead of WritableUtils. (This has the additional property that one could serialize tokens however; they just have to have a URL-safe string serialization.)
Looked at the code and tests. Those look clear and good.
-- Philip
> A utility for reading and writing tokens into a URL safe string.
> ----------------------------------------------------------------
>
> Key: HADOOP-6579
> URL: https://issues.apache.org/jira/browse/HADOOP-6579
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.22.0
>
> Attachments: c-6579-hdfs.patch, c-6579-mr.patch, c-6579.patch, c-6579.patch
>
>
> We need to include HDFS delegation tokens in the URLs while browsing the file system. Therefore, we need a url-safe way to encode and decode them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6579) A utility for reading and writing
tokens into a URL safe string.
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-6579:
----------------------------------
Status: Patch Available (was: Open)
> A utility for reading and writing tokens into a URL safe string.
> ----------------------------------------------------------------
>
> Key: HADOOP-6579
> URL: https://issues.apache.org/jira/browse/HADOOP-6579
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.22.0
>
> Attachments: c-6579-hdfs.patch, c-6579-mr.patch, c-6579.patch, c-6579.patch
>
>
> We need to include HDFS delegation tokens in the URLs while browsing the file system. Therefore, we need a url-safe way to encode and decode them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6579) A utility for reading and writing
tokens into a URL safe string.
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-6579:
----------------------------------
Attachment: c-6579.patch
> A utility for reading and writing tokens into a URL safe string.
> ----------------------------------------------------------------
>
> Key: HADOOP-6579
> URL: https://issues.apache.org/jira/browse/HADOOP-6579
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.22.0
>
> Attachments: c-6579-hdfs.patch, c-6579-mr.patch, c-6579.patch
>
>
> We need to include HDFS delegation tokens in the URLs while browsing the file system. Therefore, we need a url-safe way to encode and decode them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6579) A utility for reading and writing
tokens into a URL safe string.
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-6579:
----------------------------------
Status: Patch Available (was: Open)
> A utility for reading and writing tokens into a URL safe string.
> ----------------------------------------------------------------
>
> Key: HADOOP-6579
> URL: https://issues.apache.org/jira/browse/HADOOP-6579
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.22.0
>
> Attachments: c-6579-hdfs.patch, c-6579-mr.patch, c-6579.patch
>
>
> We need to include HDFS delegation tokens in the URLs while browsing the file system. Therefore, we need a url-safe way to encode and decode them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6579) A utility for reading and writing
tokens into a URL safe string.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12840039#action_12840039 ]
Hudson commented on HADOOP-6579:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #252 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/252/])
> A utility for reading and writing tokens into a URL safe string.
> ----------------------------------------------------------------
>
> Key: HADOOP-6579
> URL: https://issues.apache.org/jira/browse/HADOOP-6579
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.22.0
>
> Attachments: c-6579-hdfs.patch, c-6579-mr.patch, c-6579.patch, c-6579.patch, c-6579.patch, c-6579.patch, c-6579.patch
>
>
> We need to include HDFS delegation tokens in the URLs while browsing the file system. Therefore, we need a url-safe way to encode and decode them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6579) A utility for reading and writing
tokens into a URL safe string.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838371#action_12838371 ]
Hudson commented on HADOOP-6579:
--------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #203 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/203/])
. Upgrade the commons-codec library to 1.4. (omalley)
> A utility for reading and writing tokens into a URL safe string.
> ----------------------------------------------------------------
>
> Key: HADOOP-6579
> URL: https://issues.apache.org/jira/browse/HADOOP-6579
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.22.0
>
> Attachments: c-6579-hdfs.patch, c-6579-mr.patch, c-6579.patch, c-6579.patch, c-6579.patch, c-6579.patch, c-6579.patch
>
>
> We need to include HDFS delegation tokens in the URLs while browsing the file system. Therefore, we need a url-safe way to encode and decode them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6579) A utility for reading and writing
tokens into a URL safe string.
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-6579:
----------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this.
> A utility for reading and writing tokens into a URL safe string.
> ----------------------------------------------------------------
>
> Key: HADOOP-6579
> URL: https://issues.apache.org/jira/browse/HADOOP-6579
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.22.0
>
> Attachments: c-6579-hdfs.patch, c-6579-mr.patch, c-6579.patch, c-6579.patch, c-6579.patch, c-6579.patch, c-6579.patch
>
>
> We need to include HDFS delegation tokens in the URLs while browsing the file system. Therefore, we need a url-safe way to encode and decode them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6579) A utility for reading and writing
tokens into a URL safe string.
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-6579:
----------------------------------
Status: Open (was: Patch Available)
> A utility for reading and writing tokens into a URL safe string.
> ----------------------------------------------------------------
>
> Key: HADOOP-6579
> URL: https://issues.apache.org/jira/browse/HADOOP-6579
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.22.0
>
> Attachments: c-6579-hdfs.patch, c-6579-mr.patch, c-6579.patch, c-6579.patch, c-6579.patch, c-6579.patch
>
>
> We need to include HDFS delegation tokens in the URLs while browsing the file system. Therefore, we need a url-safe way to encode and decode them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6579) A utility for reading and writing
tokens into a URL safe string.
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-6579:
----------------------------------
Status: Open (was: Patch Available)
> A utility for reading and writing tokens into a URL safe string.
> ----------------------------------------------------------------
>
> Key: HADOOP-6579
> URL: https://issues.apache.org/jira/browse/HADOOP-6579
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.22.0
>
> Attachments: c-6579-hdfs.patch, c-6579-mr.patch, c-6579.patch, c-6579.patch
>
>
> We need to include HDFS delegation tokens in the URLs while browsing the file system. Therefore, we need a url-safe way to encode and decode them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6579) A utility for reading and writing
tokens into a URL safe string.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838827#action_12838827 ]
Hudson commented on HADOOP-6579:
--------------------------------
Integrated in Hadoop-Common-trunk #261 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/261/])
. Provide a mechanism for encoding/decoding Tokens from
a url-safe string and change the commons-code library to 1.4. (omalley)
> A utility for reading and writing tokens into a URL safe string.
> ----------------------------------------------------------------
>
> Key: HADOOP-6579
> URL: https://issues.apache.org/jira/browse/HADOOP-6579
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.22.0
>
> Attachments: c-6579-hdfs.patch, c-6579-mr.patch, c-6579.patch, c-6579.patch, c-6579.patch, c-6579.patch, c-6579.patch
>
>
> We need to include HDFS delegation tokens in the URLs while browsing the file system. Therefore, we need a url-safe way to encode and decode them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6579) A utility for reading and writing
tokens into a URL safe string.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837648#action_12837648 ]
Hadoop QA commented on HADOOP-6579:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12436787/c-6579.patch
against trunk revision 915168.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/374/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/374/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/374/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/374/console
This message is automatically generated.
> A utility for reading and writing tokens into a URL safe string.
> ----------------------------------------------------------------
>
> Key: HADOOP-6579
> URL: https://issues.apache.org/jira/browse/HADOOP-6579
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.22.0
>
> Attachments: c-6579-hdfs.patch, c-6579-mr.patch, c-6579.patch, c-6579.patch
>
>
> We need to include HDFS delegation tokens in the URLs while browsing the file system. Therefore, we need a url-safe way to encode and decode them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6579) A utility for reading and writing
tokens into a URL safe string.
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838222#action_12838222 ]
Devaraj Das commented on HADOOP-6579:
-------------------------------------
+1 (subject to hudson)
> A utility for reading and writing tokens into a URL safe string.
> ----------------------------------------------------------------
>
> Key: HADOOP-6579
> URL: https://issues.apache.org/jira/browse/HADOOP-6579
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.22.0
>
> Attachments: c-6579-hdfs.patch, c-6579-mr.patch, c-6579.patch, c-6579.patch, c-6579.patch, c-6579.patch, c-6579.patch
>
>
> We need to include HDFS delegation tokens in the URLs while browsing the file system. Therefore, we need a url-safe way to encode and decode them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6579) A utility for reading and writing
tokens into a URL safe string.
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-6579:
----------------------------------
Attachment: c-6579.patch
I think it is more useful than that, but I've made the change to more the methods into Token. I also added toString, equals, hashCode, and new constructor to Token so that I could test the new code.
> A utility for reading and writing tokens into a URL safe string.
> ----------------------------------------------------------------
>
> Key: HADOOP-6579
> URL: https://issues.apache.org/jira/browse/HADOOP-6579
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.22.0
>
> Attachments: c-6579-hdfs.patch, c-6579-mr.patch, c-6579.patch, c-6579.patch, c-6579.patch
>
>
> We need to include HDFS delegation tokens in the URLs while browsing the file system. Therefore, we need a url-safe way to encode and decode them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6579) A utility for reading and writing
tokens into a URL safe string.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853966#action_12853966 ]
Hudson commented on HADOOP-6579:
--------------------------------
Integrated in Hadoop-Hdfs-trunk #275 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/275/])
> A utility for reading and writing tokens into a URL safe string.
> ----------------------------------------------------------------
>
> Key: HADOOP-6579
> URL: https://issues.apache.org/jira/browse/HADOOP-6579
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.22.0
>
> Attachments: c-6579-hdfs.patch, c-6579-mr.patch, c-6579.patch, c-6579.patch, c-6579.patch, c-6579.patch, c-6579.patch
>
>
> We need to include HDFS delegation tokens in the URLs while browsing the file system. Therefore, we need a url-safe way to encode and decode them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6579) A utility for reading and writing
tokens into a URL safe string.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853874#action_12853874 ]
Hudson commented on HADOOP-6579:
--------------------------------
Integrated in Hdfs-Patch-h5.grid.sp2.yahoo.net #302 (See [http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/302/])
> A utility for reading and writing tokens into a URL safe string.
> ----------------------------------------------------------------
>
> Key: HADOOP-6579
> URL: https://issues.apache.org/jira/browse/HADOOP-6579
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.22.0
>
> Attachments: c-6579-hdfs.patch, c-6579-mr.patch, c-6579.patch, c-6579.patch, c-6579.patch, c-6579.patch, c-6579.patch
>
>
> We need to include HDFS delegation tokens in the URLs while browsing the file system. Therefore, we need a url-safe way to encode and decode them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6579) A utility for reading and writing
tokens into a URL safe string.
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-6579:
----------------------------------
Attachment: c-6579.patch
This patch fixes one of the test cases to add the extra parameters to the Base64 constructor. It must have changed semantics between 1.3 and 1.4 of the library.
> A utility for reading and writing tokens into a URL safe string.
> ----------------------------------------------------------------
>
> Key: HADOOP-6579
> URL: https://issues.apache.org/jira/browse/HADOOP-6579
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.22.0
>
> Attachments: c-6579-hdfs.patch, c-6579-mr.patch, c-6579.patch, c-6579.patch, c-6579.patch, c-6579.patch
>
>
> We need to include HDFS delegation tokens in the URLs while browsing the file system. Therefore, we need a url-safe way to encode and decode them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6579) A utility for reading and writing
tokens into a URL safe string.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12840613#action_12840613 ]
Hudson commented on HADOOP-6579:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #193 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/193/])
. Provide a mechanism for encoding/decoding Tokens from
a url-safe string and change the commons-code library to 1.4. (omalley)
> A utility for reading and writing tokens into a URL safe string.
> ----------------------------------------------------------------
>
> Key: HADOOP-6579
> URL: https://issues.apache.org/jira/browse/HADOOP-6579
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.22.0
>
> Attachments: c-6579-hdfs.patch, c-6579-mr.patch, c-6579.patch, c-6579.patch, c-6579.patch, c-6579.patch, c-6579.patch
>
>
> We need to include HDFS delegation tokens in the URLs while browsing the file system. Therefore, we need a url-safe way to encode and decode them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6579) A utility for reading and writing
tokens into a URL safe string.
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-6579:
----------------------------------
Status: Open (was: Patch Available)
> A utility for reading and writing tokens into a URL safe string.
> ----------------------------------------------------------------
>
> Key: HADOOP-6579
> URL: https://issues.apache.org/jira/browse/HADOOP-6579
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.22.0
>
> Attachments: c-6579-hdfs.patch, c-6579-mr.patch, c-6579.patch, c-6579.patch
>
>
> We need to include HDFS delegation tokens in the URLs while browsing the file system. Therefore, we need a url-safe way to encode and decode them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6579) A utility for reading and writing
tokens into a URL safe string.
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-6579:
----------------------------------
Status: Patch Available (was: Open)
> A utility for reading and writing tokens into a URL safe string.
> ----------------------------------------------------------------
>
> Key: HADOOP-6579
> URL: https://issues.apache.org/jira/browse/HADOOP-6579
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.22.0
>
> Attachments: c-6579-hdfs.patch, c-6579-mr.patch, c-6579.patch, c-6579.patch, c-6579.patch, c-6579.patch
>
>
> We need to include HDFS delegation tokens in the URLs while browsing the file system. Therefore, we need a url-safe way to encode and decode them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6579) A utility for reading and writing
tokens into a URL safe string.
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-6579:
----------------------------------
Attachment: c-6579.patch
c-6579-hdfs.patch
c-6579-mr.patch
This patch adds encode/decode methods into WritableUtils and ups the version of commons-code from 1.3 to 1.4. The patches for hdfs and mr are trivial.
> A utility for reading and writing tokens into a URL safe string.
> ----------------------------------------------------------------
>
> Key: HADOOP-6579
> URL: https://issues.apache.org/jira/browse/HADOOP-6579
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.22.0
>
> Attachments: c-6579-hdfs.patch, c-6579-mr.patch, c-6579.patch
>
>
> We need to include HDFS delegation tokens in the URLs while browsing the file system. Therefore, we need a url-safe way to encode and decode them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6579) A utility for reading and writing
tokens into a URL safe string.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838053#action_12838053 ]
Hadoop QA commented on HADOOP-6579:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12436908/c-6579.patch
against trunk revision 915168.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/379/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/379/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/379/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/379/console
This message is automatically generated.
> A utility for reading and writing tokens into a URL safe string.
> ----------------------------------------------------------------
>
> Key: HADOOP-6579
> URL: https://issues.apache.org/jira/browse/HADOOP-6579
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.22.0
>
> Attachments: c-6579-hdfs.patch, c-6579-mr.patch, c-6579.patch, c-6579.patch, c-6579.patch
>
>
> We need to include HDFS delegation tokens in the URLs while browsing the file system. Therefore, we need a url-safe way to encode and decode them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6579) A utility for reading and writing
tokens into a URL safe string.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838223#action_12838223 ]
Hadoop QA commented on HADOOP-6579:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12436959/c-6579.patch
against trunk revision 915168.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/382/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/382/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/382/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/382/console
This message is automatically generated.
> A utility for reading and writing tokens into a URL safe string.
> ----------------------------------------------------------------
>
> Key: HADOOP-6579
> URL: https://issues.apache.org/jira/browse/HADOOP-6579
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.22.0
>
> Attachments: c-6579-hdfs.patch, c-6579-mr.patch, c-6579.patch, c-6579.patch, c-6579.patch, c-6579.patch, c-6579.patch
>
>
> We need to include HDFS delegation tokens in the URLs while browsing the file system. Therefore, we need a url-safe way to encode and decode them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6579) A utility for reading and writing
tokens into a URL safe string.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838209#action_12838209 ]
Hadoop QA commented on HADOOP-6579:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12436955/c-6579.patch
against trunk revision 915168.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The patch appears to cause tar ant target to fail.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/381/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/381/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/381/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/381/console
This message is automatically generated.
> A utility for reading and writing tokens into a URL safe string.
> ----------------------------------------------------------------
>
> Key: HADOOP-6579
> URL: https://issues.apache.org/jira/browse/HADOOP-6579
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.22.0
>
> Attachments: c-6579-hdfs.patch, c-6579-mr.patch, c-6579.patch, c-6579.patch, c-6579.patch, c-6579.patch
>
>
> We need to include HDFS delegation tokens in the URLs while browsing the file system. Therefore, we need a url-safe way to encode and decode them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6579) A utility for reading and writing
tokens into a URL safe string.
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-6579:
----------------------------------
Attachment: c-6579.patch
I missed one file in the previous patch.
> A utility for reading and writing tokens into a URL safe string.
> ----------------------------------------------------------------
>
> Key: HADOOP-6579
> URL: https://issues.apache.org/jira/browse/HADOOP-6579
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.22.0
>
> Attachments: c-6579-hdfs.patch, c-6579-mr.patch, c-6579.patch, c-6579.patch, c-6579.patch, c-6579.patch, c-6579.patch
>
>
> We need to include HDFS delegation tokens in the URLs while browsing the file system. Therefore, we need a url-safe way to encode and decode them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6579) A utility for reading and writing
tokens into a URL safe string.
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-6579:
----------------------------------
Status: Open (was: Patch Available)
> A utility for reading and writing tokens into a URL safe string.
> ----------------------------------------------------------------
>
> Key: HADOOP-6579
> URL: https://issues.apache.org/jira/browse/HADOOP-6579
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.22.0
>
> Attachments: c-6579-hdfs.patch, c-6579-mr.patch, c-6579.patch, c-6579.patch, c-6579.patch, c-6579.patch
>
>
> We need to include HDFS delegation tokens in the URLs while browsing the file system. Therefore, we need a url-safe way to encode and decode them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6579) A utility for reading and writing
tokens into a URL safe string.
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-6579:
----------------------------------
Attachment: c-6579.patch
Included a test case.
> A utility for reading and writing tokens into a URL safe string.
> ----------------------------------------------------------------
>
> Key: HADOOP-6579
> URL: https://issues.apache.org/jira/browse/HADOOP-6579
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.22.0
>
> Attachments: c-6579-hdfs.patch, c-6579-mr.patch, c-6579.patch, c-6579.patch
>
>
> We need to include HDFS delegation tokens in the URLs while browsing the file system. Therefore, we need a url-safe way to encode and decode them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6579) A utility for reading and writing
tokens into a URL safe string.
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-6579:
----------------------------------
Status: Patch Available (was: Open)
> A utility for reading and writing tokens into a URL safe string.
> ----------------------------------------------------------------
>
> Key: HADOOP-6579
> URL: https://issues.apache.org/jira/browse/HADOOP-6579
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.22.0
>
> Attachments: c-6579-hdfs.patch, c-6579-mr.patch, c-6579.patch, c-6579.patch, c-6579.patch, c-6579.patch, c-6579.patch
>
>
> We need to include HDFS delegation tokens in the URLs while browsing the file system. Therefore, we need a url-safe way to encode and decode them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.