[GitHub] [samza] mynameborat commented on a change in pull request #1301: Samza-2478: Add new metrics to track key and value size of records written to RocksDb

[GitBox <gi...@apache.org>]

mynameborat commented on a change in pull request #1301: Samza-2478: Add new metrics to track key and value size of records written to RocksDb
URL: https://github.com/apache/samza/pull/1301#discussion_r388726812
 
 

 ##########
 File path: samza-kv/src/main/scala/org/apache/samza/storage/kv/SerializedKeyValueStoreMetrics.scala
 ##########
 @@ -36,6 +35,25 @@ class SerializedKeyValueStoreMetrics(
   val bytesSerialized = newCounter("bytes-serialized")
   val bytesDeserialized = newCounter("bytes-deserialized")
   val maxRecordSizeBytes = newGauge("max-record-size-bytes", 0L)
+  val record_key_size_percentiles = java.util.Arrays.asList[java.lang.Double](10D, 50D, 90D, 99D)
 
 Review comment:
   any reason behind the choice of the percentiles? Especially 10th percentile?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services