You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/14 19:14:42 UTC
[GitHub] [beam] kileys opened a new pull request, #21862: Run perf tests on beam-perf node
kileys opened a new pull request, #21862:
URL: https://github.com/apache/beam/pull/21862
Node 16 is set aside for perf tests, but currently only used by 4 tests
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kileys commented on pull request #21862: Run perf tests on Jenkins beam-perf node
Posted by GitBox <gi...@apache.org>.
kileys commented on PR #21862:
URL: https://github.com/apache/beam/pull/21862#issuecomment-1155619636
R: @kennknowles
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kileys closed pull request #21862: Run perf tests on Jenkins beam-perf node
Posted by GitBox <gi...@apache.org>.
kileys closed pull request #21862: Run perf tests on Jenkins beam-perf node
URL: https://github.com/apache/beam/pull/21862
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] apilloud commented on pull request #21862: Run perf tests on Jenkins beam-perf node
Posted by GitBox <gi...@apache.org>.
apilloud commented on PR #21862:
URL: https://github.com/apache/beam/pull/21862#issuecomment-1155681820
The performance node is specifically needed for tests that run locally on the Jenkins worker (such as direct runner or flink local runner jobs). It's configuration prevents multiple jobs from running to reduce the noisy neighbor problem. Jobs that run on the Dataflow runner probably shouldn't be moved to this node as they run the performance sensitive code on a Dataflow worker and not the Jenkins worker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kileys commented on pull request #21862: Run perf tests on Jenkins beam-perf node
Posted by GitBox <gi...@apache.org>.
kileys commented on PR #21862:
URL: https://github.com/apache/beam/pull/21862#issuecomment-1155697615
> The performance node is specifically needed for tests that run locally on the Jenkins worker (such as direct runner or flink local runner jobs). It's configuration prevents multiple jobs from running to reduce the noisy neighbor problem. Jobs that run on the Dataflow runner probably shouldn't be moved to this node as they run the performance sensitive code on a Dataflow worker and not the Jenkins worker.
Makes sense. I'll update our wiki to add this information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org