You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/11/24 14:32:45 UTC
[GitHub] [shardingsphere] FlyingZC opened a new pull request, #22392: Fix cursor wasNull usage and test cases(#21421)
FlyingZC opened a new pull request, #22392:
URL: https://github.com/apache/shardingsphere/pull/22392
Fixes #21421.
Changes proposed in this pull request:
- Fix cursor wasNull usage and test cases
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [x] I have (or in comment I request) added corresponding labels for the pull request.
- [x] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [x] I have made corresponding changes to the documentation.
- [x] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #22392: Fix cursor wasNull usage and test cases(#21421)
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #22392:
URL: https://github.com/apache/shardingsphere/pull/22392#issuecomment-1327042340
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/22392?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22392](https://codecov.io/gh/apache/shardingsphere/pull/22392?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1c95d14) into [master](https://codecov.io/gh/apache/shardingsphere/commit/f34552a9ad8ba83a8dfaa53fe6239c56d36ecf06?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f34552a) will **decrease** coverage by `0.04%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #22392 +/- ##
============================================
- Coverage 51.05% 51.01% -0.05%
Complexity 2501 2501
============================================
Files 4170 4172 +2
Lines 57932 58003 +71
Branches 9847 9859 +12
============================================
+ Hits 29578 29590 +12
- Misses 25826 25886 +60
+ Partials 2528 2527 -1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/22392?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rding/merge/ddl/fetch/FetchStreamMergedResult.java](https://codecov.io/gh/apache/shardingsphere/pull/22392/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhcmRpbmcvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvbWVyZ2UvZGRsL2ZldGNoL0ZldGNoU3RyZWFtTWVyZ2VkUmVzdWx0LmphdmE=) | `77.64% <0.00%> (-0.93%)` | :arrow_down: |
| [...t/query/type/memory/AbstractMemoryQueryResult.java](https://codecov.io/gh/apache/shardingsphere/pull/22392/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvZXhlY3V0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL2V4ZWN1dG9yL3NxbC9leGVjdXRlL3Jlc3VsdC9xdWVyeS90eXBlL21lbW9yeS9BYnN0cmFjdE1lbW9yeVF1ZXJ5UmVzdWx0LmphdmE=) | `86.20% <ø> (ø)` | |
| [...e/sharding/checker/audit/ShardingAuditChecker.java](https://codecov.io/gh/apache/shardingsphere/pull/22392/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhcmRpbmcvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvY2hlY2tlci9hdWRpdC9TaGFyZGluZ0F1ZGl0Q2hlY2tlci5qYXZh) | `64.00% <0.00%> (-3.86%)` | :arrow_down: |
| [...rdinator/subscriber/DatabaseChangedSubscriber.java](https://codecov.io/gh/apache/shardingsphere/pull/22392/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kZS90eXBlL2NsdXN0ZXIvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvbW9kZS9tYW5hZ2VyL2NsdXN0ZXIvY29vcmRpbmF0b3Ivc3Vic2NyaWJlci9EYXRhYmFzZUNoYW5nZWRTdWJzY3JpYmVyLmphdmE=) | `23.52% <0.00%> (-3.14%)` | :arrow_down: |
| [...persist/data/ShardingSphereDataPersistService.java](https://codecov.io/gh/apache/shardingsphere/pull/22392/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kZS9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tb2RlL21ldGFkYXRhL3BlcnNpc3QvZGF0YS9TaGFyZGluZ1NwaGVyZURhdGFQZXJzaXN0U2VydmljZS5qYXZh) | `5.55% <0.00%> (-2.14%)` | :arrow_down: |
| [...he/shardingsphere/mode/manager/ContextManager.java](https://codecov.io/gh/apache/shardingsphere/pull/22392/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kZS9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tb2RlL21hbmFnZXIvQ29udGV4dE1hbmFnZXIuamF2YQ==) | `53.84% <0.00%> (-2.06%)` | :arrow_down: |
| [...egistry/data/ShardingSphereDataChangedWatcher.java](https://codecov.io/gh/apache/shardingsphere/pull/22392/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kZS90eXBlL2NsdXN0ZXIvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvbW9kZS9tYW5hZ2VyL2NsdXN0ZXIvY29vcmRpbmF0b3IvcmVnaXN0cnkvZGF0YS9TaGFyZGluZ1NwaGVyZURhdGFDaGFuZ2VkV2F0Y2hlci5qYXZh) | `3.63% <0.00%> (-1.13%)` | :arrow_down: |
| [...dingsphere/authority/checker/AuthorityChecker.java](https://codecov.io/gh/apache/shardingsphere/pull/22392/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2F1dGhvcml0eS9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9hdXRob3JpdHkvY2hlY2tlci9BdXRob3JpdHlDaGVja2VyLmphdmE=) | `20.83% <0.00%> (-0.74%)` | :arrow_down: |
| [...ingsphere/infra/executor/check/SQLCheckEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/22392/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvZXhlY3V0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL2V4ZWN1dG9yL2NoZWNrL1NRTENoZWNrRW5naW5lLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../metadata/persist/node/ShardingSphereDataNode.java](https://codecov.io/gh/apache/shardingsphere/pull/22392/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kZS9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tb2RlL21ldGFkYXRhL3BlcnNpc3Qvbm9kZS9TaGFyZGluZ1NwaGVyZURhdGFOb2RlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| ... and [11 more](https://codecov.io/gh/apache/shardingsphere/pull/22392/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu merged pull request #22392: Fix cursor wasNull usage and test cases(#21421)
Posted by GitBox <gi...@apache.org>.
strongduanmu merged PR #22392:
URL: https://github.com/apache/shardingsphere/pull/22392
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org