[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1334: MINIFICPP-1803 Do not instantiate all classes at heartbeat

[GitBox <gi...@apache.org>]

szaszm commented on code in PR #1334:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1334#discussion_r888781837


##########
libminifi/src/core/Connectable.cpp:
##########
@@ -85,7 +69,7 @@ bool Connectable::isSupportedRelationship(const core::Relationship &relationship
   }
 }
 
-bool Connectable::setAutoTerminatedRelationships(const std::set<Relationship> &relationships) {
+bool Connectable::setAutoTerminatedRelationships(const std::vector<Relationship>& relationships) {

Review Comment:
   You can overload them to accept both gsl::span and std::array, if you want.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org