[GitHub] [airflow] jedcunningham commented on a change in pull request #19749: pgbouncer service enhancements

[GitBox <gi...@apache.org>]

jedcunningham commented on a change in pull request #19749:
URL: https://github.com/apache/airflow/pull/19749#discussion_r754492675



##########
File path: chart/tests/test_pgbouncer.py
##########
@@ -427,7 +455,7 @@ def test_default_exporter_secret(self):
     def test_exporter_secret_with_overrides(self):
         connection = self._get_connection(
             {
-                "pgbouncer": {"enabled": True},
+                "pgbouncer": {"enabled": True, "metricsExporterSidecar": {"sslmode": "disable"}},

Review comment:
       ```suggestion
                   "pgbouncer": {"enabled": True, "metricsExporterSidecar": {"sslmode": "require"}},
   ```
   
   The intent of this test is to ensure non-defaults can be set.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org