[GitHub] [nuttx-apps] Gary-Hobson commented on a diff in pull request #1695: Enhance trace_dump

["Gary-Hobson (via GitHub)" <gi...@apache.org>]

Gary-Hobson commented on code in PR #1695:
URL: https://github.com/apache/nuttx-apps/pull/1695#discussion_r1159756907


##########
system/trace/trace_dump.c:
##########
@@ -616,6 +632,34 @@ static int trace_dump_one(trace_dump_t type, FAR FILE *out, FAR uint8_t *p,
         break;
 #endif
 
+#ifdef CONFIG_SCHED_INSTRUMENTATION_CSECTION
+      case NOTE_CSECTION_ENTER:
+      case NOTE_CSECTION_LEAVE:
+        {
+          struct note_csection_s *ncs;
+          ncs = (FAR struct note_csection_s *)p;
+          trace_dump_header(out, &ncs->ncs_cmn, ctx);
+          fprintf(out, "tracing_mark_write: %c|%d|critical_section\n",

Review Comment:
   This is compatible with the linux kernel format.
   In the linux kernel, tracing_mark_write is to mark some user data, adding this content will not affect the analysis.
   At the same time, I added tracing_mark_write to both dump_string and dump_binary for consistency



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org