[GitHub] [tvm] areusch commented on pull request #13362: [OpenCL] Introduce OpenCL wrapper to TVM

[GitBox <gi...@apache.org>]

areusch commented on PR #13362:
URL: https://github.com/apache/tvm/pull/13362#issuecomment-1317312896

   We discussed this in the TVM community meeting this morning 
   - Initially we developed support for OpenCL without statically linking to the library; for mobile, need to manually download the SDK to your phone, and compile TVM linking against it.
   - Alternate approach: the API is stable and we don't use very many symbols; can we develop a wrapper around OpenCL that can be dynamically loaded?
   - Two options now:
     1. OPENCL is ON: cmake tries to find OpenCL SDK somewhere at compile time
     2. OpenCL path is specified: pins the headers to a specific location
   - New proposed option:
     - ON now means to use the wrapper in this PR to automatically find the library at runtime and load it dynamically
     - approach is also used in TFLite
   - @areusch: can we detect the case where, at runtime, the user is using a version of libOpenCL.so that is too old?
     - Currently we return a call-specific error code; this is tricky
     - @echuraev: Yeah we can do this
   - The way in which we've included OpenCL headers into 3rdparty is ok.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org