You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@storm.apache.org by "Erik Weathers (JIRA)" <ji...@apache.org> on 2017/05/12 03:41:04 UTC
[jira] [Updated] (STORM-2510) adjust checkstyle configurations to
decrease violations
[ https://issues.apache.org/jira/browse/STORM-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erik Weathers updated STORM-2510:
---------------------------------
Description:
Adjust Storm's checkstyle configuration:
* 4-space indent instead of 2-space indent that is default with google_checks.xml
* exclude the thrift generated code from checkstyle (since we shouldn't be touching it anyways)
* go with 120 character line-length limits instead of the default of 100 from google_checks.xml
With those adjustments, the total number of violations will shrink by ~100,000 (~140,000 -> ~40,000).
was:
Adjust Storm's checkstyle configuration:
* 4-space indent instead of 2-space indent that is default with google_checks.xml
* exclude the thrift generated code from checkstyle (since we shouldn't be touching it anyways)
* go with 120 character line-length limits instead of the default of 100 from google_checks.xml
With those adjustments, the total number of violations will shrink by ~75,000.
> adjust checkstyle configurations to decrease violations
> -------------------------------------------------------
>
> Key: STORM-2510
> URL: https://issues.apache.org/jira/browse/STORM-2510
> Project: Apache Storm
> Issue Type: Bug
> Components: build
> Affects Versions: 2.0.0
> Reporter: Erik Weathers
> Assignee: Erik Weathers
>
> Adjust Storm's checkstyle configuration:
> * 4-space indent instead of 2-space indent that is default with google_checks.xml
> * exclude the thrift generated code from checkstyle (since we shouldn't be touching it anyways)
> * go with 120 character line-length limits instead of the default of 100 from google_checks.xml
> With those adjustments, the total number of violations will shrink by ~100,000 (~140,000 -> ~40,000).
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)