You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Greg Stein <gs...@lyra.org> on 2004/06/20 16:44:58 UTC
Re: svn commit: r9725 - in trunk: . build build/generator packages/rpm/fedora-1 packages/rpm/mandrake-9.0 packages/rpm/mandrake-9.1 packages/rpm/mandrake-9.2 packages/rpm/redhat-7.x packages/rpm/redhat-8+ packages/rpm/wbel-3 subversion/include subversion/libsvn_fs subversion/libsvn_ra subversion/libsvn_subr
On Sat, May 15, 2004 at 02:50:55AM -0500, brane@tigris.org wrote:
>...
> * subversion/include/svn_version.h (SVN_VER_PATCH): Replaces SVN_VER_MICRO.
> (SVN_VER_MICRO): Deprecate. Replace all uses with SVN_VER_PATCH.
> (SVN_VER_LIBRARY): Deprecate. Replace all uses with SVN_VER_MAJOR.
> (svn_version_t::patch): Renamed from 'micro', all uses updated.
>...
> +++ trunk/subversion/include/svn_version.h Sat May 15 02:50:46 2004
>...
> @@ -143,7 +143,7 @@
> {
> int major; /**< Major version number */
> int minor; /**< Minor version number */
> - int micro; /**< Patch number */
> + int patch; /**< Patch number */
Eek. That is a source-level incompatibility. This isn't allowed for a 1.x
release. 1.0 libraries need to be able to compile against the 1.x headers.
This will break that.
The #define changes look good, but this part, and the source changes
related to it, need to be reverted however.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r9725 - in trunk: . build build/generator packages/rpm/fedora-1 packages/rpm/mandrake-9.0 packages/rpm/mandrake-9.1 packages/rpm/mandrake-9.2 packages/rpm/redhat-7.x packages/rpm/redhat-8+ packages/rpm/wbel-3 subversion/include subversion/libsvn_fs subversion/libsvn_ra subversion/libsvn_subr
Posted by Greg Stein <gs...@lyra.org>.
On Sun, Jun 20, 2004 at 07:14:07PM +0200, Branko ??ibej wrote:
>...
> Um. This structure (svn_version_t) was added on trunk in r9664, and
> never appeared in a released version. So no, it's not a source-level
> incompatibility. We don't make any promises about the API _before_ it's
> actually released, do we?
Gah... stupid me. :-(
--
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r9725 - in trunk: . build build/generator
packages/rpm/fedora-1 packages/rpm/mandrake-9.0 packages/rpm/mandrake-9.1
packages/rpm/mandrake-9.2 packages/rpm/redhat-7.x packages/rpm/redhat-8+
packages/rpm/wbel-3 subversion/include subversion/libsvn_fs
subversion/libsvn_ra subversion/libsvn_subr
Posted by Greg Hudson <gh...@MIT.EDU>.
On Sun, 2004-06-20 at 13:14, Branko Čibej wrote:
> Um. This structure (svn_version_t) was added on trunk in r9664, and
> never appeared in a released version. So no, it's not a source-level
> incompatibility. We don't make any promises about the API _before_ it's
> actually released, do we?
Correct.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r9725 - in trunk: . build build/generator packages/rpm/fedora-1
packages/rpm/mandrake-9.0 packages/rpm/mandrake-9.1 packages/rpm/mandrake-9.2
packages/rpm/redhat-7.x packages/rpm/redhat-8+ packages/rpm/wbel-3 subversion/include
subversion/libsvn_fs subversion/libsvn_ra subversion/libsvn_subr
Posted by Branko Čibej <br...@xbc.nu>.
Greg Stein wrote:
>On Sat, May 15, 2004 at 02:50:55AM -0500, brane@tigris.org wrote:
>
>
>>...
>>* subversion/include/svn_version.h (SVN_VER_PATCH): Replaces SVN_VER_MICRO.
>> (SVN_VER_MICRO): Deprecate. Replace all uses with SVN_VER_PATCH.
>> (SVN_VER_LIBRARY): Deprecate. Replace all uses with SVN_VER_MAJOR.
>> (svn_version_t::patch): Renamed from 'micro', all uses updated.
>>...
>>+++ trunk/subversion/include/svn_version.h Sat May 15 02:50:46 2004
>>...
>>@@ -143,7 +143,7 @@
>> {
>> int major; /**< Major version number */
>> int minor; /**< Minor version number */
>>- int micro; /**< Patch number */
>>+ int patch; /**< Patch number */
>>
>>
>
>Eek. That is a source-level incompatibility.
>
Um. This structure (svn_version_t) was added on trunk in r9664, and
never appeared in a released version. So no, it's not a source-level
incompatibility. We don't make any promises about the API _before_ it's
actually released, do we?
-- Brane
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org