You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/08/03 06:05:53 UTC

[GitHub] [hudi] yuzhaojing opened a new pull request #3386: [HUDI-2270] Remove corrupted clean action

yuzhaojing opened a new pull request #3386:
URL: https://github.com/apache/hudi/pull/3386


   ## *Tips*
   - *Thank you very much for contributing to Apache Hudi.*
   - *Please review https://hudi.apache.org/contributing.html before opening a pull request.*
   
   ## What is the purpose of the pull request
   
   *(For example: This pull request adds quick-start document.)*
   
   ## Brief change log
   
   *(for example:)*
     - *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
   
   ## Verify this pull request
   
   *(Please pick either of the following options)*
   
   This pull request is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   *(example:)*
   
     - *Added integration tests for end-to-end.*
     - *Added HoodieClientWriteTest to verify the change.*
     - *Manually verified the change by running a job locally.*
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot removed a comment on pull request #3386: [HUDI-2270] Remove corrupted clean action

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3386:
URL: https://github.com/apache/hudi/pull/3386#issuecomment-891561132






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3386: [HUDI-2270] Remove corrupted clean action

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3386:
URL: https://github.com/apache/hudi/pull/3386#issuecomment-891561132


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8ab1e7075ad5fa9898a867d36e5fdca206a7e800",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1320",
       "triggerID" : "8ab1e7075ad5fa9898a867d36e5fdca206a7e800",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e6d698f8a15907266e6c67094bff521eb090aa2",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "9e6d698f8a15907266e6c67094bff521eb090aa2",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8ab1e7075ad5fa9898a867d36e5fdca206a7e800 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1320) 
   * 9e6d698f8a15907266e6c67094bff521eb090aa2 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] danny0405 commented on a change in pull request #3386: [HUDI-2270] Remove corrupted clean action

Posted by GitBox <gi...@apache.org>.
danny0405 commented on a change in pull request #3386:
URL: https://github.com/apache/hudi/pull/3386#discussion_r681461078



##########
File path: hudi-flink/src/main/java/org/apache/hudi/sink/StreamWriteOperatorCoordinator.java
##########
@@ -329,6 +337,30 @@ private void initInstant(String instant) {
     }, "initialize instant %s", instant);
   }
 
+  public void removeCorruptedCleanAction() {
+    HoodieTableMetaClient client = writeClient.getHoodieTable().getMetaClient();
+    HoodieTimeline cleanerTimeline = client.getActiveTimeline().getCleanerTimeline();
+
+    executor.execute(() -> {
+      LOG.info("Inspecting clean metadata in timeline for corrupted files");
+      cleanerTimeline.getInstants().forEach(instant -> {
+        try {
+          CleanerUtils.getCleanerPlan(client, instant);
+        } catch (AvroRuntimeException e) {
+          LOG.warn("Corruption found. Trying to remove corrupted clean instant file: " + instant);
+          FSUtils.deleteInstantFile(client.getFs(), client.getMetaPath(), instant);
+        } catch (IOException ioe) {
+          if (ioe.getMessage().contains("Not an Avro data file")) {
+            LOG.warn("Corruption found. Trying to remove corrupted clean instant file: " + instant);

Review comment:
       Move this work to `CleanFunction`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #3386: [HUDI-2270] Remove corrupted clean action

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3386:
URL: https://github.com/apache/hudi/pull/3386#issuecomment-961588050






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot removed a comment on pull request #3386: [HUDI-2270] Remove corrupted clean action

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3386:
URL: https://github.com/apache/hudi/pull/3386#issuecomment-891561132


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8ab1e7075ad5fa9898a867d36e5fdca206a7e800",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1320",
       "triggerID" : "8ab1e7075ad5fa9898a867d36e5fdca206a7e800",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e6d698f8a15907266e6c67094bff521eb090aa2",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1324",
       "triggerID" : "9e6d698f8a15907266e6c67094bff521eb090aa2",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9e6d698f8a15907266e6c67094bff521eb090aa2 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1324) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] danny0405 closed pull request #3386: [HUDI-2270] Remove corrupted clean action

Posted by GitBox <gi...@apache.org>.
danny0405 closed pull request #3386:
URL: https://github.com/apache/hudi/pull/3386


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] danny0405 commented on a change in pull request #3386: [HUDI-2270] Remove corrupted clean action

Posted by GitBox <gi...@apache.org>.
danny0405 commented on a change in pull request #3386:
URL: https://github.com/apache/hudi/pull/3386#discussion_r686438992



##########
File path: hudi-flink/src/main/java/org/apache/hudi/sink/CleanFunction.java
##########
@@ -90,4 +100,28 @@ public void snapshotState(FunctionSnapshotContext context) throws Exception {
   public void initializeState(FunctionInitializationContext context) throws Exception {
     // no operation
   }
+
+  private void removeCorruptedCleanAction() {
+    HoodieTableMetaClient client = writeClient.getHoodieTable().getMetaClient();
+    HoodieTimeline cleanerTimeline = client.getActiveTimeline().getCleanerTimeline();
+

Review comment:
       It is not that useful to only execute once in the `#open` method.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3386: [HUDI-2270] Remove corrupted clean action

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3386:
URL: https://github.com/apache/hudi/pull/3386#issuecomment-891561132


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8ab1e7075ad5fa9898a867d36e5fdca206a7e800",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1320",
       "triggerID" : "8ab1e7075ad5fa9898a867d36e5fdca206a7e800",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e6d698f8a15907266e6c67094bff521eb090aa2",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1324",
       "triggerID" : "9e6d698f8a15907266e6c67094bff521eb090aa2",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9e6d698f8a15907266e6c67094bff521eb090aa2 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1324) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3386: [HUDI-2270] Remove corrupted clean action

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3386:
URL: https://github.com/apache/hudi/pull/3386#issuecomment-891561132


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8ab1e7075ad5fa9898a867d36e5fdca206a7e800",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1320",
       "triggerID" : "8ab1e7075ad5fa9898a867d36e5fdca206a7e800",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8ab1e7075ad5fa9898a867d36e5fdca206a7e800 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1320) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3386: [HUDI-2270] Remove corrupted clean action

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3386:
URL: https://github.com/apache/hudi/pull/3386#issuecomment-891561132


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8ab1e7075ad5fa9898a867d36e5fdca206a7e800",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1320",
       "triggerID" : "8ab1e7075ad5fa9898a867d36e5fdca206a7e800",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e6d698f8a15907266e6c67094bff521eb090aa2",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "9e6d698f8a15907266e6c67094bff521eb090aa2",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8ab1e7075ad5fa9898a867d36e5fdca206a7e800 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1320) 
   * 9e6d698f8a15907266e6c67094bff521eb090aa2 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #3386: [HUDI-2270] Remove corrupted clean action

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3386:
URL: https://github.com/apache/hudi/pull/3386#issuecomment-961588050


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8ab1e7075ad5fa9898a867d36e5fdca206a7e800",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1320",
       "triggerID" : "8ab1e7075ad5fa9898a867d36e5fdca206a7e800",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e6d698f8a15907266e6c67094bff521eb090aa2",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1324",
       "triggerID" : "9e6d698f8a15907266e6c67094bff521eb090aa2",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9e6d698f8a15907266e6c67094bff521eb090aa2 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1324) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3386: [HUDI-2270] Remove corrupted clean action

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3386:
URL: https://github.com/apache/hudi/pull/3386#issuecomment-891561132


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8ab1e7075ad5fa9898a867d36e5fdca206a7e800",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1320",
       "triggerID" : "8ab1e7075ad5fa9898a867d36e5fdca206a7e800",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e6d698f8a15907266e6c67094bff521eb090aa2",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1324",
       "triggerID" : "9e6d698f8a15907266e6c67094bff521eb090aa2",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9e6d698f8a15907266e6c67094bff521eb090aa2 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1324) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] nsivabalan commented on pull request #3386: [HUDI-2270] Remove corrupted clean action

Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #3386:
URL: https://github.com/apache/hudi/pull/3386#issuecomment-1002334592


   @danny0405 : can you follow up on this PR. Is this still required even if we land 4016? If yes, can you review this. guess we might want to get it in for 0.10.1. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3386: [HUDI-2270] Remove corrupted clean action

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3386:
URL: https://github.com/apache/hudi/pull/3386#issuecomment-891561132


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8ab1e7075ad5fa9898a867d36e5fdca206a7e800",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1320",
       "triggerID" : "8ab1e7075ad5fa9898a867d36e5fdca206a7e800",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e6d698f8a15907266e6c67094bff521eb090aa2",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1324",
       "triggerID" : "9e6d698f8a15907266e6c67094bff521eb090aa2",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8ab1e7075ad5fa9898a867d36e5fdca206a7e800 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1320) 
   * 9e6d698f8a15907266e6c67094bff521eb090aa2 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1324) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #3386: [HUDI-2270] Remove corrupted clean action

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3386:
URL: https://github.com/apache/hudi/pull/3386#issuecomment-891561132


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8ab1e7075ad5fa9898a867d36e5fdca206a7e800",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "8ab1e7075ad5fa9898a867d36e5fdca206a7e800",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8ab1e7075ad5fa9898a867d36e5fdca206a7e800 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] yuzhaojing commented on a change in pull request #3386: [HUDI-2270] Remove corrupted clean action

Posted by GitBox <gi...@apache.org>.
yuzhaojing commented on a change in pull request #3386:
URL: https://github.com/apache/hudi/pull/3386#discussion_r686440531



##########
File path: hudi-flink/src/main/java/org/apache/hudi/sink/CleanFunction.java
##########
@@ -90,4 +100,28 @@ public void snapshotState(FunctionSnapshotContext context) throws Exception {
   public void initializeState(FunctionInitializationContext context) throws Exception {
     // no operation
   }
+
+  private void removeCorruptedCleanAction() {
+    HoodieTableMetaClient client = writeClient.getHoodieTable().getMetaClient();
+    HoodieTimeline cleanerTimeline = client.getActiveTimeline().getCleanerTimeline();
+

Review comment:
       Yes, execute this after every clean action is better.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3386: [HUDI-2270] Remove corrupted clean action

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3386:
URL: https://github.com/apache/hudi/pull/3386#issuecomment-891561132


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8ab1e7075ad5fa9898a867d36e5fdca206a7e800",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1320",
       "triggerID" : "8ab1e7075ad5fa9898a867d36e5fdca206a7e800",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9e6d698f8a15907266e6c67094bff521eb090aa2",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1324",
       "triggerID" : "9e6d698f8a15907266e6c67094bff521eb090aa2",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9e6d698f8a15907266e6c67094bff521eb090aa2 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1324) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] yuzhaojing commented on pull request #3386: [HUDI-2270] Remove corrupted clean action

Posted by GitBox <gi...@apache.org>.
yuzhaojing commented on pull request #3386:
URL: https://github.com/apache/hudi/pull/3386#issuecomment-994327630


   > might be a duplicate of #4016. Or do you want to keep it separate from the other patch. I am ok either ways. Can we please write some UTs if we plan to go ahead with the patch.
   
   If #4016 can fix the exception, this patch is unnecessary.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] nsivabalan commented on pull request #3386: [HUDI-2270] Remove corrupted clean action

Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #3386:
URL: https://github.com/apache/hudi/pull/3386#issuecomment-999692370


   sorry. I will let Danny continue the review on this. Check with danny on how to go about it. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] danny0405 commented on pull request #3386: [HUDI-2270] Remove corrupted clean action

Posted by GitBox <gi...@apache.org>.
danny0405 commented on pull request #3386:
URL: https://github.com/apache/hudi/pull/3386#issuecomment-1002893737


   Close because #4016 solves the problem.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org