You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "jomarko (via GitHub)" <gi...@apache.org> on 2025/04/16 09:40:00 UTC

[PR] kie-issues:1912: DMN VSCode Extension: Evaluation highlights feature … [incubator-kie-tools]

jomarko opened a new pull request, #3066:
URL: https://github.com/apache/incubator-kie-tools/pull/3066

   …should not be available
   
   Closes: https://github.com/apache/incubator-kie-issues/issues/1912
   
   ### Before
   ![Screenshot 2025-04-16 113413](https://github.com/user-attachments/assets/402fe955-9324-4e18-b88f-3c58d4085b90)
   
   
   ### After
   ![Screenshot 2025-04-16 113253](https://github.com/user-attachments/assets/630ed528-b08b-424c-9f89-a952b542b287)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] kie-issues#1912: DMN VS Code Extension: Evaluation highlights feature should not be available [incubator-kie-tools]

Posted by "jomarko (via GitHub)" <gi...@apache.org>.
jomarko commented on PR #3066:
URL: https://github.com/apache/incubator-kie-tools/pull/3066#issuecomment-2823277242

   @thiagoelg @kbowers-ibm thank you, feedback incorporated
   
   _Should the standalone DMN Editor support Evaluation Highlights? It uses the STANDALONE channel type._ - I do not think so.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] kie-issues#1912: DMN VS Code Extension: Evaluation highlights feature should not be available [incubator-kie-tools]

Posted by "thiagoelg (via GitHub)" <gi...@apache.org>.
thiagoelg commented on code in PR #3066:
URL: https://github.com/apache/incubator-kie-tools/pull/3066#discussion_r2054241432


##########
packages/dmn-editor/src/DmnEditor.tsx:
##########
@@ -167,6 +167,14 @@ export type DmnEditorProps = {
    * This is shown on the ErrorBoundary fallback component, when an uncaught error happens.
    */
   issueTrackerHref?: string;
+  /**
+   * Dmn Editor Overlays panel contains 'Evaluation Highlights' toggle
+   * However this toggle is supported only for specific channels, (currently Sandbox only)
+   * The Dmn Editor should not have knowledge about the channel it is opened in.
+   * Use this boolean flag to allow or disallow the feature use.
+   * Default value is false.

Review Comment:
   "A flag to enable 'Evaluation Highlights' on supported channels (only ONLINE for now)"
   
   I think this would be enough to give context.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] kie-issues#1912: DMN VS Code Extension: Evaluation highlights feature should not be available [incubator-kie-tools]

Posted by "kbowers-ibm (via GitHub)" <gi...@apache.org>.
kbowers-ibm commented on code in PR #3066:
URL: https://github.com/apache/incubator-kie-tools/pull/3066#discussion_r2053513101


##########
packages/dmn-editor/src/DmnEditor.tsx:
##########
@@ -167,6 +167,14 @@ export type DmnEditorProps = {
    * This is shown on the ErrorBoundary fallback component, when an uncaught error happens.
    */
   issueTrackerHref?: string;
+  /**
+   * Dmn Editor Overlays panel contains 'Evaluation Highlights' toggle
+   * However this toggle is supported only for specific channels, (currently Sandbox only)
+   * The Dmn Editor should not have knowledge about the channel it is opened in.
+   * Use this boolean flag to allow or disallow the feature use.
+   * Default value is false.

Review Comment:
   Maybe me being slightly nitpicky, but I think this comment belongs more in the PR description rather than here.
   I feel like this could be simplified to follow the format of the others, e.g.
   A flag to enable 'Evaluation Highlights' on the DMN Editor



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] kie-issues#1912: DMN VS Code Extension: Evaluation highlights feature should not be available [incubator-kie-tools]

Posted by "thiagoelg (via GitHub)" <gi...@apache.org>.
thiagoelg merged PR #3066:
URL: https://github.com/apache/incubator-kie-tools/pull/3066


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org