You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/07/18 10:02:28 UTC
[GitHub] [pulsar] aahmed-se opened a new pull request #7591: Further reduce core-modules profile list
aahmed-se opened a new pull request #7591:
URL: https://github.com/apache/pulsar/pull/7591
* Further reduce core-modules profile list
* Filter project by profile in functions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aahmed-se commented on pull request #7591: Further reduce core-modules profile list
Posted by GitBox <gi...@apache.org>.
aahmed-se commented on pull request #7591:
URL: https://github.com/apache/pulsar/pull/7591#issuecomment-660635340
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai commented on a change in pull request #7591: Further reduce core-modules profile list
Posted by GitBox <gi...@apache.org>.
jiazhai commented on a change in pull request #7591:
URL: https://github.com/apache/pulsar/pull/7591#discussion_r456791408
##########
File path: pom.xml
##########
@@ -1799,14 +1799,12 @@ flexible messaging model and an intuitive client API.</description>
<module>pulsar-common</module>
<module>pulsar-broker-common</module>
<module>pulsar-broker</module>
- <module>pulsar-broker-shaded</module>
<module>pulsar-client-api</module>
<module>pulsar-client</module>
<module>pulsar-client-admin</module>
<module>pulsar-client-admin-shaded</module>
<module>pulsar-client-tools</module>
<module>pulsar-client-tools-test</module>
- <module>pulsar-client-all</module>
Review comment:
Why do we need to remove these 2 modules?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aahmed-se commented on pull request #7591: Further reduce core-modules profile list
Posted by GitBox <gi...@apache.org>.
aahmed-se commented on pull request #7591:
URL: https://github.com/apache/pulsar/pull/7591#issuecomment-660573783
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aahmed-se commented on pull request #7591: Further reduce core-modules profile list
Posted by GitBox <gi...@apache.org>.
aahmed-se commented on pull request #7591:
URL: https://github.com/apache/pulsar/pull/7591#issuecomment-660592901
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai commented on a change in pull request #7591: Further reduce core-modules profile list
Posted by GitBox <gi...@apache.org>.
jiazhai commented on a change in pull request #7591:
URL: https://github.com/apache/pulsar/pull/7591#discussion_r457077111
##########
File path: pom.xml
##########
@@ -1799,14 +1799,12 @@ flexible messaging model and an intuitive client API.</description>
<module>pulsar-common</module>
<module>pulsar-broker-common</module>
<module>pulsar-broker</module>
- <module>pulsar-broker-shaded</module>
<module>pulsar-client-api</module>
<module>pulsar-client</module>
<module>pulsar-client-admin</module>
<module>pulsar-client-admin-shaded</module>
<module>pulsar-client-tools</module>
<module>pulsar-client-tools-test</module>
- <module>pulsar-client-all</module>
Review comment:
Thanks for the explanation. we may need some docs for this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aahmed-se commented on pull request #7591: Further reduce core-modules profile list
Posted by GitBox <gi...@apache.org>.
aahmed-se commented on pull request #7591:
URL: https://github.com/apache/pulsar/pull/7591#issuecomment-660562348
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aahmed-se commented on pull request #7591: Further reduce core-modules profile list
Posted by GitBox <gi...@apache.org>.
aahmed-se commented on pull request #7591:
URL: https://github.com/apache/pulsar/pull/7591#issuecomment-660581697
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aahmed-se commented on a change in pull request #7591: Further reduce core-modules profile list
Posted by GitBox <gi...@apache.org>.
aahmed-se commented on a change in pull request #7591:
URL: https://github.com/apache/pulsar/pull/7591#discussion_r456796071
##########
File path: pom.xml
##########
@@ -1799,14 +1799,12 @@ flexible messaging model and an intuitive client API.</description>
<module>pulsar-common</module>
<module>pulsar-broker-common</module>
<module>pulsar-broker</module>
- <module>pulsar-broker-shaded</module>
<module>pulsar-client-api</module>
<module>pulsar-client</module>
<module>pulsar-client-admin</module>
<module>pulsar-client-admin-shaded</module>
<module>pulsar-client-tools</module>
<module>pulsar-client-tools-test</module>
- <module>pulsar-client-all</module>
Review comment:
We are building a minimal set of modules targeting developers using ide's they can choose the core profile and be more productive.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat commented on a change in pull request #7591: Further reduce core-modules profile list
Posted by GitBox <gi...@apache.org>.
merlimat commented on a change in pull request #7591:
URL: https://github.com/apache/pulsar/pull/7591#discussion_r460061598
##########
File path: pom.xml
##########
@@ -1799,14 +1799,12 @@ flexible messaging model and an intuitive client API.</description>
<module>pulsar-common</module>
<module>pulsar-broker-common</module>
<module>pulsar-broker</module>
- <module>pulsar-broker-shaded</module>
<module>pulsar-client-api</module>
<module>pulsar-client</module>
<module>pulsar-client-admin</module>
<module>pulsar-client-admin-shaded</module>
<module>pulsar-client-tools</module>
<module>pulsar-client-tools-test</module>
- <module>pulsar-client-all</module>
Review comment:
@jiazhai There's no change for default behavior, this is just to leave option to just do a minimal build build. It's mentioned in README at https://github.com/apache/pulsar#minimal-build-this-skips-most-of-external-connectors-and-tiered-storage-handlers
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat merged pull request #7591: Further reduce core-modules profile list
Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #7591:
URL: https://github.com/apache/pulsar/pull/7591
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org