You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2023/01/17 13:12:16 UTC
[GitHub] [doris] cambyzju opened a new pull request, #16027: [refractor](schema) refractor function Schema::get_column_by_field to make it simple
cambyzju opened a new pull request, #16027:
URL: https://github.com/apache/doris/pull/16027
# Proposed changes
Issue Number: close #xxx
## Problem summary
`DataTypeFactory::instance().create_data_type` will consider `Field.is_nullable`, may return type T or Nullable(T).
Then datatype `create_column`, will create Column or ColumnNullable(Column).
So we do not need to create ColumnNullable manually.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16027: [refractor](schema) refractor function Schema::get_column_by_field to make it simple
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #16027:
URL: https://github.com/apache/doris/pull/16027#issuecomment-1386387112
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #16027: [refractor](schema) refractor function Schema::get_column_by_field to make it simple
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #16027:
URL: https://github.com/apache/doris/pull/16027#issuecomment-1385848201
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.51 seconds
load time: 500 seconds
storage size: 17122462582 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230117182551_clickbench_pr_82539.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16027: [refractor](schema) refractor function Schema::get_column_by_field to make it simple
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #16027:
URL: https://github.com/apache/doris/pull/16027#issuecomment-1385407665
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #16027: [refractor](schema) refractor function Schema::get_column_by_field to make it simple
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #16027:
URL: https://github.com/apache/doris/pull/16027
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org