You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hawq.apache.org by liming01 <gi...@git.apache.org> on 2016/02/01 04:07:37 UTC
[GitHub] incubator-hawq pull request: HAWQ-373: Fixed QE coredump in pg_enc...
GitHub user liming01 opened a pull request:
https://github.com/apache/incubator-hawq/pull/309
HAWQ-373: Fixed QE coredump in pg_encoding_mbcliplen when run concrur…
…rent copy in stress
The root cause is:
In the function copy_in_error_callback() we should consider the process data may be incomplete because master maybe quit at any time when error issues.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/liming01/incubator-hawq mli/copy_crash_at_dispatcher
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/309.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #309
----
commit 8f01bbf2add71028f3253a5f0df13bca5321e3b4
Author: Ming LI <ml...@pivotal.io>
Date: 2016-02-01T03:03:48Z
HAWQ-373: Fixed QE coredump in pg_encoding_mbcliplen when run concrurrent copy in stress
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-373: Fixed QE coredump in pg_enc...
Posted by huor <gi...@git.apache.org>.
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/309#discussion_r51377938
--- Diff: src/backend/commands/copy.c ---
@@ -6243,9 +6243,12 @@ copy_in_error_callback(void *arg)
line_start = copy_of_line_buf.data;
lineno_delim = memchr(line_start, COPY_METADATA_DELIM, Min(32, cstate->line_buf.len));
- value_len = lineno_delim - line_start + 1;
- copy_of_line_buf.data += value_len; /* advance beyond line_buf_converted */
- copy_of_line_buf.len -= value_len;
+ if (lineno_delim)
--- End diff --
The indentation need to be followed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-373: Fixed QE coredump in pg_enc...
Posted by liming01 <gi...@git.apache.org>.
Github user liming01 closed the pull request at:
https://github.com/apache/incubator-hawq/pull/309
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-373: Fixed QE coredump in pg_enc...
Posted by wangzw <gi...@git.apache.org>.
Github user wangzw commented on the pull request:
https://github.com/apache/incubator-hawq/pull/309#issuecomment-177775969
The fix looks good. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-373: Fixed QE coredump in pg_enc...
Posted by huor <gi...@git.apache.org>.
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/309#issuecomment-177754590
The overall fix looks good. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---