You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by yhuai <gi...@git.apache.org> on 2015/11/05 17:47:59 UTC
[GitHub] spark pull request: [SPARK-10648] [SQL] [BRANCH-1.4] Oracle dialec...
GitHub user yhuai opened a pull request:
https://github.com/apache/spark/pull/9498
[SPARK-10648] [SQL] [BRANCH-1.4] Oracle dialect to handle nonspecific numeric types
This backports https://github.com/apache/spark/pull/9495 to branch-1.4 (in case anyone needs this).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yhuai/spark OracleDialect-1.4
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/9498.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #9498
----
commit 471fd40cf5638f25d313c35ecbd0fde1f383cf6d
Author: Yin Huai <yh...@databricks.com>
Date: 2015-11-05T16:40:10Z
[SPARK-10648] Oracle dialect to handle nonspecific numeric types #9495
Squashed commit of the following:
commit a1370a7a93e1bc4e2f908be980165223d0f67d58
Author: Travis Hegner <th...@trilliumit.com>
Date: Thu Nov 5 11:10:35 2015 -0500
style cleanup
commit 839bcb582e138144b2d0757c9471de3a7cacc2ac
Author: Travis Hegner <th...@trilliumit.com>
Date: Thu Nov 5 10:06:19 2015 -0500
more attribution
commit 3157ed5a71047ed85e8d80d4ef92c34273c38f1e
Author: Travis Hegner <th...@trilliumit.com>
Date: Thu Nov 5 10:04:09 2015 -0500
adding canHandle override, and registration of OracleDialect
commit cc764d47d25eb35ae6c38c1caf1a87d65bdd10fc
Author: Travis Hegner <th...@trilliumit.com>
Date: Thu Nov 5 09:53:43 2015 -0500
initial attempt
Conflicts:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10648] [SQL] [BRANCH-1.4] Oracle dialec...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9498#issuecomment-154160472
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10648] [SQL] [BRANCH-1.4] Oracle dialec...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9498#issuecomment-154160476
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45123/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10648] [SQL] [BRANCH-1.4] Oracle dialec...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9498#issuecomment-154120209
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10648] [SQL] [BRANCH-1.4] Oracle dialec...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9498#issuecomment-154160236
[Test build #45123 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45123/consoleFull) for PR 9498 at commit [`471fd40`](https://github.com/apache/spark/commit/471fd40cf5638f25d313c35ecbd0fde1f383cf6d).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10648] [SQL] [BRANCH-1.4] Oracle dialec...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9498#issuecomment-154120234
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10648] [SQL] [BRANCH-1.4] Oracle dialec...
Posted by yhuai <gi...@git.apache.org>.
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/9498#issuecomment-154169354
Since this is a very isolated small change. I am merging this to branch 1.4.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10648] [SQL] [BRANCH-1.4] Oracle dialec...
Posted by yhuai <gi...@git.apache.org>.
Github user yhuai closed the pull request at:
https://github.com/apache/spark/pull/9498
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10648] [SQL] [BRANCH-1.4] Oracle dialec...
Posted by yhuai <gi...@git.apache.org>.
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/9498#issuecomment-154170779
Actually, I also merged it in to branch 1.5. I am closing this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10648] [SQL] [BRANCH-1.4] Oracle dialec...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9498#issuecomment-154122626
[Test build #45123 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45123/consoleFull) for PR 9498 at commit [`471fd40`](https://github.com/apache/spark/commit/471fd40cf5638f25d313c35ecbd0fde1f383cf6d).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org