You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/08/20 08:45:23 UTC

[GitHub] [hudi] hehuiyuan opened a new pull request, #6453: fix to use enum class value for default value in flinkoptions

hehuiyuan opened a new pull request, #6453:
URL: https://github.com/apache/hudi/pull/6453

   ### Change Logs
   
   1. Use Enum Class instead of constant string for option default value in FlinkOptions.
   2. fix doc error for default value
   ![image](https://user-images.githubusercontent.com/18002496/185736834-81825dc6-9c4f-4633-8783-fb52239ce6a2.png)
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #6453: fix to use enum class value for default value in flinkoptions

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6453:
URL: https://github.com/apache/hudi/pull/6453#issuecomment-1221274097

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a906f47df90c5baeaadc95e5cdffb1044e55fd71",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10847",
       "triggerID" : "a906f47df90c5baeaadc95e5cdffb1044e55fd71",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a906f47df90c5baeaadc95e5cdffb1044e55fd71 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10847) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] danny0405 commented on a diff in pull request #6453: [HUDI-4683][hudi-flink] Fix to use enum class value for default value in flinkoptions

Posted by GitBox <gi...@apache.org>.
danny0405 commented on code in PR #6453:
URL: https://github.com/apache/hudi/pull/6453#discussion_r951125720


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java:
##########
@@ -656,7 +659,7 @@ private FlinkOptions() {
   public static final ConfigOption<String> CLUSTERING_PLAN_PARTITION_FILTER_MODE_NAME = ConfigOptions
       .key("clustering.plan.partition.filter.mode")

Review Comment:
   Can we also 
   1. rename the param `payload.ordering.field` to `precombine.field`;
   2. flip `write.ignore.failed` default to be false.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #6453: [HUDI-4683][hudi-flink] Fix to use enum class value for default value in flinkoptions

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6453:
URL: https://github.com/apache/hudi/pull/6453#issuecomment-1221879031

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a906f47df90c5baeaadc95e5cdffb1044e55fd71",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10847",
       "triggerID" : "a906f47df90c5baeaadc95e5cdffb1044e55fd71",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cae64f31852be70fa21b9ebcf49f30e3e6543dd2",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "cae64f31852be70fa21b9ebcf49f30e3e6543dd2",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a906f47df90c5baeaadc95e5cdffb1044e55fd71 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10847) 
   * cae64f31852be70fa21b9ebcf49f30e3e6543dd2 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] danny0405 commented on pull request #6453: [HUDI-4683][hudi-flink] Fix to use enum class value for default value in flinkoptions

Posted by GitBox <gi...@apache.org>.
danny0405 commented on PR #6453:
URL: https://github.com/apache/hudi/pull/6453#issuecomment-1221987823

   Hi, the tests are failing, can you rebase the latest master and force-push again ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #6453: [HUDI-4683][hudi-flink] Fix to use enum class value for default value in flinkoptions

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6453:
URL: https://github.com/apache/hudi/pull/6453#issuecomment-1221884322

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a906f47df90c5baeaadc95e5cdffb1044e55fd71",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10847",
       "triggerID" : "a906f47df90c5baeaadc95e5cdffb1044e55fd71",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cae64f31852be70fa21b9ebcf49f30e3e6543dd2",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10868",
       "triggerID" : "cae64f31852be70fa21b9ebcf49f30e3e6543dd2",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a906f47df90c5baeaadc95e5cdffb1044e55fd71 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10847) 
   * cae64f31852be70fa21b9ebcf49f30e3e6543dd2 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10868) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #6453: [HUDI-4683] Use enum class value for default value in flink options

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6453:
URL: https://github.com/apache/hudi/pull/6453#issuecomment-1222004913

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a906f47df90c5baeaadc95e5cdffb1044e55fd71",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10847",
       "triggerID" : "a906f47df90c5baeaadc95e5cdffb1044e55fd71",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cae64f31852be70fa21b9ebcf49f30e3e6543dd2",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10868",
       "triggerID" : "cae64f31852be70fa21b9ebcf49f30e3e6543dd2",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * cae64f31852be70fa21b9ebcf49f30e3e6543dd2 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10868) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] danny0405 commented on a diff in pull request #6453: [HUDI-4683] Use enum class value for default value in flink options

Posted by GitBox <gi...@apache.org>.
danny0405 commented on code in PR #6453:
URL: https://github.com/apache/hudi/pull/6453#discussion_r951125720


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java:
##########
@@ -656,7 +659,7 @@ private FlinkOptions() {
   public static final ConfigOption<String> CLUSTERING_PLAN_PARTITION_FILTER_MODE_NAME = ConfigOptions
       .key("clustering.plan.partition.filter.mode")

Review Comment:
   Can we also 
   1. rename the param `payload.ordering.field` to `precombine.field`;
   2. flip `write.ignore.failed` default to be false.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] danny0405 merged pull request #6453: [HUDI-4683] Use enum class value for default value in flink options

Posted by GitBox <gi...@apache.org>.
danny0405 merged PR #6453:
URL: https://github.com/apache/hudi/pull/6453


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #6453: fix to use enum class value for default value in flinkoptions

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6453:
URL: https://github.com/apache/hudi/pull/6453#issuecomment-1221263748

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a906f47df90c5baeaadc95e5cdffb1044e55fd71",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a906f47df90c5baeaadc95e5cdffb1044e55fd71",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a906f47df90c5baeaadc95e5cdffb1044e55fd71 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] danny0405 commented on pull request #6453: fix to use enum class value for default value in flinkoptions

Posted by GitBox <gi...@apache.org>.
danny0405 commented on PR #6453:
URL: https://github.com/apache/hudi/pull/6453#issuecomment-1221781431

   Thanks, can we fire a JIRA issue here: https://issues.apache.org/jira/browse/HUDI-3096
   and change the commit title to the form:
   `[HUDI-${JIRA ID}] ${your commit title}`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #6453: fix to use enum class value for default value in flinkoptions

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6453:
URL: https://github.com/apache/hudi/pull/6453#issuecomment-1221264355

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a906f47df90c5baeaadc95e5cdffb1044e55fd71",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10847",
       "triggerID" : "a906f47df90c5baeaadc95e5cdffb1044e55fd71",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a906f47df90c5baeaadc95e5cdffb1044e55fd71 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10847) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org