You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Timothy Chen <tn...@apache.org> on 2014/08/22 21:12:37 UTC
Review Request 24987: Fail when no command provided with shell
enabled in docker
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24987/
-----------------------------------------------------------
Review request for mesos and Benjamin Hindman.
Repository: mesos-git
Description
-------
Fail when no command provided with shell enabled in docker
Diffs
-----
src/docker/docker.cpp ad5886b6fa2f39bd0a8c93f31d8e334fb0ba2537
src/tests/docker_tests.cpp 3d0270252e8f7889a72ad2eb5bfec4c3b2f58953
Diff: https://reviews.apache.org/r/24987/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 24987: Fail when no command provided with shell
enabled in docker
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24987/#review52042
-----------------------------------------------------------
Tim, can you close this review? It's submitted.
- Jie Yu
On Aug. 29, 2014, 6:44 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24987/
> -----------------------------------------------------------
>
> (Updated Aug. 29, 2014, 6:44 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Jie Yu.
>
>
> Bugs: MESOS-1730
> https://issues.apache.org/jira/browse/MESOS-1730
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Review: https://reviews.apache.org/r/24987
>
>
> Diffs
> -----
>
> src/docker/docker.cpp ad5886b6fa2f39bd0a8c93f31d8e334fb0ba2537
> src/tests/docker_tests.cpp 3d0270252e8f7889a72ad2eb5bfec4c3b2f58953
>
> Diff: https://reviews.apache.org/r/24987/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 24987: Fail when no command provided with shell
enabled in docker
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24987/#review51943
-----------------------------------------------------------
Bad patch!
Reviews applied: [24987]
Failed command: git apply --index 24987.patch
Error:
error: patch failed: src/docker/docker.cpp:325
error: src/docker/docker.cpp: patch does not apply
error: patch failed: src/tests/docker_tests.cpp:41
error: src/tests/docker_tests.cpp: patch does not apply
- Mesos ReviewBot
On Aug. 29, 2014, 6:44 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24987/
> -----------------------------------------------------------
>
> (Updated Aug. 29, 2014, 6:44 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Jie Yu.
>
>
> Bugs: MESOS-1730
> https://issues.apache.org/jira/browse/MESOS-1730
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Review: https://reviews.apache.org/r/24987
>
>
> Diffs
> -----
>
> src/docker/docker.cpp ad5886b6fa2f39bd0a8c93f31d8e334fb0ba2537
> src/tests/docker_tests.cpp 3d0270252e8f7889a72ad2eb5bfec4c3b2f58953
>
> Diff: https://reviews.apache.org/r/24987/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 24987: Fail when no command provided with shell
enabled in docker
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24987/
-----------------------------------------------------------
(Updated Aug. 29, 2014, 6:44 p.m.)
Review request for mesos, Benjamin Hindman and Jie Yu.
Bugs: MESOS-1730
https://issues.apache.org/jira/browse/MESOS-1730
Repository: mesos-git
Description (updated)
-------
Review: https://reviews.apache.org/r/24987
Diffs (updated)
-----
src/docker/docker.cpp ad5886b6fa2f39bd0a8c93f31d8e334fb0ba2537
src/tests/docker_tests.cpp 3d0270252e8f7889a72ad2eb5bfec4c3b2f58953
Diff: https://reviews.apache.org/r/24987/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 24987: Fail when no command provided with shell
enabled in docker
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24987/#review51888
-----------------------------------------------------------
Ship it!
src/docker/docker.cpp
<https://reviews.apache.org/r/24987/#comment90559>
s/enabled/specified/
src/tests/docker_tests.cpp
<https://reviews.apache.org/r/24987/#comment90560>
No need to use resources right?
src/tests/docker_tests.cpp
<https://reviews.apache.org/r/24987/#comment90561>
s/resources/None()/
- Jie Yu
On Aug. 24, 2014, 5:04 a.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24987/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2014, 5:04 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Jie Yu.
>
>
> Bugs: MESOS-1730
> https://issues.apache.org/jira/browse/MESOS-1730
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Fail when no command provided with shell enabled in docker
>
>
> Diffs
> -----
>
> src/docker/docker.cpp ad5886b6fa2f39bd0a8c93f31d8e334fb0ba2537
> src/tests/docker_tests.cpp 3d0270252e8f7889a72ad2eb5bfec4c3b2f58953
>
> Diff: https://reviews.apache.org/r/24987/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 24987: Fail when no command provided with shell
enabled in docker
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24987/
-----------------------------------------------------------
(Updated Aug. 24, 2014, 5:04 a.m.)
Review request for mesos, Benjamin Hindman and Jie Yu.
Bugs: MESOS-1730
https://issues.apache.org/jira/browse/MESOS-1730
Repository: mesos-git
Description
-------
Fail when no command provided with shell enabled in docker
Diffs
-----
src/docker/docker.cpp ad5886b6fa2f39bd0a8c93f31d8e334fb0ba2537
src/tests/docker_tests.cpp 3d0270252e8f7889a72ad2eb5bfec4c3b2f58953
Diff: https://reviews.apache.org/r/24987/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 24987: Fail when no command provided with shell
enabled in docker
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24987/
-----------------------------------------------------------
(Updated Aug. 22, 2014, 7:14 p.m.)
Review request for mesos and Benjamin Hindman.
Bugs: MESOS-1730
https://issues.apache.org/jira/browse/MESOS-1730
Repository: mesos-git
Description
-------
Fail when no command provided with shell enabled in docker
Diffs
-----
src/docker/docker.cpp ad5886b6fa2f39bd0a8c93f31d8e334fb0ba2537
src/tests/docker_tests.cpp 3d0270252e8f7889a72ad2eb5bfec4c3b2f58953
Diff: https://reviews.apache.org/r/24987/diff/
Testing
-------
make check
Thanks,
Timothy Chen