You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openoffice.apache.org by lin yuan <yu...@gmail.com> on 2012/06/11 10:53:45 UTC
[Call-For-Review] Fix for i119652 - [From Symphony]When press
"Ctrl+Shift+Backspace" in table cell "A1" ,Undo,crash
I have submit a patch to fix issue i119652. It's a crash issue if user
use "Ctrl+Shift+Backspace" to delete a paragraph in the first cell in a
table and then do "undo" action.
Detail info and comments of this issue please refer to
https://issues.apache.org/ooo/show_bug.cgi?id=119652
Patch info please refer to
https://issues.apache.org/ooo/attachment.cgi?id=78230
Please help review this fix. Thanks.
Thanks,
Lin Yuan
Re: [Call-For-Review] Fix for i119652 - [From Symphony]When press
"Ctrl+Shift+Backspace" in table cell "A1" ,Undo,crash
Posted by chengjh <ch...@apache.org>.
Reviewed and Committed with revision:1352384.
Currently,AOO only provides to select within a table or select content
range containing table(s). And it does not provide to select content range
crossing tables that means the start position and end position are locating
at different tables,or one is within a table,another is not..The current
code implementation logic of SwEditShell::DeleteSel() doesn't consider the
situations either.So, this patch will only consider the supported
scenarios..other limitations will not be considered here..Because they are
capabilities and usability improvement,we need prioritize it according to
end users' feedback in the future.thanks.
On Tue, Jun 19, 2012 at 5:10 PM, chengjh <ch...@apache.org> wrote:
> I will take care of this issue..
>
>
> On Tue, Jun 19, 2012 at 5:01 PM, Lin Yuan <yu...@gmail.com> wrote:
>
>> Thanks for the advice. I added more detail description about root cause
>> and
>> resolution.
>>
>> 2012/6/19 chengjh <ch...@apache.org>
>>
>> > Hi Lin,
>> >
>> > Please describe the root cause more clearly...And if solution
>> description
>> > can be added,that will be better.thanks.
>> >
>> > On Mon, Jun 11, 2012 at 4:53 PM, lin yuan <yu...@gmail.com>
>> wrote:
>> >
>> > > I have submit a patch to fix issue i119652. It's a crash issue if
>> user
>> > > use "Ctrl+Shift+Backspace" to delete a paragraph in the first cell
>> in a
>> > > table and then do "undo" action.
>> > > Detail info and comments of this issue please refer to
>> > > https://issues.apache.org/ooo/show_bug.cgi?id=119652
>> > > Patch info please refer to
>> > > https://issues.apache.org/ooo/attachment.cgi?id=78230
>> > >
>> > > Please help review this fix. Thanks.
>> > >
>> > > Thanks,
>> > > Lin Yuan
>> > >
>> >
>> >
>> >
>> > --
>> >
>> > Best Regards,Jianhong Cheng
>> >
>>
>
>
>
> --
>
> Best Regards,Jianhong Cheng
>
>
--
Best Regards,Jianhong Cheng
Re: [Call-For-Review] Fix for i119652 - [From Symphony]When press
"Ctrl+Shift+Backspace" in table cell "A1" ,Undo,crash
Posted by chengjh <ch...@apache.org>.
I will take care of this issue..
On Tue, Jun 19, 2012 at 5:01 PM, Lin Yuan <yu...@gmail.com> wrote:
> Thanks for the advice. I added more detail description about root cause and
> resolution.
>
> 2012/6/19 chengjh <ch...@apache.org>
>
> > Hi Lin,
> >
> > Please describe the root cause more clearly...And if solution description
> > can be added,that will be better.thanks.
> >
> > On Mon, Jun 11, 2012 at 4:53 PM, lin yuan <yu...@gmail.com> wrote:
> >
> > > I have submit a patch to fix issue i119652. It's a crash issue if user
> > > use "Ctrl+Shift+Backspace" to delete a paragraph in the first cell in
> a
> > > table and then do "undo" action.
> > > Detail info and comments of this issue please refer to
> > > https://issues.apache.org/ooo/show_bug.cgi?id=119652
> > > Patch info please refer to
> > > https://issues.apache.org/ooo/attachment.cgi?id=78230
> > >
> > > Please help review this fix. Thanks.
> > >
> > > Thanks,
> > > Lin Yuan
> > >
> >
> >
> >
> > --
> >
> > Best Regards,Jianhong Cheng
> >
>
--
Best Regards,Jianhong Cheng
Re: [Call-For-Review] Fix for i119652 - [From Symphony]When press
"Ctrl+Shift+Backspace" in table cell "A1" ,Undo,crash
Posted by Lin Yuan <yu...@gmail.com>.
Thanks for the advice. I added more detail description about root cause and
resolution.
2012/6/19 chengjh <ch...@apache.org>
> Hi Lin,
>
> Please describe the root cause more clearly...And if solution description
> can be added,that will be better.thanks.
>
> On Mon, Jun 11, 2012 at 4:53 PM, lin yuan <yu...@gmail.com> wrote:
>
> > I have submit a patch to fix issue i119652. It's a crash issue if user
> > use "Ctrl+Shift+Backspace" to delete a paragraph in the first cell in a
> > table and then do "undo" action.
> > Detail info and comments of this issue please refer to
> > https://issues.apache.org/ooo/show_bug.cgi?id=119652
> > Patch info please refer to
> > https://issues.apache.org/ooo/attachment.cgi?id=78230
> >
> > Please help review this fix. Thanks.
> >
> > Thanks,
> > Lin Yuan
> >
>
>
>
> --
>
> Best Regards,Jianhong Cheng
>
Re: [Call-For-Review] Fix for i119652 - [From Symphony]When press
"Ctrl+Shift+Backspace" in table cell "A1" ,Undo,crash
Posted by chengjh <ch...@apache.org>.
Hi Lin,
Please describe the root cause more clearly...And if solution description
can be added,that will be better.thanks.
On Mon, Jun 11, 2012 at 4:53 PM, lin yuan <yu...@gmail.com> wrote:
> I have submit a patch to fix issue i119652. It's a crash issue if user
> use "Ctrl+Shift+Backspace" to delete a paragraph in the first cell in a
> table and then do "undo" action.
> Detail info and comments of this issue please refer to
> https://issues.apache.org/ooo/show_bug.cgi?id=119652
> Patch info please refer to
> https://issues.apache.org/ooo/attachment.cgi?id=78230
>
> Please help review this fix. Thanks.
>
> Thanks,
> Lin Yuan
>
--
Best Regards,Jianhong Cheng