You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tika.apache.org by "Dave Brosius (JIRA)" <ji...@apache.org> on 2011/02/20 03:19:38 UTC
[jira] Created: (TIKA-600) [patch] suspect transferable code
[patch] suspect transferable code
----------------------------------
Key: TIKA-600
URL: https://issues.apache.org/jira/browse/TIKA-600
Project: Tika
Issue Type: Bug
Components: gui
Affects Versions: 0.8
Reporter: Dave Brosius
Priority: Minor
Fix For: 0.9
Attachments: fix_npe.diff
the importData code has suspect code, where an if/else branch handles the same condition in two branches (differently)
else if (transferable.isDataFlavorSupported(urlListFlavor)) {
...
else if (transferable.isDataFlavorSupported(uriListFlavor)) {
which caused the NPE... Patch fixes the npe, but that is just a patch. the real fix is to fix the if/else code.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (TIKA-600) [patch] suspect transferable code
Posted by "Chris A. Mattmann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TIKA-600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris A. Mattmann updated TIKA-600:
-----------------------------------
Affects Version/s: 0.9
Fix Version/s: (was: 0.9)
1.0
0.9 is out the door - fix version should be 1.0
> [patch] suspect transferable code
> ----------------------------------
>
> Key: TIKA-600
> URL: https://issues.apache.org/jira/browse/TIKA-600
> Project: Tika
> Issue Type: Bug
> Components: gui
> Affects Versions: 0.8, 0.9
> Reporter: Dave Brosius
> Priority: Minor
> Fix For: 1.0
>
> Attachments: fix_npe.diff
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> the importData code has suspect code for urlListFlavor handling.
> the files variable is never set in this case.
> which caused the NPE... Patch fixes the npe.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (TIKA-600) [patch] suspect transferable code
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TIKA-600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting resolved TIKA-600.
--------------------------------
Resolution: Fixed
Assignee: Jukka Zitting
Good catch, thanks! I committed a slightly modified fix in revision 1079894.
> [patch] suspect transferable code
> ----------------------------------
>
> Key: TIKA-600
> URL: https://issues.apache.org/jira/browse/TIKA-600
> Project: Tika
> Issue Type: Bug
> Components: gui
> Affects Versions: 0.8, 0.9
> Reporter: Dave Brosius
> Assignee: Jukka Zitting
> Priority: Minor
> Fix For: 1.0
>
> Attachments: fix_npe.diff
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> the importData code has suspect code for urlListFlavor handling.
> the files variable is never set in this case.
> which caused the NPE... Patch fixes the npe.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (TIKA-600) [patch] suspect transferable code
Posted by "Dave Brosius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TIKA-600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dave Brosius updated TIKA-600:
------------------------------
Description:
the importData code has suspect code for urlListFlavor handling.
the files variable is never set in this case.
which caused the NPE... Patch fixes the npe.
was:
the importData code has suspect code, where an if/else branch handles the same condition in two branches (differently)
else if (transferable.isDataFlavorSupported(urlListFlavor)) {
...
else if (transferable.isDataFlavorSupported(uriListFlavor)) {
which caused the NPE... Patch fixes the npe, but that is just a patch. the real fix is to fix the if/else code.
> [patch] suspect transferable code
> ----------------------------------
>
> Key: TIKA-600
> URL: https://issues.apache.org/jira/browse/TIKA-600
> Project: Tika
> Issue Type: Bug
> Components: gui
> Affects Versions: 0.8
> Reporter: Dave Brosius
> Priority: Minor
> Fix For: 0.9
>
> Attachments: fix_npe.diff
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> the importData code has suspect code for urlListFlavor handling.
> the files variable is never set in this case.
> which caused the NPE... Patch fixes the npe.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira