[GitHub] [james-project] chibenwa commented on a diff in pull request #1559: JAMES-3906 Add hot reloading/updating of the certificate: new interfa…

["chibenwa (via GitHub)" <gi...@apache.org>]

chibenwa commented on code in PR #1559:
URL: https://github.com/apache/james-project/pull/1559#discussion_r1191828967


##########
server/protocols/protocols-imap4/src/main/java/org/apache/james/imapserver/webadmin/ImapRoutes.java:
##########
@@ -0,0 +1,22 @@
+package org.apache.james.imapserver.webadmin;

Review Comment:
   You are missing the compulsary Apache V2 license file header



##########
server/protocols/protocols-library/src/main/java/org/apache/james/protocols/lib/netty/CertificateReloadable.java:
##########
@@ -0,0 +1,6 @@
+package org.apache.james.protocols.lib.netty;

Review Comment:
   Idem



##########
server/protocols/protocols-library/pom.xml:
##########
@@ -52,6 +52,10 @@
                 </exclusion>
             </exclusions>
         </dependency>
+        <dependency>
+            <groupId>${james.groupId}</groupId>
+            <artifactId>james-server-webadmin-core</artifactId>
+        </dependency>

Review Comment:
   I think this dependency is a bad idea: now I can no longer use IMAP without pulling webadmin.
   
   I would prefer that we have a dedicated webadmin maven module for protocols.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org