You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2021/04/29 23:45:02 UTC
[kudu-CR] [client] return TimedOut if the deadline has passed in master RPCs
Hello Alexey Serbin, Bankim Bhavsar,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/17367
to review the following change.
Change subject: [client] return TimedOut if the deadline has passed in master RPCs
......................................................................
[client] return TimedOut if the deadline has passed in master RPCs
There was a narrow window in which we could return a NetworkError to
users of the master-bound RPCs instead of a TimedOut error. Without this
change I saw ClientTest.NoTxnManager fail 1/300 times -test and
TxnStatusTableITest.TestSystemClientMasterDown fail ~1/3 of the time
running in a loop via dist-test.
With this change, I ran it with no issue 1000/1000 times each.
This is a follow-up to 96047a8d861d61673b9e2589930eccd78a16e483.
Change-Id: I309ba70d62a48b4dc8fb0e8f30f532593c254860
---
M src/kudu/client/master_proxy_rpc.cc
M src/kudu/client/txn_manager_proxy_rpc.cc
2 files changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/17367/1
--
To view, visit http://gerrit.cloudera.org:8080/17367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I309ba70d62a48b4dc8fb0e8f30f532593c254860
Gerrit-Change-Number: 17367
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
[kudu-CR] [client] return TimedOut if the deadline has passed in master RPCs
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17367 )
Change subject: [client] return TimedOut if the deadline has passed in master RPCs
......................................................................
[client] return TimedOut if the deadline has passed in master RPCs
There was a narrow window in which we could return a NetworkError to
users of the master-bound RPCs instead of a TimedOut error. Without this
change I saw ClientTest.NoTxnManager fail 1/300 times and
TxnStatusTableITest.TestSystemClientMasterDown fail ~1/3 of the time
running in a loop via dist-test.
With this change, I ran it with no issue 1000/1000 times each.
This is a follow-up to 96047a8d861d61673b9e2589930eccd78a16e483.
Change-Id: I309ba70d62a48b4dc8fb0e8f30f532593c254860
Reviewed-on: http://gerrit.cloudera.org:8080/17367
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/client/master_proxy_rpc.cc
M src/kudu/client/txn_manager_proxy_rpc.cc
2 files changed, 6 insertions(+), 2 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Andrew Wong: Verified
--
To view, visit http://gerrit.cloudera.org:8080/17367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I309ba70d62a48b4dc8fb0e8f30f532593c254860
Gerrit-Change-Number: 17367
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [client] return TimedOut if the deadline has passed in master RPCs
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17367 )
Change subject: [client] return TimedOut if the deadline has passed in master RPCs
......................................................................
Patch Set 2: Verified+1
Test failures were unrelated, and TestKuduBackupLister.
--
To view, visit http://gerrit.cloudera.org:8080/17367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I309ba70d62a48b4dc8fb0e8f30f532593c254860
Gerrit-Change-Number: 17367
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 30 Apr 2021 07:07:41 +0000
Gerrit-HasComments: No
[kudu-CR] [client] return TimedOut if the deadline has passed in master RPCs
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Bankim Bhavsar,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17367
to look at the new patch set (#2).
Change subject: [client] return TimedOut if the deadline has passed in master RPCs
......................................................................
[client] return TimedOut if the deadline has passed in master RPCs
There was a narrow window in which we could return a NetworkError to
users of the master-bound RPCs instead of a TimedOut error. Without this
change I saw ClientTest.NoTxnManager fail 1/300 times and
TxnStatusTableITest.TestSystemClientMasterDown fail ~1/3 of the time
running in a loop via dist-test.
With this change, I ran it with no issue 1000/1000 times each.
This is a follow-up to 96047a8d861d61673b9e2589930eccd78a16e483.
Change-Id: I309ba70d62a48b4dc8fb0e8f30f532593c254860
---
M src/kudu/client/master_proxy_rpc.cc
M src/kudu/client/txn_manager_proxy_rpc.cc
2 files changed, 6 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/17367/2
--
To view, visit http://gerrit.cloudera.org:8080/17367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I309ba70d62a48b4dc8fb0e8f30f532593c254860
Gerrit-Change-Number: 17367
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [client] return TimedOut if the deadline has passed in master RPCs
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has removed a vote on this change.
Change subject: [client] return TimedOut if the deadline has passed in master RPCs
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/17367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I309ba70d62a48b4dc8fb0e8f30f532593c254860
Gerrit-Change-Number: 17367
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [client] return TimedOut if the deadline has passed in master RPCs
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17367 )
Change subject: [client] return TimedOut if the deadline has passed in master RPCs
......................................................................
Patch Set 2: Code-Review+2
Good catch!
--
To view, visit http://gerrit.cloudera.org:8080/17367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I309ba70d62a48b4dc8fb0e8f30f532593c254860
Gerrit-Change-Number: 17367
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 30 Apr 2021 05:21:57 +0000
Gerrit-HasComments: No