You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mynewt.apache.org by Szymon Janc <ja...@apache.org> on 2020/03/18 23:05:47 UTC
[VOTE] Release Apache Mynewt 1.8.0-rc1 and Apache NimBLE 1.3.0-rc1
Hello all,
I am pleased to be calling this vote for the source release of
Apache Mynewt 1.8.0 and Apache NimBLE 1.3.0.
Apache Mynewt is a community-driven, permissively licensed open source
initiative for constrained, embedded applications. Mynewt provides a
real-time operating system, flash file system, network stacks, and
support utilities for real-world embedded systems.
Apache NimBLE is Bluetooth Low Energy 5.1 stack from Apache Mynewt.
This release is coordinated release of Apache Mynewt and NimBLE. Future
NimBLE releases may be released separately depending on needs.
For full release notes for both Mynewt and NimBLE, please visit the Apache
Mynewt Wiki: https://cwiki.apache.org/confluence/display/MYNEWT/Release+Notes
Apache Mynewt and Apache NimBLE release candidates were tested as follows:
1. Manual execution of the Mynewt test plan:
https://cwiki.apache.org/confluence/display/MYNEWT/Apache+Mynewt+Test+Plan
The test results can be found at:
https://cwiki.apache.org/confluence/display/MYNEWT/1.8.0+Test+Results
2. Manual execution of the NimBLE test plan:
https://cwiki.apache.org/confluence/display/MYNEWT/Apache+NimBLE+Test+Plan
The test results can be found at:
https://cwiki.apache.org/confluence/display/MYNEWT/NimBLE+1.3.0+Test+Results
Note that this testing is not yet complete and more results will show while
voting is ongoing.
2. The full unit test suite for both releases was executed via "newt test all"
with no failures. This testing was performed on the following platforms:
* OS X 10.15
* Fedora Linux 32
The release candidate to be voted on is available at:
https://dist.apache.org/repos/dist/dev/mynewt/apache-mynewt-1.8.0/rc1/
https://dist.apache.org/repos/dist/dev/mynewt/apache-nimble-1.3.0/rc1/
The commits under consideration are as follows:
blinky:
repos: https://github.com/apache/mynewt-blinky
commit 51fdaca7faffd9ff37df1b1d11f11007fc30c8cd
core:
repos: https://github.com/apache/mynewt-core
commit fce93de30559adcb9bbaa1807ace31a16505c988
newt:
repos: https://github.com/apache/mynewt-newt
commit ab96a8ac29568516dddf56af00bab856ebd93e18
newtmgr:
repos: https://github.com/apache/mynewt-newtmgr
commit 199917cf7f3ff8443697ef03d67bb0459ba8339c
nimble:
repos: https://github.com/apache/mynewt-nimble
commit 47cf31f687a5e56dd831f8387c9574f38bda0191
In addition, the following newt and newtmgr convenience binaries are available:
linux:
https://dist.apache.org/repos/dist/dev/mynewt/apache-mynewt-1.8.0/rc1/apache-mynewt-newt-bin-linux-1.8.0.tgz
https://dist.apache.org/repos/dist/dev/mynewt/apache-mynewt-1.8.0/rc1/apache-mynewt-newtmgr-bin-linux-1.8.0.tgz
osx:
https://dist.apache.org/repos/dist/dev/mynewt/apache-mynewt-1.8.0/rc1/apache-mynewt-newt-bin-osx-1.8.0.tgz
https://dist.apache.org/repos/dist/dev/mynewt/apache-mynewt-1.8.0/rc1/apache-mynewt-newtmgr-bin-osx-1.8.0.tgz
windows:
https://dist.apache.org/repos/dist/dev/mynewt/apache-mynewt-1.8.0/rc1/apache-mynewt-newt-bin-windows-1.8.0.tgz
https://dist.apache.org/repos/dist/dev/mynewt/apache-mynewt-1.8.0/rc1/apache-mynewt-newtmgr-bin-windows-1.8.0.tgz
The release candidate is signed with a GPG key available at:
https://dist.apache.org/repos/dist/dev/mynewt/KEYS
The vote is open for at least 72 hours and passes if a majority of at
least three +1 PMC votes are cast.
[ ] +1 Release this package
[ ] 0 I don't feel strongly about it, but don't object
[ ] -1 Do not release this package because...
Anyone can participate in testing and voting, not just committers,
please feel free to try out the release candidate and provide your
votes.
A separate [DISCUSS] thread will be opened to talk about this release
candidate.
--
pozdrawiam
Szymon Janc
Re: [VOTE] Release Apache Mynewt 1.8.0-rc1 and Apache NimBLE 1.3.0-rc1
Posted by Szymon Janc <sz...@codecoup.pl>.
Hi,
On Tuesday, 24 March 2020 13:59:05 CET Justin Mclean wrote:
> Hi,
>
> > Yeap, this is being fixed in
> > https://github.com/apache/mynewt-core/pull/2248
> Good to know, however I see another possible issue here:
> " The copyright holder assumes no responsibility
> * for the consequences of use
> * of such information nor for any infringement of patents or
> * other rights of third parties which may result from its use.
> * No license is granted by implication or otherwise under any patent or
> * patent rights of the copyright holder.”
>
> That would possibly be against the terms of the Apache license, (see section
> 3 grant of patent license) you may want to check this on legal dicuss.
We clarified this offline with copyright holder that intention was to use
BSD-3 license and this additional statement can be removed. PR is updated and
I'll merge once CI is finished.
--
pozdrawiam
Szymon Janc
Re: [VOTE] Release Apache Mynewt 1.8.0-rc1 and Apache NimBLE
1.3.0-rc1
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> Yeap, this is being fixed in https://github.com/apache/mynewt-core/pull/2248
Good to know, however I see another possible issue here:
" The copyright holder assumes no responsibility
* for the consequences of use
* of such information nor for any infringement of patents or
* other rights of third parties which may result from its use.
* No license is granted by implication or otherwise under any patent or
* patent rights of the copyright holder.”
That would possibly be against the terms of the Apache license, (see section 3 grant of patent license) you may want to check this on legal dicuss.
Thanks,
Justin
Re: [VOTE] Release Apache Mynewt 1.8.0-rc1 and Apache NimBLE 1.3.0-rc1
Posted by Szymon Janc <sz...@codecoup.pl>.
Hi,
On Tuesday, 24 March 2020 12:17:04 CET Justin Mclean wrote:
> Hi,
>
> >> * Which also seem to have an incorrect headers?
> >
> > While [15] is indeed odd, what do you mean by incorrect headers in other
> > files?
>
> 3rd party files shouldn’t have ASF headers on them.
Yeap, this is being fixed in https://github.com/apache/mynewt-core/pull/2248
> > So just to be sure, NOTICE should have listed all 3rd party but APL2
> > licensed code, while LICENCE should list all non-APL code?
>
> Not quite, if some code in included from an ALv2 project and it has a NOTICE
> file you need to look at it’s NOTICE and include the relevant parts in
> yours. If it doesn’t have a NOTICE file then nothing needs to be done.
Understood. I did some more reading on ASF pages and I think I have good
understanding now on how this should look.
--
pozdrawiam
Szymon Janc
Re: [VOTE] Release Apache Mynewt 1.8.0-rc1 and Apache NimBLE
1.3.0-rc1
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
>> * Which also seem to have an incorrect headers?
>
> While [15] is indeed odd, what do you mean by incorrect headers in other
> files?
3rd party files shouldn’t have ASF headers on them.
> So just to be sure, NOTICE should have listed all 3rd party but APL2 licensed
> code, while LICENCE should list all non-APL code?
Not quite, if some code in included from an ALv2 project and it has a NOTICE file you need to look at it’s NOTICE and include the relevant parts in yours. If it doesn’t have a NOTICE file then nothing needs to be done.
Thanks,
Justin
Re: [VOTE] Release Apache Mynewt 1.8.0-rc1 and Apache NimBLE 1.3.0-rc1
Posted by Vipul Rahane <vr...@gmail.com>.
+1 binding, tested with the latest on. Custom board, everything works well.
Regards,
Vipul Rahane
On Mon, Mar 23, 2020 at 3:23 AM Szymon Janc <sz...@codecoup.pl> wrote:
> Hi Justin,
>
> On Thursday, 19 March 2020 03:52:51 CET Justin Mclean wrote:
> > HI,
> >
> > Sorry but it’s -1 (binding) as LICENSE file are not correct.
>
> Uhm, yeah I'll clean that up and we will do rc2.
>
> >
> > I checked:
> > - signatures and hashes are fine
> > - Years in NOTICE are incorrect
> > - LICENSE for blink is fine, other LICENSE files are not (see below)
> > - no unexpected binary files
> > - all source file have ASF headers, some of them may incorrect headers
> > - did not compile from source
> >
> > For apache-mynewt-newtmgr-1.8.0 the LICENSE list a large number of
> things,
> > none of which seem to be actually bundled.
> >
> > the same with apache-mynewt-newt-1.8.0. I also note it does bundle some
> > files under the go versions libyaml but not the full list mentioned in
> > LICENSE.
> >
> > A spot check on core LICENSE show some missing or invalid paths e.g
> > [1][2][3][4][5][6][7][8][9][10] do these need to be removed from LICENSE?
>
> Some were removed, some renamed, I'll check that.
>
> > It also seems to be missing a number of things as well. This fiile*, [11]
> > Android Open Source Project, [12] Dialog Semiconductor, [13] Jan Van
> > Winkel*, several file copyright PHYTEC Messtechnik GmbH* e.g [14],
> several
> > files copyright Bosch Sensortec GmbH* eg [15], several file copyright Ac6
> > e.g [16], InvenSense, Inc [17] and several file copyright Embedded
> > Microprocessor Benchmark Consortium (EEMBC). They are probably others
> and I
> > didn’t;t check any ARM or STMircrocontroller files.
>
> Yes, [15] looks odd with those double licenses although it was clarified
> for
> header file, but not for .c file in PR [20].
>
> > * Which also seem to have an incorrect headers?
>
> While [15] is indeed odd, what do you mean by incorrect headers in other
> files?
>
> >
> > I did the above check by comparing with the 1.5 release as it's LICENSE
> file
> > is identical, but as the LICENSE file hasn’t changed in 2 year which mean
> > there’s probably more to be done and we’ll need to check with an easier
> > release (1.3 release?)
> >
> > It may also be that NOTICE file are incoresst as I some of teh files
> added
> > are 3rd part file that are Apache licensed.
>
> So just to be sure, NOTICE should have listed all 3rd party but APL2
> licensed
> code, while LICENCE should list all non-APL code?
>
> > I didn’t check the binaries.
> >
> > Thanks,
> > Justin
> >
> > 1. hw/bsp/nrf51dk/src/arch/cortex_m0/gcc_startup_nrf51.s
> > 2. hw/bsp/stm32l152discovery/src/system_stm32l1xx.c
> > 3. hw/bsp/nrf52840pdk/split-nrf52840pdk.ld
> > 4. docs/_static/css/bootstrap-3.0.3.min.css
> > 5 docs/themes/mynewt/static/js/affix.js
> > 6 docs/themes/mynewt/static/js/scrollspy.js
> > 7 docs/themes/mynewt/static/fonts/fontawesome-webfont.eot
> > 8 docs/themes/mynewt/static/fonts/Inconsolata-Bold.ttf
> > 9 docs/themes/mynewt/static/fonts/Lato-Bold.ttf
> > 10 hw/mcu/arc/src/ext/sdk
> > 11. ./hw/drivers/display/cfb/src/cfb_fonts.c
> > 12 ./hw/mcu/dialog/include/DA1469xAB.h
> > 13. ./hw/drivers/display/include/display/display.h
> > 14. ./hw/drivers/display/cfb/include/display/cfb.h
> > 15 ./hw/drivers/sensors/bmp388/src/bmp388_shell.c
> >
> 16../hw/mcu/stm/stm32wbxx/src/ext/Drivers/CMSIS/Device/ST/STM32WBxx/Source/T
> > emplates/gcc/linker/stm32wb55xx_flash_cm4.ld 17
> > ./hw/drivers/sensors/icp101xx/License.txt
> > 18 ./apps/coremark/include/core_portme.h
>
>
> [20] https://github.com/apache/mynewt-core/pull/1819
>
> --
> pozdrawiam
> Szymon Janc
>
>
>
> --
Regards,
Vipul Rahane
Re: [VOTE] Release Apache Mynewt 1.8.0-rc1 and Apache NimBLE 1.3.0-rc1
Posted by Szymon Janc <sz...@codecoup.pl>.
Hi Justin,
On Thursday, 19 March 2020 03:52:51 CET Justin Mclean wrote:
> HI,
>
> Sorry but it’s -1 (binding) as LICENSE file are not correct.
Uhm, yeah I'll clean that up and we will do rc2.
>
> I checked:
> - signatures and hashes are fine
> - Years in NOTICE are incorrect
> - LICENSE for blink is fine, other LICENSE files are not (see below)
> - no unexpected binary files
> - all source file have ASF headers, some of them may incorrect headers
> - did not compile from source
>
> For apache-mynewt-newtmgr-1.8.0 the LICENSE list a large number of things,
> none of which seem to be actually bundled.
>
> the same with apache-mynewt-newt-1.8.0. I also note it does bundle some
> files under the go versions libyaml but not the full list mentioned in
> LICENSE.
>
> A spot check on core LICENSE show some missing or invalid paths e.g
> [1][2][3][4][5][6][7][8][9][10] do these need to be removed from LICENSE?
Some were removed, some renamed, I'll check that.
> It also seems to be missing a number of things as well. This fiile*, [11]
> Android Open Source Project, [12] Dialog Semiconductor, [13] Jan Van
> Winkel*, several file copyright PHYTEC Messtechnik GmbH* e.g [14], several
> files copyright Bosch Sensortec GmbH* eg [15], several file copyright Ac6
> e.g [16], InvenSense, Inc [17] and several file copyright Embedded
> Microprocessor Benchmark Consortium (EEMBC). They are probably others and I
> didn’t;t check any ARM or STMircrocontroller files.
Yes, [15] looks odd with those double licenses although it was clarified for
header file, but not for .c file in PR [20].
> * Which also seem to have an incorrect headers?
While [15] is indeed odd, what do you mean by incorrect headers in other
files?
>
> I did the above check by comparing with the 1.5 release as it's LICENSE file
> is identical, but as the LICENSE file hasn’t changed in 2 year which mean
> there’s probably more to be done and we’ll need to check with an easier
> release (1.3 release?)
>
> It may also be that NOTICE file are incoresst as I some of teh files added
> are 3rd part file that are Apache licensed.
So just to be sure, NOTICE should have listed all 3rd party but APL2 licensed
code, while LICENCE should list all non-APL code?
> I didn’t check the binaries.
>
> Thanks,
> Justin
>
> 1. hw/bsp/nrf51dk/src/arch/cortex_m0/gcc_startup_nrf51.s
> 2. hw/bsp/stm32l152discovery/src/system_stm32l1xx.c
> 3. hw/bsp/nrf52840pdk/split-nrf52840pdk.ld
> 4. docs/_static/css/bootstrap-3.0.3.min.css
> 5 docs/themes/mynewt/static/js/affix.js
> 6 docs/themes/mynewt/static/js/scrollspy.js
> 7 docs/themes/mynewt/static/fonts/fontawesome-webfont.eot
> 8 docs/themes/mynewt/static/fonts/Inconsolata-Bold.ttf
> 9 docs/themes/mynewt/static/fonts/Lato-Bold.ttf
> 10 hw/mcu/arc/src/ext/sdk
> 11. ./hw/drivers/display/cfb/src/cfb_fonts.c
> 12 ./hw/mcu/dialog/include/DA1469xAB.h
> 13. ./hw/drivers/display/include/display/display.h
> 14. ./hw/drivers/display/cfb/include/display/cfb.h
> 15 ./hw/drivers/sensors/bmp388/src/bmp388_shell.c
> 16../hw/mcu/stm/stm32wbxx/src/ext/Drivers/CMSIS/Device/ST/STM32WBxx/Source/T
> emplates/gcc/linker/stm32wb55xx_flash_cm4.ld 17
> ./hw/drivers/sensors/icp101xx/License.txt
> 18 ./apps/coremark/include/core_portme.h
[20] https://github.com/apache/mynewt-core/pull/1819
--
pozdrawiam
Szymon Janc
Re: [VOTE] Release Apache Mynewt 1.8.0-rc1 and Apache NimBLE
1.3.0-rc1
Posted by Justin Mclean <ju...@classsoftware.com>.
HI,
Sorry but it’s -1 (binding) as LICENSE file are not correct.
I checked:
- signatures and hashes are fine
- Years in NOTICE are incorrect
- LICENSE for blink is fine, other LICENSE files are not (see below)
- no unexpected binary files
- all source file have ASF headers, some of them may incorrect headers
- did not compile from source
For apache-mynewt-newtmgr-1.8.0 the LICENSE list a large number of things, none of which seem to be actually bundled.
the same with apache-mynewt-newt-1.8.0. I also note it does bundle some files under the go versions libyaml but not the full list mentioned in LICENSE.
A spot check on core LICENSE show some missing or invalid paths e.g [1][2][3][4][5][6][7][8][9][10] do these need to be removed from LICENSE?
It also seems to be missing a number of things as well. This fiile*, [11] Android Open Source Project, [12] Dialog Semiconductor, [13] Jan Van Winkel*, several file copyright PHYTEC Messtechnik GmbH* e.g [14], several files copyright Bosch Sensortec GmbH* eg [15], several file copyright Ac6 e.g [16], InvenSense, Inc [17] and several file copyright Embedded Microprocessor Benchmark Consortium (EEMBC). They are probably others and I didn’t;t check any ARM or STMircrocontroller files.
* Which also seem to have an incorrect headers?
I did the above check by comparing with the 1.5 release as it's LICENSE file is identical, but as the LICENSE file hasn’t changed in 2 year which mean there’s probably more to be done and we’ll need to check with an easier release (1.3 release?)
It may also be that NOTICE file are incoresst as I some of teh files added are 3rd part file that are Apache licensed.
I didn’t check the binaries.
Thanks,
Justin
1. hw/bsp/nrf51dk/src/arch/cortex_m0/gcc_startup_nrf51.s
2. hw/bsp/stm32l152discovery/src/system_stm32l1xx.c
3. hw/bsp/nrf52840pdk/split-nrf52840pdk.ld
4. docs/_static/css/bootstrap-3.0.3.min.css
5 docs/themes/mynewt/static/js/affix.js
6 docs/themes/mynewt/static/js/scrollspy.js
7 docs/themes/mynewt/static/fonts/fontawesome-webfont.eot
8 docs/themes/mynewt/static/fonts/Inconsolata-Bold.ttf
9 docs/themes/mynewt/static/fonts/Lato-Bold.ttf
10 hw/mcu/arc/src/ext/sdk
11. ./hw/drivers/display/cfb/src/cfb_fonts.c
12 ./hw/mcu/dialog/include/DA1469xAB.h
13. ./hw/drivers/display/include/display/display.h
14. ./hw/drivers/display/cfb/include/display/cfb.h
15 ./hw/drivers/sensors/bmp388/src/bmp388_shell.c
16../hw/mcu/stm/stm32wbxx/src/ext/Drivers/CMSIS/Device/ST/STM32WBxx/Source/Templates/gcc/linker/stm32wb55xx_flash_cm4.ld
17 ./hw/drivers/sensors/icp101xx/License.txt
18 ./apps/coremark/include/core_portme.h