You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "srdo (via GitHub)" <gi...@apache.org> on 2025/04/18 19:48:18 UTC
[PR] WIP: Build with Java 24 [kafka]
srdo opened a new pull request, #19514:
URL: https://github.com/apache/kafka/pull/19514
WIP: This PR still uses a Gradle 8.14 RC, and Spotbugs 4.9.4 has not released yet, so testing it requires a local build.
Upgrade Scala to 2.13.16, in order to get a Java 24-compatible ASM version.
Upgrade Gradle to 8.14, which is the first Java 24 compatible version.
Upgrade spotbugs to 4.9.4. This is the minimum version that's both
Java 24 compatible, and not affected by https://github.com/spotbugs/spotbugs/issues/3320
Since the new spotbugs version introduces some extra checks, this commit
excludes those warnings, without looking at whether they are real issues
or false positives.
Addressing those warnings is left as future work, since the code is no worse now than before the issues were highlighted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WIP: Test against Java 24 [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19514:
URL: https://github.com/apache/kafka/pull/19514#issuecomment-2903138225
A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the `triage` label
should be removed to prevent this automation from happening again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WIP: Test against Java 24 [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #19514:
URL: https://github.com/apache/kafka/pull/19514#issuecomment-2896856077
@srdo could you please rebase code and fix the conflicts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WIP: Test against Java 24 [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19514:
URL: https://github.com/apache/kafka/pull/19514#issuecomment-2831792777
A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the `triage` label
should be removed to prevent this automation from happening again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WIP: Test against Java 24 [kafka]
Posted by "srdo (via GitHub)" <gi...@apache.org>.
srdo commented on PR #19514:
URL: https://github.com/apache/kafka/pull/19514#issuecomment-2843288842
Status: This passes tests locally. As Gradle 8.14 has released, the only remaining roadblock is that the currently-newest version of Spotbugs crashes the build. The underlying bug is fixed in the latest Spotbugs source, so once Spotbugs 4.9.4 is released (see https://github.com/spotbugs/spotbugs/discussions/3380#discussioncomment-12998251), this should be good to go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WIP: Test against Java 24 [kafka]
Posted by "srdo (via GitHub)" <gi...@apache.org>.
srdo closed pull request #19514: WIP: Test against Java 24
URL: https://github.com/apache/kafka/pull/19514
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WIP: Test against Java 24 [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19514:
URL: https://github.com/apache/kafka/pull/19514#issuecomment-2846229695
A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the `triage` label
should be removed to prevent this automation from happening again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WIP: Test against Java 24 [kafka]
Posted by "srdo (via GitHub)" <gi...@apache.org>.
srdo commented on PR #19514:
URL: https://github.com/apache/kafka/pull/19514#issuecomment-3070127396
@chia7712 I would, but Spotbugs 4.9.4 has still not released. I'll update this PR as soon as they put out the new version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WIP: Test against Java 24 [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19514:
URL: https://github.com/apache/kafka/pull/19514#issuecomment-2833884934
A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the `triage` label
should be removed to prevent this automation from happening again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WIP: Test against Java 24 [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #19514:
URL: https://github.com/apache/kafka/pull/19514#issuecomment-3069461834
@srdo could you please use spotbug 4.9.4 to trigger CI again? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WIP: Test against Java 24 [kafka]
Posted by "srdo (via GitHub)" <gi...@apache.org>.
srdo commented on PR #19514:
URL: https://github.com/apache/kafka/pull/19514#issuecomment-2898410433
@chia7712 Sure, rebased. But this won't be mergeable until the next Spotbugs release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WIP: Test against Java 24 [kafka]
Posted by "srdo (via GitHub)" <gi...@apache.org>.
srdo commented on PR #19514:
URL: https://github.com/apache/kafka/pull/19514#issuecomment-3146464381
@chia7712 I don't know how far off a new spotbugs release is, and I'd rather not keep blocking on that.
I was thinking we could cut this into 3 parts, where 2 can be merged immediately:
* Upgrading Spotbugs to the latest version not affected by https://github.com/spotbugs/spotbugs/pull/3311, which would break the build on Java 23. This is version 4.9.1. I've done that upgrade in https://github.com/apache/kafka/pull/20294. I think doing this makes sense, because it'll at least help flag some potential concurrency bugs that aren't caught by the current Spotbugs version.
* Making CI run Java 24, but with spotbugs disabled. Since CI will run the build on 17 as well, there isn't really a strong need to run spotbugs on Java 24 right now, so skipping it for now seems better than continuing to block the Java 24 upgrade while waiting for spotbugs to do a new release. I'm going to do that in https://github.com/apache/kafka/pull/20295.
* Once Spotbugs 4.9.4 releases, we can upgrade to that and let CI run spotbugs on Java 24 again. I can repurpose this PR to do that once 4.9.4 is released.
I think this is better than continuing to block everything, including being able to test against Java 24, on Spotbugs putting out a new release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WIP: Test against Java 24 [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19514:
URL: https://github.com/apache/kafka/pull/19514#issuecomment-3149033883
A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the `triage` label
should be removed to prevent this automation from happening again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WIP: Test against Java 24 [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19514:
URL: https://github.com/apache/kafka/pull/19514#issuecomment-3076630475
A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the `triage` label
should be removed to prevent this automation from happening again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org