Re: [PR] feat(storage): inline polaris.storage.name overrides for namespace/table [polaris]

["tokoko (via GitHub)" <gi...@apache.org>]

tokoko commented on code in PR #4023:
URL: https://github.com/apache/polaris/pull/4023#discussion_r3364827472


##########
runtime/service/src/main/java/org/apache/polaris/service/storage/PolarisStorageIntegrationProviderImpl.java:
##########
@@ -129,8 +129,7 @@ public PolarisStorageIntegrationProviderImpl(
   @Override
   public @Nullable PolarisStorageIntegration getStorageIntegration(
       @NonNull List<PolarisEntity> resolvedEntityPath) {
-    return PolarisStorageConfigurationInfo.findStorageInfoFromHierarchy(resolvedEntityPath)

Review Comment:
   can we get rid of `PolarisStorageConfigurationInfo.findStorageInfoFromHierarchy`? `StorageConfigOverrideResolver.resolveEffectiveConfig` seems like a more correct replacement for it now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org