You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/07/16 07:40:23 UTC
[GitHub] [netbeans] mbien opened a new pull request, #4389: Let ClassSource check for null elements in constructor.
mbien opened a new pull request, #4389:
URL: https://github.com/apache/netbeans/pull/4389
addToProjectClassPath() would fail later with a less useful stacktrace as observed in #4365.
(this doesn't really fix a bug, it makes finding bugs a bit easier)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #4389: Let ClassSource check for null elements in constructor.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #4389:
URL: https://github.com/apache/netbeans/pull/4389#issuecomment-1186123931
> I think either is ok. Since the list itself is not null only the entry I opted for IAE here.
OK, makes sense.
> is already in progress, will be a different PR.
I'll stop working on it and wait for yours then! :laughing:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien merged pull request #4389: Let ClassSource check for null elements in constructor.
Posted by GitBox <gi...@apache.org>.
mbien merged PR #4389:
URL: https://github.com/apache/netbeans/pull/4389
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #4389: Let ClassSource check for null elements in constructor.
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #4389:
URL: https://github.com/apache/netbeans/pull/4389#issuecomment-1186123110
> Sounds good, although wonder if it should still be a `NullPointerException`?
I think either is ok. Since the list itself is not null only the entry I opted for IAE here.
>
> In terms of #4365 then a bigger thing is probably validation of `jdk.home` at https://github.com/apache/netbeans/blob/master/java/java.j2seplatform/src/org/netbeans/modules/java/j2seplatform/platformdefinition/DefaultPlatformImpl.java#L56 Or just relying on `java.home`.
is already in progress, will be a different PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists