You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eagle.apache.org by qingwen220 <gi...@git.apache.org> on 2015/12/29 04:27:58 UTC
[GitHub] incubator-eagle pull request: EAGLE-100 Provide tools to collect h...
GitHub user qingwen220 opened a pull request:
https://github.com/apache/incubator-eagle/pull/46
EAGLE-100 Provide tools to collect hadoop jmx metrics
https://issues.apache.org/jira/browse/EAGLE-100
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/qingwen220/incubator-eagle EAGLE-100
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-eagle/pull/46.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #46
----
commit 315f555ab394c3d3e6767412323e713a2bd40334
Author: Zhao, Qingwen <qi...@ebay.com>
Date: 2015-12-28T10:00:29Z
add hadoop jmx collector scripts
commit 54f5dc76643aa914c57c5c6675b4637e2d908026
Author: Zhao, Qingwen <qi...@ebay.com>
Date: 2015-12-29T03:20:06Z
add license
commit c76e68e66d5994d68a8e325a71a4fffe61fcb54c
Author: Zhao, Qingwen <qi...@ebay.com>
Date: 2015-12-29T03:25:36Z
update README
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request: EAGLE-100 Provide tools to collect h...
Posted by qingwen220 <gi...@git.apache.org>.
Github user qingwen220 commented on the pull request:
https://github.com/apache/incubator-eagle/pull/46#issuecomment-167922198
Yes, I agree with your comments. Thanks. I will update the scripts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request: EAGLE-100 Provide tools to collect h...
Posted by yonzhang <gi...@git.apache.org>.
Github user yonzhang commented on the pull request:
https://github.com/apache/incubator-eagle/pull/46#issuecomment-167901101
Comments:
1. I want to apply the patch in my local machine. It fails, you will have the same issue when you apply the patch to master. You probably need collapse all your commits into one commits, then it will not have any conflict
2. the script only query jmx with "qry=Hadoop:*", then we will miss other metric like java.lang:* etc. Can the script download everything, but use the configuration in eagle-collector.conf to specify which parts to preserve.
I will continue to review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request: EAGLE-100 Provide tools to collect h...
Posted by yonzhang <gi...@git.apache.org>.
Github user yonzhang commented on the pull request:
https://github.com/apache/incubator-eagle/pull/46#issuecomment-167907289
another comments: can we make this tool into eagle-external?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request: EAGLE-100 Provide tools to collect h...
Posted by yonzhang <gi...@git.apache.org>.
Github user yonzhang commented on the pull request:
https://github.com/apache/incubator-eagle/pull/46#issuecomment-167904154
more comments:
1) site attribute should be part of metric dimension
2) I would suggest we change attribute name "type" to "component"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request: EAGLE-100 Provide tools to collect h...
Posted by qingwen220 <gi...@git.apache.org>.
Github user qingwen220 closed the pull request at:
https://github.com/apache/incubator-eagle/pull/46
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---