You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2022/04/08 14:01:24 UTC
[GitHub] [fineract] josehernandezfintecheandomx opened a new pull request, #2271: FINERACT-1568 Fix Datatable creation fails on PostgreSQL
josehernandezfintecheandomx opened a new pull request, #2271:
URL: https://github.com/apache/fineract/pull/2271
## Description
In attention for the Ticket FINERACT- related to issues in the datatable creation using PostgreSQL
Ignore if these details are present on the associated [Apache Fineract JIRA ticket FINERACT-1568](https://issues.apache.org/jira/browse/FINERACT-1568).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #2271: FINERACT-1568 Fix Datatable creation fails on PostgreSQL
Posted by GitBox <gi...@apache.org>.
ptuomola commented on PR #2271:
URL: https://github.com/apache/fineract/pull/2271#issuecomment-1093530888
I can't make it run either... But it's not clear to me what it is trying to run anyway. All the 5 workflows are already marked as success so not sure what's pending.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics commented on pull request #2271: FINERACT-1568 Fix Datatable creation fails on PostgreSQL
Posted by GitBox <gi...@apache.org>.
galovics commented on PR #2271:
URL: https://github.com/apache/fineract/pull/2271#issuecomment-1093891244
Strange, I can't run it either but the workflows are successful. Maybe it's just a stuck bit in GH Actions which will be immediately resolved if we push a new commit. Not sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic commented on pull request #2271: FINERACT-1568 Fix Datatable creation fails on PostgreSQL
Posted by GitBox <gi...@apache.org>.
vidakovic commented on PR #2271:
URL: https://github.com/apache/fineract/pull/2271#issuecomment-1093524270
For some reason I can't make this workflow run... can someone else please try?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] josehernandezfintecheandomx commented on pull request #2271: FINERACT-1568 Fix Datatable creation fails on PostgreSQL
Posted by GitBox <gi...@apache.org>.
josehernandezfintecheandomx commented on PR #2271:
URL: https://github.com/apache/fineract/pull/2271#issuecomment-1098154846
Included in other PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] josehernandezfintecheandomx closed pull request #2271: FINERACT-1568 Fix Datatable creation fails on PostgreSQL
Posted by GitBox <gi...@apache.org>.
josehernandezfintecheandomx closed pull request #2271: FINERACT-1568 Fix Datatable creation fails on PostgreSQL
URL: https://github.com/apache/fineract/pull/2271
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org