You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2025/06/13 02:01:28 UTC
[PR] GH-46798: [CI][Dev] Add support for pre-commit 2.17.0 [arrow]
kou opened a new pull request, #46799:
URL: https://github.com/apache/arrow/pull/46799
### Rationale for this change
Ubuntu 22.04 ships pre-commit 2.17.0. So we should support pre-commit 2.17.0 for easy to develop.
### What changes are included in this PR?
* Use a bit older shfmt pre-commit configuration for pre-commit 2.17.0
* Use Ubuntu 22.04 on CI to ensure working on Ubuntu 22.04
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46798: [CI][Dev] Add support for pre-commit 2.17.0 [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #46799:
URL: https://github.com/apache/arrow/pull/46799#issuecomment-2969164953
> I am -0.5 on this. With pre-commit being a normal python package that can be easily installed I don't think we should limit ourselves to OS provided versions.
I can understand your opinion but there are developers/contributors who aren't familiar with Python packages because this repository has many language implementations. So I want to reduce developers/contributors costs to prepare their development environment.
> Though in this case I doubt there are many differences between the two versions? If some other hook needs a newer version we can always reconsider.
I'm OK with this approach. We may require more recent pre-commit when we need it before Ubuntu 22.04 reaches EOL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46798: [CI][Dev] Add support for pre-commit 2.17.0 [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #46799:
URL: https://github.com/apache/arrow/pull/46799
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46798: [CI][Dev] Add support for pre-commit 2.17.0 [arrow]
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on PR #46799:
URL: https://github.com/apache/arrow/pull/46799#issuecomment-2969412121
@thisisnic yeah the error message is not great. The shfmt hook makes use of a feature only introduced in newer version so it sets a lower limit. I don't understand why the error doesn't say that...
Unless there is a feature we want to use in newer version/hooks I'm fine with making this apt compatible!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46798: [CI][Dev] Add support for pre-commit 2.17.0 [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #46799:
URL: https://github.com/apache/arrow/pull/46799#issuecomment-2968753038
:warning: GitHub issue #46798 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46798: [CI][Dev] Add support for pre-commit 2.17.0 [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #46799:
URL: https://github.com/apache/arrow/pull/46799#issuecomment-3638599228
After merging your PR, Conbench analyzed the 0 benchmarking runs that have been run so far on merge-commit 69f55f007ba0eea956d40f5f053786366963f13a.
None of the specified runs were found on the Conbench server.
The [full Conbench report](https://github.com/apache/arrow/runs/57706177165) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46798: [CI][Dev] Add support for pre-commit 2.17.0 [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #46799:
URL: https://github.com/apache/arrow/pull/46799#issuecomment-2969345096
OK. Let's use this approach (developers/contributors can use their common ways to install pre-commit. e.g. `apt` on Ubuntu) for now. We can revisit how to solve this when we get a new report.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46798: [CI][Dev] Add support for pre-commit 2.17.0 [arrow]
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on PR #46799:
URL: https://github.com/apache/arrow/pull/46799#issuecomment-2969249846
> I am -0.5 on this. With pre-commit being a normal python package that can be easily installed I don't think we should limit ourselves to OS provided versions.
I'm neutral on **what** approach we take but we absolutely should make sure we're not introducing additional friction for developers. If we choose not to support the older version, we should at least be *very* explicit about installation method in our docs then - i.e. that you must install the package using pip not apt.
The error message from pre-commit in the case of an older version doesn't make it obvious why it's not working. Took a good chunk frustration (until dumping the error into an LLM worked) to solve it when I ran into this.
> Though in this case I doubt there are many differences between the two versions? If some other hook needs a newer version we can always reconsider.
The `pre-commit` command itself seems to not be part of earlier versions (see my error message on linked ticket).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org