You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2026/06/16 16:28:10 UTC

[kudu-CR] [thirdparty] crcutil: fix arch detection on Redhat 10

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24477


Change subject: [thirdparty] crcutil: fix arch detection on Redhat 10
......................................................................

[thirdparty] crcutil: fix arch detection on Redhat 10

This changelist updates crcutil in 3rd-party up to the latest version
in the git repo at the time of writing [1].  An update from the prior
version is switching from 'uname -p' to 'uname -m' to provide relevant
information on RedHat10.

[1] https://github.com/cloudera/crcutil/commit/0437b1a99

Change-Id: Ie1d353ee3e7b3d5187cd9107a0f0609dd5cff4d6
---
M thirdparty/vars.sh
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/24477/1
-- 
To view, visit http://gerrit.cloudera.org:8080/24477
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie1d353ee3e7b3d5187cd9107a0f0609dd5cff4d6
Gerrit-Change-Number: 24477
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>

[kudu-CR] [thirdparty] fix arch detection in crcutil on Redhat10

Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24477 )

Change subject: [thirdparty] fix arch detection in crcutil on Redhat10
......................................................................

[thirdparty] fix arch detection in crcutil on Redhat10

This changelist updates crcutil in 3rd-party up to the latest version
in the git repo at the time of writing [1].  An update from the prior
version is switching from 'uname -p' to 'uname -m' to provide relevant
information on RedHat10.

[1] https://github.com/cloudera/crcutil/commit/0437b1a99

Change-Id: Ie1d353ee3e7b3d5187cd9107a0f0609dd5cff4d6
Reviewed-on: http://gerrit.cloudera.org:8080/24477
Tested-by: Kudu Jenkins
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Reviewed-by: Zoltan Chovan <zc...@cloudera.com>
Reviewed-by: Marton Greber <gr...@gmail.com>
---
M thirdparty/patches/crcutil-fix-macos-arm64-flags.patch
M thirdparty/vars.sh
2 files changed, 7 insertions(+), 7 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Joe McDonnell: Looks good to me, but someone else must approve
  Zoltan Chovan: Looks good to me, approved
  Marton Greber: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/24477
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie1d353ee3e7b3d5187cd9107a0f0609dd5cff4d6
Gerrit-Change-Number: 24477
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>

[kudu-CR] [thirdparty] crcutil: fix arch detection on Redhat 10

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24477 )

Change subject: [thirdparty] crcutil: fix arch detection on Redhat 10
......................................................................


Patch Set 1:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/2668/


-- 
To view, visit http://gerrit.cloudera.org:8080/24477
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1d353ee3e7b3d5187cd9107a0f0609dd5cff4d6
Gerrit-Change-Number: 24477
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 16 Jun 2026 16:28:17 +0000
Gerrit-HasComments: No

[kudu-CR] [thirdparty] crcutil: fix arch detection on Redhat 10

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24477 )

Change subject: [thirdparty] crcutil: fix arch detection on Redhat 10
......................................................................


Patch Set 1: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/2668/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/24477
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1d353ee3e7b3d5187cd9107a0f0609dd5cff4d6
Gerrit-Change-Number: 24477
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 16 Jun 2026 16:28:32 +0000
Gerrit-HasComments: No

[kudu-CR] [thirdparty] fix arch detection in crcutil on Redhat10

Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/24477 )

Change subject: [thirdparty] fix arch detection in crcutil on Redhat10
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/24477
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1d353ee3e7b3d5187cd9107a0f0609dd5cff4d6
Gerrit-Change-Number: 24477
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Jun 2026 09:18:02 +0000
Gerrit-HasComments: No

[kudu-CR] [thirdparty] fix arch detection in crcutil on Redhat10

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24477 )

Change subject: [thirdparty] fix arch detection in crcutil on Redhat10
......................................................................


Patch Set 2:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/2669/


-- 
To view, visit http://gerrit.cloudera.org:8080/24477
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1d353ee3e7b3d5187cd9107a0f0609dd5cff4d6
Gerrit-Change-Number: 24477
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 16 Jun 2026 17:33:22 +0000
Gerrit-HasComments: No

[kudu-CR] [thirdparty] fix arch detection in crcutil on Redhat10

Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/24477 )

Change subject: [thirdparty] fix arch detection in crcutil on Redhat10
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/24477
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1d353ee3e7b3d5187cd9107a0f0609dd5cff4d6
Gerrit-Change-Number: 24477
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Jun 2026 07:25:36 +0000
Gerrit-HasComments: No

[kudu-CR] [thirdparty] fix arch detection in crcutil on Redhat10

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Marton Greber, Kudu Jenkins, Abhishek Chennaka, Joe McDonnell, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/24477

to look at the new patch set (#2).

Change subject: [thirdparty] fix arch detection in crcutil on Redhat10
......................................................................

[thirdparty] fix arch detection in crcutil on Redhat10

This changelist updates crcutil in 3rd-party up to the latest version
in the git repo at the time of writing [1].  An update from the prior
version is switching from 'uname -p' to 'uname -m' to provide relevant
information on RedHat10.

[1] https://github.com/cloudera/crcutil/commit/0437b1a99

Change-Id: Ie1d353ee3e7b3d5187cd9107a0f0609dd5cff4d6
---
M thirdparty/patches/crcutil-fix-macos-arm64-flags.patch
M thirdparty/vars.sh
2 files changed, 7 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/24477/2
-- 
To view, visit http://gerrit.cloudera.org:8080/24477
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie1d353ee3e7b3d5187cd9107a0f0609dd5cff4d6
Gerrit-Change-Number: 24477
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>

[kudu-CR] [thirdparty] fix arch detection in crcutil on Redhat10

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/24477 )

Change subject: [thirdparty] fix arch detection in crcutil on Redhat10
......................................................................


Patch Set 2: Code-Review+1

This looks good to me


-- 
To view, visit http://gerrit.cloudera.org:8080/24477
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1d353ee3e7b3d5187cd9107a0f0609dd5cff4d6
Gerrit-Change-Number: 24477
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Wed, 17 Jun 2026 00:13:04 +0000
Gerrit-HasComments: No

[kudu-CR] [thirdparty] fix arch detection in crcutil on Redhat10

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/24477 )

Change subject: [thirdparty] fix arch detection in crcutil on Redhat10
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/24477
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1d353ee3e7b3d5187cd9107a0f0609dd5cff4d6
Gerrit-Change-Number: 24477
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Jun 2026 00:46:14 +0000
Gerrit-HasComments: No

[kudu-CR] [thirdparty] fix arch detection in crcutil on Redhat10

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24477 )

Change subject: [thirdparty] fix arch detection in crcutil on Redhat10
......................................................................


Patch Set 2: Verified+1

Build Successful 

http://jenkins.kudu.apache.org/job/pre_commit/2669/ : SUCCESS


-- 
To view, visit http://gerrit.cloudera.org:8080/24477
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1d353ee3e7b3d5187cd9107a0f0609dd5cff4d6
Gerrit-Change-Number: 24477
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 16 Jun 2026 18:29:18 +0000
Gerrit-HasComments: No