You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@streampipes.apache.org by "tenthe (via GitHub)" <gi...@apache.org> on 2023/12/20 17:14:20 UTC
[PR] Update of PR #2300
tenthe opened a new pull request, #2356:
URL: https://github.com/apache/streampipes/pull/2356
<!--
~ Licensed to the Apache Software Foundation (ASF) under one or more
~ contributor license agreements. See the NOTICE file distributed with
~ this work for additional information regarding copyright ownership.
~ The ASF licenses this file to You under the Apache License, Version 2.0
~ (the "License"); you may not use this file except in compliance with
~ the License. You may obtain a copy of the License at
~
~ http://www.apache.org/licenses/LICENSE-2.0
~
~ Unless required by applicable law or agreed to in writing, software
~ distributed under the License is distributed on an "AS IS" BASIS,
~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
~ See the License for the specific language governing permissions and
~ limitations under the License.
~
-->
<!--
Thanks for contributing! Here are some tips you can follow to help us incorporate your contribution quickly and easily:
1. If this is your first time, please read our contributor guidelines:
- https://streampipes.apache.org/getinvolved.html
- https://cwiki.apache.org/confluence/display/STREAMPIPES/Getting+Started
2. Make sure the PR title is formatted like: `[#<GitHub issue id>] PR title ...`
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., `[WIP][#<GitHub issue id>] PR title ...`.
4. Please write your PR title to summarize what this PR proposes/fixes.
5. Link the PR to the corresponding GitHub issue (if present) in the `Development` section in the right menu bar.
6. Be sure to keep the PR description updated to reflect all changes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
8. Make sure tests pass via `mvn clean install`.
9. (Optional) If the contribution is large, please file an Apache ICLA
- http://apache.org/licenses/icla.pdf
-->
### Purpose
<!--
Please clarify what changes you are proposing and describe how those changes will address the issue.
Furthermore, describe potential consequences the changes might have.
-->
This PR is an update of #2300. I could not push my changes to the other PR.
Therefore I created a new one.
I had to merge the new HTTP API into the branch. @muyangye can you please check if this is correct?
### Remarks
<!--
Is there anything left we need to pay attention on?
Are there some references that might be important? E.g. links to Confluence, or discussions
on the mailing list or GitHub.
-->
PR introduces (a) breaking change(s): no
PR introduces (a) deprecation(s): no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update of PR #2300
Posted by "tenthe (via GitHub)" <gi...@apache.org>.
tenthe merged PR #2356:
URL: https://github.com/apache/streampipes/pull/2356
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update of PR #2300
Posted by "tenthe (via GitHub)" <gi...@apache.org>.
tenthe commented on PR #2356:
URL: https://github.com/apache/streampipes/pull/2356#issuecomment-1868228018
Hey @muyangye,
thanks for trying it out.
What exactly didn't work for you?
I just tried to upload two files with the same name and I was able to change the name of the second file.
My last commit only fixes some linting errors.
The change from JAX-RS to Spring MVC was made to harmonize our code base, see #2276.
If the change causes problems in your development setup just let me know and we can try to solve it together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update of PR #2300
Posted by "muyangye (via GitHub)" <gi...@apache.org>.
muyangye commented on PR #2356:
URL: https://github.com/apache/streampipes/pull/2356#issuecomment-1865381405
@tenthe Thanks a lot for mergingš.
Is there any reason to switch from JAX-RS to Spring MVC? I copied (I can't even do git pullš¤£) the code to local and was not able to compile it because endpoints in `PipelineElementFile.java` expect a return of type `ResponseEntity` which is part of Spring MVC whereas the actual return is of type `Response` which is part of JAX-RS. Other than that I spot no issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update of PR #2300
Posted by "muyangye (via GitHub)" <gi...@apache.org>.
muyangye commented on PR #2356:
URL: https://github.com/apache/streampipes/pull/2356#issuecomment-1868557072
> Hey @muyangye, thanks for trying it out.
>
> What exactly didn't work for you? I just tried to upload two files with the same name and I was able to change the name of the second file. My last commit only fixes some linting errors.
>
> The change from JAX-RS to Spring MVC was made to harmonize our code base, see #2276. If the change causes problems in your development setup just let me know and we can try to solve it together.
@tenthe Thanks for pointing out the harmonization PR. I wasn't able to do git pull or git push so I didn't get the latest change brought by #2276. After manually downloading the dev branch to local I was able to compile and everything works perfectly. Let's merge this PR and I'll continue the work on #2181 once I return to USA since I have network issue with git right now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org