You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2019/11/08 15:39:00 UTC
[jira] [Work logged] (KNOX-2100) knoxshell doesn't setup logging
correctly
[ https://issues.apache.org/jira/browse/KNOX-2100?focusedWorklogId=340553&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-340553 ]
ASF GitHub Bot logged work on KNOX-2100:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Nov/19 15:38
Start Date: 08/Nov/19 15:38
Worklog Time Spent: 10m
Work Description: smolnar82 commented on pull request #181: KNOX-2100 - Make sure knoxshell initializes logging by using the 'launcher' framework like other products (gateway, cli, ldap) do
URL: https://github.com/apache/knox/pull/181
## What changes were proposed in this pull request?
Eliminated 1 of the 2 entry points in the `knoxshell.sh`. Only invoking `org.apache.knox.gateway.shell.Shell` results in the `launcher` framework doing its job (setting launcher.name, log4j configuration, etc..). The removed bash logic has been moved to the Java class.
## How was this patch tested?
Manually tested:
```
$ bin/knoxshell.sh destroy
$ bin/knoxshell.sh list
Knox token cache does not exist. Please login with init.
$ bin/knoxshell.sh init https://localhost:8443/gateway/sandbox
Enter username: admin
Enter password:
knoxinit successful!
Token Type: Bearer
Expires On: 11/09/2019 02:26:20
Target URL: https://localhost:8443/gateway/tokenbased
$ ls -al logs/
total 0
drwxr-xr-x 3 smolnar staff 102 Nov 8 15:49 .
drwxr-xr-x 10 smolnar staff 340 Nov 8 15:49 ..
-rw-r--r-- 1 smolnar staff 0 Nov 8 15:49 knoxshell.log
$ bin/knoxshell.sh
2019-11-08 16:26:52.639 java[77845:5642100] unable to obtain configuration from file://localhost/Library/Preferences/com.apple.ViewBridge.plist due to Error Domain=NSCocoaErrorDomain Code=260 "The file “com.apple.ViewBridge.plist” couldn’t be opened because there is no such file." UserInfo={NSFilePath=/Library/Preferences/com.apple.ViewBridge.plist, NSUnderlyingError=0x7fbe1f60aa30 {Error Domain=NSPOSIXErrorDomain Code=2 "No such file or directory"}}
===> org.apache.knox.gateway.shell.KnoxSession
===> org.apache.knox.gateway.shell.KnoxSession, org.apache.knox.gateway.shell.hbase.HBase
===> org.apache.knox.gateway.shell.KnoxSession, org.apache.knox.gateway.shell.hbase.HBase, org.apache.knox.gateway.shell.hdfs.Hdfs
===> org.apache.knox.gateway.shell.KnoxSession, org.apache.knox.gateway.shell.hbase.HBase, org.apache.knox.gateway.shell.hdfs.Hdfs, org.apache.knox.gateway.shell.job.Job
===> org.apache.knox.gateway.shell.KnoxSession, org.apache.knox.gateway.shell.hbase.HBase, org.apache.knox.gateway.shell.hdfs.Hdfs, org.apache.knox.gateway.shell.job.Job, org.apache.knox.gateway.shell.workflow.Workflow
===> org.apache.knox.gateway.shell.KnoxSession, org.apache.knox.gateway.shell.hbase.HBase, org.apache.knox.gateway.shell.hdfs.Hdfs, org.apache.knox.gateway.shell.job.Job, org.apache.knox.gateway.shell.workflow.Workflow, org.apache.knox.gateway.shell.yarn.Yarn
===> org.apache.knox.gateway.shell.KnoxSession, org.apache.knox.gateway.shell.hbase.HBase, org.apache.knox.gateway.shell.hdfs.Hdfs, org.apache.knox.gateway.shell.job.Job, org.apache.knox.gateway.shell.workflow.Workflow, org.apache.knox.gateway.shell.yarn.Yarn, java.util.concurrent.TimeUnit
===> org.apache.knox.gateway.shell.KnoxSession, org.apache.knox.gateway.shell.hbase.HBase, org.apache.knox.gateway.shell.hdfs.Hdfs, org.apache.knox.gateway.shell.job.Job, org.apache.knox.gateway.shell.workflow.Workflow, org.apache.knox.gateway.shell.yarn.Yarn, java.util.concurrent.TimeUnit, org.apache.knox.gateway.shell.manager.Manager
===> org.apache.knox.gateway.shell.KnoxSession, org.apache.knox.gateway.shell.hbase.HBase, org.apache.knox.gateway.shell.hdfs.Hdfs, org.apache.knox.gateway.shell.job.Job, org.apache.knox.gateway.shell.workflow.Workflow, org.apache.knox.gateway.shell.yarn.Yarn, java.util.concurrent.TimeUnit, org.apache.knox.gateway.shell.manager.Manager, org.apache.knox.gateway.shell.table.KnoxShellTable
Groovy Shell (2.5.8, JVM: 1.8.0_212)
Type ':help' or ':h' for help.
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
knox:000>
knox:000>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 340553)
Remaining Estimate: 0h
Time Spent: 10m
> knoxshell doesn't setup logging correctly
> -----------------------------------------
>
> Key: KNOX-2100
> URL: https://issues.apache.org/jira/browse/KNOX-2100
> Project: Apache Knox
> Issue Type: Bug
> Components: KnoxShell
> Reporter: Kevin Risden
> Assignee: Sandor Molnar
> Priority: Major
> Labels: beginner
> Fix For: 1.4.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> KnoxShell has a log4j properties but doesn't look like packaging is setup correctly to use that since log4j is missing.
> {code:java}
> ./bin/knoxshell.sh init https://knox_host/default/knox-token
> Enter username: guest
> Enter password:
> log4j:WARN No appenders could be found for logger (org.apache.http.client.protocol.RequestAddCookies).
> log4j:WARN Please initialize the log4j system properly.
> log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more info.
> Failure to acquire token. Please verify your credentials and Knox URL and try again.
> {code}
> This looks like a packaging issue potentially.
> {code:java}
> # ls -l
> total 84
> drwxr--r-- 2 root root 91 Nov 6 15:26 bin
> drwxr--r-- 2 root root 40 Nov 6 15:25 conf
> -r--r--r-- 1 root root 73521 Jul 17 02:27 LICENSE
> -r--r--r-- 1 root root 165 Jul 17 02:27 NOTICE
> -rw-r--r-- 1 root root 1452 Jul 17 02:27 README
> drwxr-xr-x 3 root root 4096 Jul 17 02:35 samples
> # ls -l bin/
> total 14568
> -rwxr-xr-x 1 root root 5583 Jul 17 02:35 knox-env.sh
> -rwxr-xr-x 1 root root 6491 Jul 17 02:35 knox-functions.sh
> -rw-r--r-- 1 root root 14893168 Jul 17 02:35 knoxshell.jar
> -rwxr-xr-x 1 root root 3482 Jul 17 02:27 knoxshell.sh
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)