You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/11/12 13:23:15 UTC

[GitHub] [incubator-superset] villebro opened a new pull request #11665: [WIP] feat: add event and interval annotation support to chart data ep

villebro opened a new pull request #11665:
URL: https://github.com/apache/incubator-superset/pull/11665


   ### SUMMARY
   Implements event, interval and line annotations on V1 chart data endpoint and ECharts Timeseries plugin.
   
   ### SCREENSHOT
   ![image](https://user-images.githubusercontent.com/33317356/98945133-c1655680-24fa-11eb-89e2-54be3c6ea567.png)
   
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11665: [WIP] feat: add event and interval annotation support to chart data ep

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11665:
URL: https://github.com/apache/incubator-superset/pull/11665#issuecomment-726081922


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=h1) Report
   > Merging [#11665](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=desc) (d48f5d4) into [master](https://codecov.io/gh/apache/incubator-superset/commit/db7386910e0f4c9acc231dde50ac72d65aa72b0f?el=desc) (db73869) will **decrease** coverage by `6.86%`.
   > The diff coverage is `57.69%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11665/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11665      +/-   ##
   ==========================================
   - Coverage   67.20%   60.33%   -6.87%     
   ==========================================
     Files         903      857      -46     
     Lines       43719    41987    -1732     
     Branches     4199     3726     -473     
   ==========================================
   - Hits        29380    25333    -4047     
   - Misses      14235    16654    +2419     
   + Partials      104        0     -104     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `55.00% <100.00%> (-0.04%)` | :arrow_down: |
   | javascript | `?` | |
   | python | `63.15% <55.10%> (-0.34%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `75.72% <48.78%> (-7.51%)` | :arrow_down: |
   | [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `90.67% <85.71%> (-0.48%)` | :arrow_down: |
   | [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `71.35% <100.00%> (-7.89%)` | :arrow_down: |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `59.40% <100.00%> (ø)` | |
   | [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
   | [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
   | [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
   | ... and [321 more](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=footer). Last update [db73869...d48f5d4](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11665: [WIP] feat: add event and interval annotation support to chart data ep

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11665:
URL: https://github.com/apache/incubator-superset/pull/11665#issuecomment-726081922


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=h1) Report
   > Merging [#11665](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=desc) (4e5d3d8) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2718909314428d573698058b0a9065a4215b30cc?el=desc) (2718909) will **decrease** coverage by `0.48%`.
   > The diff coverage is `57.14%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11665/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11665      +/-   ##
   ==========================================
   - Coverage   62.36%   61.87%   -0.49%     
   ==========================================
     Files         874      423     -451     
     Lines       42336    26369   -15967     
     Branches     3972        0    -3972     
   ==========================================
   - Hits        26402    16316   -10086     
   + Misses      15754    10053    -5701     
   + Partials      180        0     -180     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `?` | |
   | python | `61.87% <57.14%> (-0.20%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `80.48% <51.21%> (-7.47%)` | :arrow_down: |
   | [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `90.67% <85.71%> (-0.48%)` | :arrow_down: |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `59.33% <100.00%> (ø)` | |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.64%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.98% <0.00%> (-0.28%)` | :arrow_down: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.77% <0.00%> (-0.14%)` | :arrow_down: |
   | [...explore/components/controls/ColorSchemeControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xvclNjaGVtZUNvbnRyb2wuanN4) | | |
   | [...ews/CRUD/annotationlayers/AnnotationLayerModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbmxheWVycy9Bbm5vdGF0aW9uTGF5ZXJNb2RhbC50c3g=) | | |
   | ... and [448 more](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=footer). Last update [2718909...4e5d3d8](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] villebro commented on a change in pull request #11665: feat: add event and interval annotation support to chart data ep

Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #11665:
URL: https://github.com/apache/incubator-superset/pull/11665#discussion_r535870640



##########
File path: superset/common/query_context.py
##########
@@ -220,7 +222,80 @@ def cache_key(self, query_obj: QueryObject, **kwargs: Any) -> Optional[str]:
         )
         return cache_key
 
-    def get_df_payload(  # pylint: disable=too-many-statements
+    @staticmethod
+    def get_native_annotation_data(query_obj: QueryObject) -> Dict[str, Any]:
+        annotation_data = {}
+        annotation_layers = [
+            layer
+            for layer in query_obj.annotation_layers
+            if layer["sourceType"] == "NATIVE"
+        ]
+        layer_ids = [layer["value"] for layer in annotation_layers]
+        layer_objects = {
+            layer_object.id: layer_object
+            for layer_object in AnnotationLayerDAO.find_by_ids(layer_ids)
+        }
+
+        # annotations
+        for layer in annotation_layers:
+            layer_id = layer["value"]
+            layer_name = layer["name"]
+            columns = [
+                "start_dttm",
+                "end_dttm",
+                "short_descr",
+                "long_descr",
+                "json_metadata",
+            ]
+            layer_object = layer_objects[layer_id]
+            records = [
+                {column: getattr(annotation, column) for column in columns}
+                for annotation in layer_object.annotation
+            ]
+            result = {"columns": columns, "records": records}
+            annotation_data[layer_name] = result
+        return annotation_data
+
+    @staticmethod
+    def get_viz_annotation_data(
+        annotation_layer: Dict[str, Any], force: bool
+    ) -> Dict[str, Any]:
+        slice_id = annotation_layer["value"]
+        slc = db.session.query(Slice).filter_by(id=slice_id).one_or_none()

Review comment:
       Good point, I always forget about these! 👍 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11665: [WIP] feat: add event and interval annotation support to chart data ep

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11665:
URL: https://github.com/apache/incubator-superset/pull/11665#issuecomment-726081922


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=h1) Report
   > Merging [#11665](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=desc) (4e5d3d8) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2718909314428d573698058b0a9065a4215b30cc?el=desc) (2718909) will **decrease** coverage by `0.32%`.
   > The diff coverage is `57.14%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11665/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11665      +/-   ##
   ==========================================
   - Coverage   62.36%   62.03%   -0.33%     
   ==========================================
     Files         874      423     -451     
     Lines       42336    26369   -15967     
     Branches     3972        0    -3972     
   ==========================================
   - Hits        26402    16359   -10043     
   + Misses      15754    10010    -5744     
   + Partials      180        0     -180     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `?` | |
   | python | `62.03% <57.14%> (-0.03%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `80.48% <51.21%> (-7.47%)` | :arrow_down: |
   | [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `90.67% <85.71%> (-0.48%)` | :arrow_down: |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `59.33% <100.00%> (ø)` | |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.64% <0.00%> (-0.65%)` | :arrow_down: |
   | [...ntend/src/dashboard/components/PublishedStatus.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1B1Ymxpc2hlZFN0YXR1cy5qc3g=) | | |
   | [.../src/explore/components/ControlPanelsContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sUGFuZWxzQ29udGFpbmVyLmpzeA==) | | |
   | [...-frontend/src/explore/components/ControlHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sSGVhZGVyLmpzeA==) | | |
   | [...tend/src/dashboard/util/getFilterFieldNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlckZpZWxkTm9kZXNUcmVlLmpz) | | |
   | [...ws/CRUD/data/savedquery/SavedQueryPreviewModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9zYXZlZHF1ZXJ5L1NhdmVkUXVlcnlQcmV2aWV3TW9kYWwudHN4) | | |
   | [superset-frontend/src/CRUD/Fieldset.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL0NSVUQvRmllbGRzZXQuanN4) | | |
   | ... and [444 more](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=footer). Last update [2718909...4e5d3d8](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11665: feat: add event and interval annotation support to chart data ep

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11665:
URL: https://github.com/apache/incubator-superset/pull/11665#issuecomment-726081922


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=h1) Report
   > Merging [#11665](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=desc) (21053cf) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `13.20%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11665/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #11665       +/-   ##
   ===========================================
   - Coverage   67.59%   54.39%   -13.21%     
   ===========================================
     Files         928      421      -507     
     Lines       45053    14812    -30241     
     Branches     4309     3822      -487     
   ===========================================
   - Hits        30455     8057    -22398     
   + Misses      14495     6755     -7740     
   + Partials      103        0      -103     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `54.39% <100.00%> (-0.52%)` | :arrow_down: |
   | javascript | `?` | |
   | python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `71.50% <100.00%> (-7.85%)` | :arrow_down: |
   | [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
   | [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
   | [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
   | [...ontend/src/dashboard/util/getDashboardFilterKey.ts](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERhc2hib2FyZEZpbHRlcktleS50cw==) | `14.28% <0.00%> (-85.72%)` | :arrow_down: |
   | [...nd/src/views/CRUD/data/query/QueryPreviewModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9xdWVyeS9RdWVyeVByZXZpZXdNb2RhbC50c3g=) | `14.70% <0.00%> (-82.97%)` | :arrow_down: |
   | [...set-frontend/src/views/CRUD/welcome/EmptyState.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9FbXB0eVN0YXRlLnRzeA==) | `5.71% <0.00%> (-82.10%)` | :arrow_down: |
   | ... and [772 more](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=footer). Last update [8c063ef...21053cf](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11665: [WIP] feat: add event and interval annotation support to chart data ep

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11665:
URL: https://github.com/apache/incubator-superset/pull/11665#issuecomment-726081922


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=h1) Report
   > Merging [#11665](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=desc) (d48f5d4) into [master](https://codecov.io/gh/apache/incubator-superset/commit/db7386910e0f4c9acc231dde50ac72d65aa72b0f?el=desc) (db73869) will **decrease** coverage by `4.05%`.
   > The diff coverage is `55.10%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11665/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11665      +/-   ##
   ==========================================
   - Coverage   67.20%   63.14%   -4.06%     
   ==========================================
     Files         903      446     -457     
     Lines       43719    27464   -16255     
     Branches     4199        0    -4199     
   ==========================================
   - Hits        29380    17342   -12038     
   + Misses      14235    10122    -4113     
   + Partials      104        0     -104     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `63.14% <55.10%> (-0.35%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `75.72% <48.78%> (-7.51%)` | :arrow_down: |
   | [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `90.67% <85.71%> (-0.48%)` | :arrow_down: |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `59.40% <100.00%> (ø)` | |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
   | [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
   | [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
   | [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.86% <0.00%> (-2.99%)` | :arrow_down: |
   | [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `88.72% <0.00%> (-2.95%)` | :arrow_down: |
   | ... and [465 more](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=footer). Last update [db73869...d48f5d4](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11665: [WIP] feat: add event and interval annotation support to chart data ep

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11665:
URL: https://github.com/apache/incubator-superset/pull/11665#issuecomment-726081922


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=h1) Report
   > Merging [#11665](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=desc) (4e5d3d8) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2718909314428d573698058b0a9065a4215b30cc?el=desc) (2718909) will **decrease** coverage by `0.95%`.
   > The diff coverage is `57.14%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11665/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11665      +/-   ##
   ==========================================
   - Coverage   62.36%   61.40%   -0.96%     
   ==========================================
     Files         874      423     -451     
     Lines       42336    26369   -15967     
     Branches     3972        0    -3972     
   ==========================================
   - Hits        26402    16193   -10209     
   + Misses      15754    10176    -5578     
   + Partials      180        0     -180     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `?` | |
   | python | `61.40% <57.14%> (-0.66%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `80.48% <51.21%> (-7.47%)` | :arrow_down: |
   | [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `90.67% <85.71%> (-0.48%)` | :arrow_down: |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `59.33% <100.00%> (ø)` | |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.53%)` | :arrow_down: |
   | [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `76.00% <0.00%> (-4.00%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
   | ... and [452 more](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=footer). Last update [2718909...4e5d3d8](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11665: [WIP] feat: add event and interval annotation support to chart data ep

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11665:
URL: https://github.com/apache/incubator-superset/pull/11665#issuecomment-726081922


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=h1) Report
   > Merging [#11665](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=desc) (c6168bb) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `3.97%`.
   > The diff coverage is `75.86%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11665/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11665      +/-   ##
   ==========================================
   - Coverage   67.59%   63.62%   -3.98%     
   ==========================================
     Files         928      928              
     Lines       45053    45097      +44     
     Branches     4309     4311       +2     
   ==========================================
   - Hits        30455    28694    -1761     
   - Misses      14495    16226    +1731     
   - Partials      103      177      +74     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `63.18% <100.00%> (+<0.01%)` | :arrow_up: |
   | python | `63.88% <74.54%> (-0.19%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <ø> (ø)` | |
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `79.61% <65.85%> (-3.63%)` | :arrow_down: |
   | [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `51.07% <100.00%> (-28.28%)` | :arrow_down: |
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.60% <100.00%> (+0.06%)` | :arrow_up: |
   | [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `91.52% <100.00%> (+0.37%)` | :arrow_up: |
   | [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.81% <100.00%> (+0.07%)` | :arrow_up: |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `59.43% <100.00%> (ø)` | |
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [180 more](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=footer). Last update [8c063ef...c6168bb](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11665: [WIP] feat: add event and interval annotation support to chart data ep

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11665:
URL: https://github.com/apache/incubator-superset/pull/11665#issuecomment-726081922


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=h1) Report
   > Merging [#11665](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=desc) (c6168bb) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `3.96%`.
   > The diff coverage is `75.86%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11665/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11665      +/-   ##
   ==========================================
   - Coverage   67.59%   63.63%   -3.97%     
   ==========================================
     Files         928      928              
     Lines       45053    45082      +29     
     Branches     4309     4311       +2     
   ==========================================
   - Hits        30455    28687    -1768     
   - Misses      14495    16218    +1723     
   - Partials      103      177      +74     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `63.18% <100.00%> (+<0.01%)` | :arrow_up: |
   | python | `63.89% <74.54%> (-0.19%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <ø> (ø)` | |
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `79.61% <65.85%> (-3.63%)` | :arrow_down: |
   | [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `51.07% <100.00%> (-28.28%)` | :arrow_down: |
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.60% <100.00%> (+0.06%)` | :arrow_up: |
   | [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `91.52% <100.00%> (+0.37%)` | :arrow_up: |
   | [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.81% <100.00%> (+0.07%)` | :arrow_up: |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `59.43% <100.00%> (ø)` | |
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [187 more](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=footer). Last update [8c063ef...c6168bb](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11665: [WIP] feat: add event and interval annotation support to chart data ep

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11665:
URL: https://github.com/apache/incubator-superset/pull/11665#issuecomment-726081922


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=h1) Report
   > Merging [#11665](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=desc) (c6168bb) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `4.41%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11665/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11665      +/-   ##
   ==========================================
   - Coverage   67.59%   63.18%   -4.42%     
   ==========================================
     Files         928      466     -462     
     Lines       45053    16629   -28424     
     Branches     4309     4311       +2     
   ==========================================
   - Hits        30455    10507   -19948     
   + Misses      14495     5945    -8550     
   - Partials      103      177      +74     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `63.18% <100.00%> (+<0.01%)` | :arrow_up: |
   | python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `51.07% <100.00%> (-28.28%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...et-frontend/src/dashboard/containers/Dashboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [623 more](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=footer). Last update [8c063ef...c6168bb](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11665: [WIP] feat: add event and interval annotation support to chart data ep

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11665:
URL: https://github.com/apache/incubator-superset/pull/11665#issuecomment-726081922


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=h1) Report
   > Merging [#11665](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=desc) (d48f5d4) into [master](https://codecov.io/gh/apache/incubator-superset/commit/db7386910e0f4c9acc231dde50ac72d65aa72b0f?el=desc) (db73869) will **decrease** coverage by `4.04%`.
   > The diff coverage is `55.10%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11665/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11665      +/-   ##
   ==========================================
   - Coverage   67.20%   63.15%   -4.05%     
   ==========================================
     Files         903      446     -457     
     Lines       43719    27464   -16255     
     Branches     4199        0    -4199     
   ==========================================
   - Hits        29380    17345   -12035     
   + Misses      14235    10119    -4116     
   + Partials      104        0     -104     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `63.15% <55.10%> (-0.34%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `75.72% <48.78%> (-7.51%)` | :arrow_down: |
   | [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `90.67% <85.71%> (-0.48%)` | :arrow_down: |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `59.40% <100.00%> (ø)` | |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
   | [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
   | [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
   | [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.86% <0.00%> (-2.99%)` | :arrow_down: |
   | [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `88.72% <0.00%> (-2.95%)` | :arrow_down: |
   | ... and [464 more](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=footer). Last update [db73869...d48f5d4](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11665: feat: add event and interval annotation support to chart data ep

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11665:
URL: https://github.com/apache/incubator-superset/pull/11665#issuecomment-726081922


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=h1) Report
   > Merging [#11665](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=desc) (70114ce) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `3.52%`.
   > The diff coverage is `75.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11665/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11665      +/-   ##
   ==========================================
   - Coverage   67.59%   64.07%   -3.53%     
   ==========================================
     Files         928      462     -466     
     Lines       45053    28468   -16585     
     Branches     4309        0    -4309     
   ==========================================
   - Hits        30455    18240   -12215     
   + Misses      14495    10228    -4267     
   + Partials      103        0     -103     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `64.07% <75.00%> (-0.01%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <ø> (ø)` | |
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `79.61% <66.66%> (-3.63%)` | :arrow_down: |
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.60% <100.00%> (+0.06%)` | :arrow_up: |
   | [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `91.52% <100.00%> (+0.37%)` | :arrow_up: |
   | [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.81% <100.00%> (+0.07%)` | :arrow_up: |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `59.43% <100.00%> (ø)` | |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
   | [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
   | [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.49% <0.00%> (-0.27%)` | :arrow_down: |
   | ... and [466 more](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=footer). Last update [8c063ef...70114ce](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11665: feat: add event and interval annotation support to chart data ep

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11665:
URL: https://github.com/apache/incubator-superset/pull/11665#issuecomment-726081922


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=h1) Report
   > Merging [#11665](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=desc) (21053cf) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `12.61%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11665/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #11665       +/-   ##
   ===========================================
   - Coverage   67.59%   54.98%   -12.62%     
   ===========================================
     Files         928      421      -507     
     Lines       45053    14812    -30241     
     Branches     4309     3822      -487     
   ===========================================
   - Hits        30455     8144    -22311     
   + Misses      14495     6668     -7827     
   + Partials      103        0      -103     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `54.98% <100.00%> (+0.07%)` | :arrow_up: |
   | javascript | `?` | |
   | python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `71.50% <100.00%> (-7.85%)` | :arrow_down: |
   | [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
   | [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
   | [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
   | [...ontend/src/dashboard/util/getDashboardFilterKey.ts](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERhc2hib2FyZEZpbHRlcktleS50cw==) | `14.28% <0.00%> (-85.72%)` | :arrow_down: |
   | [...nd/src/views/CRUD/data/query/QueryPreviewModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9xdWVyeS9RdWVyeVByZXZpZXdNb2RhbC50c3g=) | `14.70% <0.00%> (-82.97%)` | :arrow_down: |
   | [...set-frontend/src/views/CRUD/welcome/EmptyState.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9FbXB0eVN0YXRlLnRzeA==) | `5.71% <0.00%> (-82.10%)` | :arrow_down: |
   | ... and [771 more](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=footer). Last update [8c063ef...21053cf](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11665: feat: add event and interval annotation support to chart data ep

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11665:
URL: https://github.com/apache/incubator-superset/pull/11665#issuecomment-726081922


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=h1) Report
   > Merging [#11665](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=desc) (70114ce) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `3.85%`.
   > The diff coverage is `76.27%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11665/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11665      +/-   ##
   ==========================================
   - Coverage   67.59%   63.74%   -3.86%     
   ==========================================
     Files         928      928              
     Lines       45053    45097      +44     
     Branches     4309     4311       +2     
   ==========================================
   - Hits        30455    28747    -1708     
   - Misses      14495    16173    +1678     
   - Partials      103      177      +74     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `63.18% <100.00%> (+<0.01%)` | :arrow_up: |
   | python | `64.07% <75.00%> (-0.01%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <ø> (ø)` | |
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `79.61% <66.66%> (-3.63%)` | :arrow_down: |
   | [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `51.07% <100.00%> (-28.28%)` | :arrow_down: |
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.60% <100.00%> (+0.06%)` | :arrow_up: |
   | [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `91.52% <100.00%> (+0.37%)` | :arrow_up: |
   | [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.81% <100.00%> (+0.07%)` | :arrow_up: |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `59.43% <100.00%> (ø)` | |
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [178 more](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=footer). Last update [8c063ef...70114ce](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io commented on pull request #11665: [WIP] feat: add event and interval annotation support to chart data ep

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #11665:
URL: https://github.com/apache/incubator-superset/pull/11665#issuecomment-726081922


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=h1) Report
   > Merging [#11665](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=desc) (4e5d3d8) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2718909314428d573698058b0a9065a4215b30cc?el=desc) (2718909) will **decrease** coverage by `1.04%`.
   > The diff coverage is `57.14%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11665/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11665      +/-   ##
   ==========================================
   - Coverage   62.36%   61.32%   -1.05%     
   ==========================================
     Files         874      423     -451     
     Lines       42336    26358   -15978     
     Branches     3972        0    -3972     
   ==========================================
   - Hits        26402    16163   -10239     
   + Misses      15754    10195    -5559     
   + Partials      180        0     -180     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `?` | |
   | python | `61.32% <57.14%> (-0.75%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `80.48% <51.21%> (-7.47%)` | :arrow_down: |
   | [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `90.67% <85.71%> (-0.48%)` | :arrow_down: |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `59.33% <100.00%> (ø)` | |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.53%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
   | [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `76.00% <0.00%> (-4.00%)` | :arrow_down: |
   | [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
   | ... and [462 more](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=footer). Last update [2718909...4e5d3d8](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #11665: feat: add event and interval annotation support to chart data ep

Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #11665:
URL: https://github.com/apache/incubator-superset/pull/11665#discussion_r535504766



##########
File path: tests/charts/api_tests.py
##########
@@ -1383,3 +1386,44 @@ def test_import_chart_invalid(self):
         assert response == {
             "message": {"metadata.yaml": {"type": ["Must be equal to Slice."]}}
         }
+
+    @pytest.mark.usefixtures("create_annotation_layers")

Review comment:
       We should think about moving all these tests away from `unittest.TestCase` if possible, there are some really cool pytest features that we are missing out

##########
File path: superset/common/query_context.py
##########
@@ -220,7 +222,80 @@ def cache_key(self, query_obj: QueryObject, **kwargs: Any) -> Optional[str]:
         )
         return cache_key
 
-    def get_df_payload(  # pylint: disable=too-many-statements
+    @staticmethod
+    def get_native_annotation_data(query_obj: QueryObject) -> Dict[str, Any]:
+        annotation_data = {}
+        annotation_layers = [
+            layer
+            for layer in query_obj.annotation_layers
+            if layer["sourceType"] == "NATIVE"
+        ]
+        layer_ids = [layer["value"] for layer in annotation_layers]
+        layer_objects = {
+            layer_object.id: layer_object
+            for layer_object in AnnotationLayerDAO.find_by_ids(layer_ids)
+        }
+
+        # annotations
+        for layer in annotation_layers:
+            layer_id = layer["value"]
+            layer_name = layer["name"]
+            columns = [
+                "start_dttm",
+                "end_dttm",
+                "short_descr",
+                "long_descr",
+                "json_metadata",
+            ]
+            layer_object = layer_objects[layer_id]
+            records = [
+                {column: getattr(annotation, column) for column in columns}
+                for annotation in layer_object.annotation
+            ]
+            result = {"columns": columns, "records": records}
+            annotation_data[layer_name] = result
+        return annotation_data
+
+    @staticmethod
+    def get_viz_annotation_data(
+        annotation_layer: Dict[str, Any], force: bool
+    ) -> Dict[str, Any]:
+        slice_id = annotation_layer["value"]
+        slc = db.session.query(Slice).filter_by(id=slice_id).one_or_none()

Review comment:
       nit: could make sense to use `ChartDao.find_by_id` instead, note DAO's are starting to support being called from celery workers and the Security chart filter is always applied there

##########
File path: superset/charts/api.py
##########
@@ -485,6 +485,7 @@ def data(self) -> Response:
         """
         if request.is_json:
             json_body = request.json
+            print(json_body)

Review comment:
       remove?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] villebro commented on a change in pull request #11665: feat: add event and interval annotation support to chart data ep

Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #11665:
URL: https://github.com/apache/incubator-superset/pull/11665#discussion_r535870193



##########
File path: superset/charts/api.py
##########
@@ -485,6 +485,7 @@ def data(self) -> Response:
         """
         if request.is_json:
             json_body = request.json
+            print(json_body)

Review comment:
       🤦  done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11665: [WIP] feat: add event and interval annotation support to chart data ep

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11665:
URL: https://github.com/apache/incubator-superset/pull/11665#issuecomment-726081922


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=h1) Report
   > Merging [#11665](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=desc) (4e5d3d8) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2718909314428d573698058b0a9065a4215b30cc?el=desc) (2718909) will **decrease** coverage by `0.48%`.
   > The diff coverage is `57.14%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11665/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11665      +/-   ##
   ==========================================
   - Coverage   62.36%   61.87%   -0.49%     
   ==========================================
     Files         874      423     -451     
     Lines       42336    26369   -15967     
     Branches     3972        0    -3972     
   ==========================================
   - Hits        26402    16316   -10086     
   + Misses      15754    10053    -5701     
   + Partials      180        0     -180     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `?` | |
   | python | `61.87% <57.14%> (-0.20%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `80.48% <51.21%> (-7.47%)` | :arrow_down: |
   | [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `90.67% <85.71%> (-0.48%)` | :arrow_down: |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `59.33% <100.00%> (ø)` | |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.64%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.98% <0.00%> (-0.28%)` | :arrow_down: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.77% <0.00%> (-0.14%)` | :arrow_down: |
   | [superset-frontend/src/components/ListView/utils.ts](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvdXRpbHMudHM=) | | |
   | [...frontend/src/components/BootstrapSliderWrapper.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQm9vdHN0cmFwU2xpZGVyV3JhcHBlci5qc3g=) | | |
   | ... and [448 more](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=footer). Last update [2718909...4e5d3d8](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11665: feat: add event and interval annotation support to chart data ep

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11665:
URL: https://github.com/apache/incubator-superset/pull/11665#issuecomment-726081922


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=h1) Report
   > Merging [#11665](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=desc) (70114ce) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `3.68%`.
   > The diff coverage is `75.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11665/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11665      +/-   ##
   ==========================================
   - Coverage   67.59%   63.91%   -3.69%     
   ==========================================
     Files         928      462     -466     
     Lines       45053    28468   -16585     
     Branches     4309        0    -4309     
   ==========================================
   - Hits        30455    18194   -12261     
   + Misses      14495    10274    -4221     
   + Partials      103        0     -103     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `63.91% <75.00%> (-0.17%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <ø> (ø)` | |
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `79.61% <66.66%> (-3.63%)` | :arrow_down: |
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.60% <100.00%> (+0.06%)` | :arrow_up: |
   | [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `91.52% <100.00%> (+0.37%)` | :arrow_up: |
   | [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.81% <100.00%> (+0.07%)` | :arrow_up: |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `59.43% <100.00%> (ø)` | |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.00%)` | :arrow_down: |
   | [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | ... and [469 more](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=footer). Last update [8c063ef...70114ce](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] villebro merged pull request #11665: feat: add event and interval annotation support to chart data ep

Posted by GitBox <gi...@apache.org>.
villebro merged pull request #11665:
URL: https://github.com/apache/incubator-superset/pull/11665


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11665: [WIP] feat: add event and interval annotation support to chart data ep

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11665:
URL: https://github.com/apache/incubator-superset/pull/11665#issuecomment-726081922


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=h1) Report
   > Merging [#11665](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=desc) (c6168bb) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `4.26%`.
   > The diff coverage is `75.86%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11665/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11665      +/-   ##
   ==========================================
   - Coverage   67.59%   63.33%   -4.27%     
   ==========================================
     Files         928      928              
     Lines       45053    45082      +29     
     Branches     4309     4311       +2     
   ==========================================
   - Hits        30455    28553    -1902     
   - Misses      14495    16352    +1857     
   - Partials      103      177      +74     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `63.18% <100.00%> (+<0.01%)` | :arrow_up: |
   | python | `63.42% <74.54%> (-0.66%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <ø> (ø)` | |
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `79.61% <65.85%> (-3.63%)` | :arrow_down: |
   | [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `51.07% <100.00%> (-28.28%)` | :arrow_down: |
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.60% <100.00%> (+0.06%)` | :arrow_up: |
   | [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `91.52% <100.00%> (+0.37%)` | :arrow_up: |
   | [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.81% <100.00%> (+0.07%)` | :arrow_up: |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `59.43% <100.00%> (ø)` | |
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [194 more](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=footer). Last update [8c063ef...c6168bb](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] villebro commented on pull request #11665: feat: add event and interval annotation support to chart data ep

Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #11665:
URL: https://github.com/apache/incubator-superset/pull/11665#issuecomment-738213080


   @john-bodley this is now ready for review if you have time, sorry for the delay


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] villebro commented on a change in pull request #11665: feat: add event and interval annotation support to chart data ep

Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #11665:
URL: https://github.com/apache/incubator-superset/pull/11665#discussion_r535882939



##########
File path: tests/annotation_layers/fixtures.py
##########
@@ -0,0 +1,101 @@
+# Licensed to the Apache Software Foundation (ASF) under one

Review comment:
       Thanks, I wasn't aware of this feature! I looked into the effort required for properly implementing this, and I believe it makes sense to do that in a separate follow-up PR, as I think I'll end up shuffling around quite a few files.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11665: [WIP] feat: add event and interval annotation support to chart data ep

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11665:
URL: https://github.com/apache/incubator-superset/pull/11665#issuecomment-726081922


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=h1) Report
   > Merging [#11665](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=desc) (c6168bb) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `4.23%`.
   > The diff coverage is `75.86%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11665/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11665      +/-   ##
   ==========================================
   - Coverage   67.59%   63.36%   -4.24%     
   ==========================================
     Files         928      928              
     Lines       45053    45082      +29     
     Branches     4309     4311       +2     
   ==========================================
   - Hits        30455    28564    -1891     
   - Misses      14495    16341    +1846     
   - Partials      103      177      +74     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `63.18% <100.00%> (+<0.01%)` | :arrow_up: |
   | python | `63.46% <74.54%> (-0.62%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <ø> (ø)` | |
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `79.61% <65.85%> (-3.63%)` | :arrow_down: |
   | [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `51.07% <100.00%> (-28.28%)` | :arrow_down: |
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.60% <100.00%> (+0.06%)` | :arrow_up: |
   | [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `91.52% <100.00%> (+0.37%)` | :arrow_up: |
   | [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.81% <100.00%> (+0.07%)` | :arrow_up: |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `59.43% <100.00%> (ø)` | |
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [190 more](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=footer). Last update [8c063ef...c6168bb](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11665: feat: add event and interval annotation support to chart data ep

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11665:
URL: https://github.com/apache/incubator-superset/pull/11665#issuecomment-726081922


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=h1) Report
   > Merging [#11665](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=desc) (70114ce) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `3.52%`.
   > The diff coverage is `75.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11665/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11665      +/-   ##
   ==========================================
   - Coverage   67.59%   64.07%   -3.53%     
   ==========================================
     Files         928      462     -466     
     Lines       45053    28468   -16585     
     Branches     4309        0    -4309     
   ==========================================
   - Hits        30455    18240   -12215     
   + Misses      14495    10228    -4267     
   + Partials      103        0     -103     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `64.07% <75.00%> (-0.01%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <ø> (ø)` | |
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `79.61% <66.66%> (-3.63%)` | :arrow_down: |
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.60% <100.00%> (+0.06%)` | :arrow_up: |
   | [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `91.52% <100.00%> (+0.37%)` | :arrow_up: |
   | [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.81% <100.00%> (+0.07%)` | :arrow_up: |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `59.43% <100.00%> (ø)` | |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
   | [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
   | [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.49% <0.00%> (-0.27%)` | :arrow_down: |
   | ... and [466 more](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=footer). Last update [8c063ef...70114ce](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11665: feat: add event and interval annotation support to chart data ep

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11665:
URL: https://github.com/apache/incubator-superset/pull/11665#issuecomment-726081922


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=h1) Report
   > Merging [#11665](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=desc) (70114ce) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `3.83%`.
   > The diff coverage is `76.27%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11665/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11665      +/-   ##
   ==========================================
   - Coverage   67.59%   63.76%   -3.84%     
   ==========================================
     Files         928      928              
     Lines       45053    45097      +44     
     Branches     4309     4311       +2     
   ==========================================
   - Hits        30455    28755    -1700     
   - Misses      14495    16165    +1670     
   - Partials      103      177      +74     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `63.18% <100.00%> (+<0.01%)` | :arrow_up: |
   | python | `64.10% <75.00%> (+0.02%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <ø> (ø)` | |
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `79.61% <66.66%> (-3.63%)` | :arrow_down: |
   | [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `51.07% <100.00%> (-28.28%)` | :arrow_down: |
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.60% <100.00%> (+0.06%)` | :arrow_up: |
   | [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `91.52% <100.00%> (+0.37%)` | :arrow_up: |
   | [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.81% <100.00%> (+0.07%)` | :arrow_up: |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `59.43% <100.00%> (ø)` | |
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [174 more](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=footer). Last update [8c063ef...70114ce](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11665: feat: add event and interval annotation support to chart data ep

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11665:
URL: https://github.com/apache/incubator-superset/pull/11665#issuecomment-726081922


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=h1) Report
   > Merging [#11665](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=desc) (c6168bb) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `3.97%`.
   > The diff coverage is `75.86%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11665/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11665      +/-   ##
   ==========================================
   - Coverage   67.59%   63.62%   -3.98%     
   ==========================================
     Files         928      928              
     Lines       45053    45097      +44     
     Branches     4309     4311       +2     
   ==========================================
   - Hits        30455    28694    -1761     
   - Misses      14495    16226    +1731     
   - Partials      103      177      +74     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `63.18% <100.00%> (+<0.01%)` | :arrow_up: |
   | python | `63.88% <74.54%> (-0.19%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <ø> (ø)` | |
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `79.61% <65.85%> (-3.63%)` | :arrow_down: |
   | [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `51.07% <100.00%> (-28.28%)` | :arrow_down: |
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.60% <100.00%> (+0.06%)` | :arrow_up: |
   | [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `91.52% <100.00%> (+0.37%)` | :arrow_up: |
   | [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.81% <100.00%> (+0.07%)` | :arrow_up: |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `59.43% <100.00%> (ø)` | |
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [180 more](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=footer). Last update [8c063ef...c6168bb](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] villebro commented on pull request #11665: [WIP] feat: add event and interval annotation support to chart data ep

Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #11665:
URL: https://github.com/apache/incubator-superset/pull/11665#issuecomment-726243206


   @john-bodley sure thing, I'll add some tests, will ping you shortly once it's done.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] john-bodley commented on pull request #11665: [WIP] feat: add event and interval annotation support to chart data ep

Posted by GitBox <gi...@apache.org>.
john-bodley commented on pull request #11665:
URL: https://github.com/apache/incubator-superset/pull/11665#issuecomment-726239898


   @junlincc this still looks like WIP. @villebro could you ping this thread when the PR is ready for review?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11665: feat: add event and interval annotation support to chart data ep

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11665:
URL: https://github.com/apache/incubator-superset/pull/11665#issuecomment-726081922


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=h1) Report
   > Merging [#11665](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=desc) (70114ce) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8c063efa759f2e30504009897348c3892e6e39c9?el=desc) (8c063ef) will **decrease** coverage by `4.13%`.
   > The diff coverage is `75.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11665/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11665      +/-   ##
   ==========================================
   - Coverage   67.59%   63.45%   -4.14%     
   ==========================================
     Files         928      462     -466     
     Lines       45053    28453   -16600     
     Branches     4309        0    -4309     
   ==========================================
   - Hits        30455    18056   -12399     
   + Misses      14495    10397    -4098     
   + Partials      103        0     -103     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `63.45% <75.00%> (-0.62%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <ø> (ø)` | |
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `79.61% <66.66%> (-3.63%)` | :arrow_down: |
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.60% <100.00%> (+0.06%)` | :arrow_up: |
   | [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `91.52% <100.00%> (+0.37%)` | :arrow_up: |
   | [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.81% <100.00%> (+0.07%)` | :arrow_up: |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `59.43% <100.00%> (ø)` | |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.08% <0.00%> (-29.97%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-11.88%)` | :arrow_down: |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
   | ... and [482 more](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=footer). Last update [8c063ef...70114ce](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11665: [WIP] feat: add event and interval annotation support to chart data ep

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11665:
URL: https://github.com/apache/incubator-superset/pull/11665#issuecomment-726081922


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=h1) Report
   > Merging [#11665](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=desc) (4e5d3d8) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2718909314428d573698058b0a9065a4215b30cc?el=desc) (2718909) will **decrease** coverage by `1.00%`.
   > The diff coverage is `57.14%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11665/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11665      +/-   ##
   ==========================================
   - Coverage   62.36%   61.36%   -1.01%     
   ==========================================
     Files         874      423     -451     
     Lines       42336    26358   -15978     
     Branches     3972        0    -3972     
   ==========================================
   - Hits        26402    16174   -10228     
   + Misses      15754    10184    -5570     
   + Partials      180        0     -180     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `?` | |
   | python | `61.36% <57.14%> (-0.71%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `80.48% <51.21%> (-7.47%)` | :arrow_down: |
   | [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `90.67% <85.71%> (-0.48%)` | :arrow_down: |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `59.33% <100.00%> (ø)` | |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.53%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
   | [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `76.00% <0.00%> (-4.00%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
   | ... and [458 more](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=footer). Last update [2718909...4e5d3d8](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] villebro commented on a change in pull request #11665: feat: add event and interval annotation support to chart data ep

Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #11665:
URL: https://github.com/apache/incubator-superset/pull/11665#discussion_r535488737



##########
File path: tests/annotation_layers/api_tests.py
##########
@@ -29,77 +27,17 @@
 from superset.models.annotations import Annotation, AnnotationLayer
 
 from tests.base_tests import SupersetTestCase
-
+from tests.annotation_layers.fixtures import (
+    create_annotation_layers,
+    get_end_dttm,
+    get_start_dttm,
+)
 
 ANNOTATION_LAYERS_COUNT = 10
 ANNOTATIONS_COUNT = 5
 
 
 class TestAnnotationLayerApi(SupersetTestCase):
-    def insert_annotation_layer(
-        self, name: str = "", descr: str = ""
-    ) -> AnnotationLayer:
-        annotation_layer = AnnotationLayer(name=name, descr=descr,)
-        db.session.add(annotation_layer)
-        db.session.commit()
-        return annotation_layer
-
-    def insert_annotation(
-        self,
-        layer: AnnotationLayer,
-        short_descr: str,
-        long_descr: str,
-        json_metadata: Optional[str] = "",
-        start_dttm: Optional[datetime] = None,
-        end_dttm: Optional[datetime] = None,
-    ) -> Annotation:
-        annotation = Annotation(
-            layer=layer,
-            short_descr=short_descr,
-            long_descr=long_descr,
-            json_metadata=json_metadata,
-            start_dttm=start_dttm,
-            end_dttm=end_dttm,
-        )
-        db.session.add(annotation)
-        db.session.commit()
-        return annotation
-
-    @pytest.fixture()
-    def create_annotation_layers(self):
-        """
-        Creates ANNOTATION_LAYERS_COUNT-1 layers with no annotations
-        and a final one with ANNOTATION_COUNT childs
-        :return:
-        """
-        with self.create_app().app_context():
-            annotation_layers = []
-            annotations = []
-            for cx in range(ANNOTATION_LAYERS_COUNT - 1):
-                annotation_layers.append(
-                    self.insert_annotation_layer(name=f"name{cx}", descr=f"descr{cx}")
-                )
-            layer_with_annotations = self.insert_annotation_layer(
-                "layer_with_annotations"
-            )
-            annotation_layers.append(layer_with_annotations)
-            for cx in range(ANNOTATIONS_COUNT):
-                annotations.append(
-                    self.insert_annotation(
-                        layer_with_annotations,
-                        short_descr=f"short_descr{cx}",
-                        long_descr=f"long_descr{cx}",
-                    )
-                )
-            yield annotation_layers
-
-            # rollback changes
-            for annotation_layer in annotation_layers:
-                db.session.delete(annotation_layer)
-            for annotation in annotations:
-                db.session.delete(annotation)
-            db.session.commit()
-

Review comment:
       These fixtures were moved to a separate `fixtures.py` file to make them more reusable in different contexts (in this case for testing the chart data endpoint)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11665: [WIP] feat: add event and interval annotation support to chart data ep

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11665:
URL: https://github.com/apache/incubator-superset/pull/11665#issuecomment-726081922


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=h1) Report
   > Merging [#11665](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=desc) (d48f5d4) into [master](https://codecov.io/gh/apache/incubator-superset/commit/db7386910e0f4c9acc231dde50ac72d65aa72b0f?el=desc) (db73869) will **decrease** coverage by `4.53%`.
   > The diff coverage is `55.10%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11665/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11665      +/-   ##
   ==========================================
   - Coverage   67.20%   62.67%   -4.54%     
   ==========================================
     Files         903      446     -457     
     Lines       43719    27464   -16255     
     Branches     4199        0    -4199     
   ==========================================
   - Hits        29380    17212   -12168     
   + Misses      14235    10252    -3983     
   + Partials      104        0     -104     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `62.67% <55.10%> (-0.82%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `75.72% <48.78%> (-7.51%)` | :arrow_down: |
   | [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `90.67% <85.71%> (-0.48%)` | :arrow_down: |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `59.40% <100.00%> (ø)` | |
   | [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.30% <0.00%> (-25.14%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.64%)` | :arrow_down: |
   | [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
   | [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
   | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `80.53% <0.00%> (-6.94%)` | :arrow_down: |
   | ... and [470 more](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=footer). Last update [db73869...d48f5d4](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] bkyryliuk commented on a change in pull request #11665: feat: add event and interval annotation support to chart data ep

Posted by GitBox <gi...@apache.org>.
bkyryliuk commented on a change in pull request #11665:
URL: https://github.com/apache/incubator-superset/pull/11665#discussion_r535616888



##########
File path: tests/annotation_layers/fixtures.py
##########
@@ -0,0 +1,101 @@
+# Licensed to the Apache Software Foundation (ASF) under one

Review comment:
       this looks great, more common way to make fixtures available is to use conftest:
   https://www.tutorialspoint.com/pytest/pytest_conftest_py.htm
   
   tests/annotation_layers/conftest.py - will make them automatically available to all files in the modules and submodules

##########
File path: tests/charts/api_tests.py
##########
@@ -1383,3 +1386,44 @@ def test_import_chart_invalid(self):
         assert response == {
             "message": {"metadata.yaml": {"type": ["Must be equal to Slice."]}}
         }
+
+    @pytest.mark.usefixtures("create_annotation_layers")

Review comment:
       +1, some functions like login, get_table_by_name should be already available as direct ( not object ) methods




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11665: [WIP] feat: add event and interval annotation support to chart data ep

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11665:
URL: https://github.com/apache/incubator-superset/pull/11665#issuecomment-726081922


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=h1) Report
   > Merging [#11665](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=desc) (d48f5d4) into [master](https://codecov.io/gh/apache/incubator-superset/commit/db7386910e0f4c9acc231dde50ac72d65aa72b0f?el=desc) (db73869) will **decrease** coverage by `4.51%`.
   > The diff coverage is `55.10%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11665/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11665      +/-   ##
   ==========================================
   - Coverage   67.20%   62.68%   -4.52%     
   ==========================================
     Files         903      446     -457     
     Lines       43719    27453   -16266     
     Branches     4199        0    -4199     
   ==========================================
   - Hits        29380    17209   -12171     
   + Misses      14235    10244    -3991     
   + Partials      104        0     -104     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `62.68% <55.10%> (-0.81%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `75.72% <48.78%> (-7.51%)` | :arrow_down: |
   | [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `90.67% <85.71%> (-0.48%)` | :arrow_down: |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `59.40% <100.00%> (ø)` | |
   | [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.30% <0.00%> (-25.14%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.64%)` | :arrow_down: |
   | [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
   | [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
   | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `80.53% <0.00%> (-6.94%)` | :arrow_down: |
   | ... and [474 more](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=footer). Last update [db73869...d48f5d4](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11665: [WIP] feat: add event and interval annotation support to chart data ep

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11665:
URL: https://github.com/apache/incubator-superset/pull/11665#issuecomment-726081922


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=h1) Report
   > Merging [#11665](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=desc) (d48f5d4) into [master](https://codecov.io/gh/apache/incubator-superset/commit/db7386910e0f4c9acc231dde50ac72d65aa72b0f?el=desc) (db73869) will **decrease** coverage by `7.07%`.
   > The diff coverage is `57.69%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11665/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11665      +/-   ##
   ==========================================
   - Coverage   67.20%   60.12%   -7.08%     
   ==========================================
     Files         903      857      -46     
     Lines       43719    41987    -1732     
     Branches     4199     3726     -473     
   ==========================================
   - Hits        29380    25246    -4134     
   - Misses      14235    16741    +2506     
   + Partials      104        0     -104     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `54.40% <100.00%> (-0.64%)` | :arrow_down: |
   | javascript | `?` | |
   | python | `63.15% <55.10%> (-0.34%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `75.72% <48.78%> (-7.51%)` | :arrow_down: |
   | [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `90.67% <85.71%> (-0.48%)` | :arrow_down: |
   | [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `71.35% <100.00%> (-7.89%)` | :arrow_down: |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `59.40% <100.00%> (ø)` | |
   | [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
   | [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
   | [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
   | ... and [322 more](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=footer). Last update [db73869...d48f5d4](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11665: [WIP] feat: add event and interval annotation support to chart data ep

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11665:
URL: https://github.com/apache/incubator-superset/pull/11665#issuecomment-726081922


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=h1) Report
   > Merging [#11665](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=desc) (4e5d3d8) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2718909314428d573698058b0a9065a4215b30cc?el=desc) (2718909) will **decrease** coverage by `0.31%`.
   > The diff coverage is `57.14%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11665/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11665      +/-   ##
   ==========================================
   - Coverage   62.36%   62.05%   -0.32%     
   ==========================================
     Files         874      423     -451     
     Lines       42336    26369   -15967     
     Branches     3972        0    -3972     
   ==========================================
   - Hits        26402    16362   -10040     
   + Misses      15754    10007    -5747     
   + Partials      180        0     -180     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `?` | |
   | python | `62.05% <57.14%> (-0.02%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `80.48% <51.21%> (-7.47%)` | :arrow_down: |
   | [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `90.67% <85.71%> (-0.48%)` | :arrow_down: |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `59.33% <100.00%> (ø)` | |
   | [...src/SqlLab/utils/reduxStateToLocalStorageHelper.js](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi91dGlscy9yZWR1eFN0YXRlVG9Mb2NhbFN0b3JhZ2VIZWxwZXIuanM=) | | |
   | [.../src/SqlLab/components/EstimateQueryCostButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0VzdGltYXRlUXVlcnlDb3N0QnV0dG9uLmpzeA==) | | |
   | [.../explore/components/controls/CollectionControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xsZWN0aW9uQ29udHJvbC5qc3g=) | | |
   | [.../src/explore/components/controls/HiddenControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9IaWRkZW5Db250cm9sLmpzeA==) | | |
   | [...frontend/src/dashboard/containers/FiltersBadge.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0ZpbHRlcnNCYWRnZS50c3g=) | | |
   | [...tend/src/dashboard/containers/DashboardBuilder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZEJ1aWxkZXIuanN4) | | |
   | [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | | |
   | ... and [443 more](https://codecov.io/gh/apache/incubator-superset/pull/11665/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=footer). Last update [2718909...4e5d3d8](https://codecov.io/gh/apache/incubator-superset/pull/11665?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org