[GitHub] [cloudstack] DaanHoogland commented on pull request #5239: Externalize KVM Agent storage's timeout configuration

[GitBox <gi...@apache.org>]

DaanHoogland commented on pull request #5239:
URL: https://github.com/apache/cloudstack/pull/5239#issuecomment-885640255


   > @DaanHoogland @nvazquez as we discussed, I created a new PR proposing the reverted work. At the time you raised the issue (in [#4585 (comment)](https://github.com/apache/cloudstack/pull/4585#issuecomment-882565561)),
   
   great, I'll run the tests.
   
   > I think that next time something like this happens, we should investigate the real problem and pin point it in some part of the code, instead of just reverting the first thing we see in hopes that this fixes the issue.
   
   It was not hoping @GutoVeronezi , I tested the revert and the PR itself. I indeed had no time to get to the bottom of it. Also I do/did not believe for a moment it was in the PR itself but in some sort of conflict with other code.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org