[GitHub] [tvm] electriclilies edited a comment on pull request #9861: JSON deserialization default to null

[GitBox <gi...@apache.org>]

electriclilies edited a comment on pull request #9861:
URL: https://github.com/apache/tvm/pull/9861#issuecomment-1007624056


   OK, thanks for the thoughts.
   
   What do you think about just letting the virtual_device_ have a default? So, I'd add something like this:
   
   ```
   if key == "virtual_device_":
       return "0"
   else: 
      LOG(FATAL) << "... "
   ```
   
   If I don't do that, I can definitely implement the converter, but I just want to note that I'd probably need to rev the TVM version, either to 0.81 or 0.90 (not sure what our convention for revving the version is) so we can convert the 0.80 graphs that we rely on. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org