[GitHub] [zookeeper] TisonKun commented on a change in pull request #1019: ZOOKEEPER-3464:enfore checkstyle in the zookeeper-server module and clean the package:admin and client

[GitBox <gi...@apache.org>]

TisonKun commented on a change in pull request #1019: ZOOKEEPER-3464:enfore checkstyle in the zookeeper-server module and clean the package:admin and client
URL: https://github.com/apache/zookeeper/pull/1019#discussion_r306134927
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -582,19 +582,20 @@
               <version>${checkstyle.version}</version>
             </dependency>
           </dependencies>
-          <configuration>
-            <configLocation>checkstyle.xml</configLocation>
-            <suppressionsLocation>checkstyleSuppressions.xml</suppressionsLocation>
-            <encoding>UTF-8</encoding>
-            <consoleOutput>true</consoleOutput>
-            <failOnViolation>true</failOnViolation>
-            <includeResources>false</includeResources>
-            <includeTestSourceDirectory>true</includeTestSourceDirectory>
-          </configuration>
           <executions>
             <execution>
               <id>checkstyle</id>
               <phase>validate</phase>
+              <configuration>
+                <configLocation>checkstyle.xml</configLocation>
 
 Review comment:
   It is reasonable to use a `checkstyle-strict.xml` covering the simple config in pkgs we want to enable more rules.
   
   For "I check that our code base doesn't have the '@author' tag", I think you should also test if a '@author' tag exists, the build fails with correct reason.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services