You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Matt Foley (JIRA)" <ji...@apache.org> on 2011/04/12 06:47:05 UTC
[jira] [Created] (HDFS-1829) TestNodeCount waits forever, errs
without giving information
TestNodeCount waits forever, errs without giving information
------------------------------------------------------------
Key: HDFS-1829
URL: https://issues.apache.org/jira/browse/HDFS-1829
Project: Hadoop HDFS
Issue Type: Bug
Components: name-node
Affects Versions: 0.23.0
Reporter: Matt Foley
Assignee: Matt Foley
Fix For: 0.23.0
In three locations in the code, TestBalancer waits forever on a condition. Failures result in Hudson/Jenkins "Timeout occurred" error message with no information about where or why. Need to replace with TimeoutExceptions that throw a stack trace and useful info about the failure mode.
Also investigate possible cause of failure.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-1829) TestNodeCount waits forever, errs
without giving information
Posted by "Matt Foley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matt Foley updated HDFS-1829:
-----------------------------
Attachment: 1829_TestNodeCount_v4.patch
I had originally rejected trying to factor out those similar-but-different loops, because using callback objects would have increased the code complexity more than was worthwhile. However, you pushed me to look at it again, and there's a better solution :-) Please see if you agree.
> TestNodeCount waits forever, errs without giving information
> ------------------------------------------------------------
>
> Key: HDFS-1829
> URL: https://issues.apache.org/jira/browse/HDFS-1829
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.23.0
> Reporter: Matt Foley
> Assignee: Matt Foley
> Fix For: 0.23.0
>
> Attachments: 1829_TestNodeCount_v4.patch, TestNodeCount.java.patch, TestNodeCount_v2.patch
>
>
> In three locations in the code, TestNodeCount waits forever on a condition. Failures result in Hudson/Jenkins "Timeout occurred" error message with no information about where or why. Need to replace with TimeoutExceptions that throw a stack trace and useful info about the failure mode.
> Also investigate possible cause of failure.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1829) TestNodeCount waits forever, errs
without giving information
Posted by "Matt Foley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13025487#comment-13025487 ]
Matt Foley commented on HDFS-1829:
----------------------------------
Neither of these failed core tests are related to this patch. No methods of TestNodeCount are called outside of this unit test.
Ready for commit.
> TestNodeCount waits forever, errs without giving information
> ------------------------------------------------------------
>
> Key: HDFS-1829
> URL: https://issues.apache.org/jira/browse/HDFS-1829
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.23.0
> Reporter: Matt Foley
> Assignee: Matt Foley
> Fix For: 0.23.0
>
> Attachments: 1829_TestNodeCount_v4.patch, 1829_TestNodeCount_v4.patch, TestNodeCount.java.patch, TestNodeCount_v2.patch
>
>
> In three locations in the code, TestNodeCount waits forever on a condition. Failures result in Hudson/Jenkins "Timeout occurred" error message with no information about where or why. Need to replace with TimeoutExceptions that throw a stack trace and useful info about the failure mode.
> Also investigate possible cause of failure.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1829) TestNodeCount waits forever, errs
without giving information
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13025625#comment-13025625 ]
Hudson commented on HDFS-1829:
------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #609 (See [https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/609/])
HDFS-1829. TestNodeCount waits forever, errs without giving information. Contributed by Matt Foley
> TestNodeCount waits forever, errs without giving information
> ------------------------------------------------------------
>
> Key: HDFS-1829
> URL: https://issues.apache.org/jira/browse/HDFS-1829
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.23.0
> Reporter: Matt Foley
> Assignee: Matt Foley
> Fix For: 0.23.0
>
> Attachments: 1829_TestNodeCount_v4.patch, 1829_TestNodeCount_v4.patch, TestNodeCount.java.patch, TestNodeCount_v2.patch
>
>
> In three locations in the code, TestNodeCount waits forever on a condition. Failures result in Hudson/Jenkins "Timeout occurred" error message with no information about where or why. Need to replace with TimeoutExceptions that throw a stack trace and useful info about the failure mode.
> Also investigate possible cause of failure.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1829) TestNodeCount waits forever, errs
without giving information
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13023085#comment-13023085 ]
Hadoop QA commented on HDFS-1829:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12477065/1829_TestNodeCount_v4.patch
against trunk revision 1095830.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these core unit tests:
org.apache.hadoop.cli.TestHDFSCLI
org.apache.hadoop.hdfs.server.datanode.TestBlockRecovery
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/407//testReport/
Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/407//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/407//console
This message is automatically generated.
> TestNodeCount waits forever, errs without giving information
> ------------------------------------------------------------
>
> Key: HDFS-1829
> URL: https://issues.apache.org/jira/browse/HDFS-1829
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.23.0
> Reporter: Matt Foley
> Assignee: Matt Foley
> Fix For: 0.23.0
>
> Attachments: 1829_TestNodeCount_v4.patch, 1829_TestNodeCount_v4.patch, TestNodeCount.java.patch, TestNodeCount_v2.patch
>
>
> In three locations in the code, TestNodeCount waits forever on a condition. Failures result in Hudson/Jenkins "Timeout occurred" error message with no information about where or why. Need to replace with TimeoutExceptions that throw a stack trace and useful info about the failure mode.
> Also investigate possible cause of failure.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1829) TestNodeCount waits forever, errs
without giving information
Posted by "Matt Foley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13018715#comment-13018715 ]
Matt Foley commented on HDFS-1829:
----------------------------------
Converted the infinite waits to 20 second timeouts with informative TimeoutException message info.
I did not find an obvious explanation for the failure, but did find that only one of three calls to namesystem.blockManager.countNodes(block) was correctly synchronized on namesystem. Fixed the other two, following the same pattern. Although, in retrospect, all three really should be replaced by readLock() calls. I'll fix that in the next version.
> TestNodeCount waits forever, errs without giving information
> ------------------------------------------------------------
>
> Key: HDFS-1829
> URL: https://issues.apache.org/jira/browse/HDFS-1829
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.23.0
> Reporter: Matt Foley
> Assignee: Matt Foley
> Fix For: 0.23.0
>
> Attachments: TestNodeCount.java.patch
>
>
> In three locations in the code, TestNodeCount waits forever on a condition. Failures result in Hudson/Jenkins "Timeout occurred" error message with no information about where or why. Need to replace with TimeoutExceptions that throw a stack trace and useful info about the failure mode.
> Also investigate possible cause of failure.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-1829) TestNodeCount waits forever, errs
without giving information
Posted by "Matt Foley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matt Foley updated HDFS-1829:
-----------------------------
Attachment: TestNodeCount.java.patch
> TestNodeCount waits forever, errs without giving information
> ------------------------------------------------------------
>
> Key: HDFS-1829
> URL: https://issues.apache.org/jira/browse/HDFS-1829
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.23.0
> Reporter: Matt Foley
> Assignee: Matt Foley
> Fix For: 0.23.0
>
> Attachments: TestNodeCount.java.patch
>
>
> In three locations in the code, TestNodeCount waits forever on a condition. Failures result in Hudson/Jenkins "Timeout occurred" error message with no information about where or why. Need to replace with TimeoutExceptions that throw a stack trace and useful info about the failure mode.
> Also investigate possible cause of failure.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-1829) TestNodeCount waits forever, errs
without giving information
Posted by "Matt Foley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matt Foley updated HDFS-1829:
-----------------------------
Attachment: TestNodeCount_v2.patch
This patch has correct synchronization using readLock().
> TestNodeCount waits forever, errs without giving information
> ------------------------------------------------------------
>
> Key: HDFS-1829
> URL: https://issues.apache.org/jira/browse/HDFS-1829
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.23.0
> Reporter: Matt Foley
> Assignee: Matt Foley
> Fix For: 0.23.0
>
> Attachments: TestNodeCount.java.patch, TestNodeCount_v2.patch
>
>
> In three locations in the code, TestNodeCount waits forever on a condition. Failures result in Hudson/Jenkins "Timeout occurred" error message with no information about where or why. Need to replace with TimeoutExceptions that throw a stack trace and useful info about the failure mode.
> Also investigate possible cause of failure.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1829) TestNodeCount waits forever, errs
without giving information
Posted by "Matt Foley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13019933#comment-13019933 ]
Matt Foley commented on HDFS-1829:
----------------------------------
In test build 366, we see TestNodeCount fail with NullPointerException in BlockManager. (ref https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/366//testReport/org.apache.hadoop.hdfs.server.namenode/TestNodeCount/testNodeCount/ )
Such an error certainly can be caused by lack of synchronization. This patch [ 12476098 ] should address it.
> TestNodeCount waits forever, errs without giving information
> ------------------------------------------------------------
>
> Key: HDFS-1829
> URL: https://issues.apache.org/jira/browse/HDFS-1829
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.23.0
> Reporter: Matt Foley
> Assignee: Matt Foley
> Fix For: 0.23.0
>
> Attachments: TestNodeCount.java.patch
>
>
> In three locations in the code, TestNodeCount waits forever on a condition. Failures result in Hudson/Jenkins "Timeout occurred" error message with no information about where or why. Need to replace with TimeoutExceptions that throw a stack trace and useful info about the failure mode.
> Also investigate possible cause of failure.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-1829) TestNodeCount waits forever, errs
without giving information
Posted by "Matt Foley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matt Foley updated HDFS-1829:
-----------------------------
Status: Patch Available (was: Open)
> TestNodeCount waits forever, errs without giving information
> ------------------------------------------------------------
>
> Key: HDFS-1829
> URL: https://issues.apache.org/jira/browse/HDFS-1829
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.23.0
> Reporter: Matt Foley
> Assignee: Matt Foley
> Fix For: 0.23.0
>
> Attachments: TestNodeCount.java.patch, TestNodeCount_v2.patch
>
>
> In three locations in the code, TestNodeCount waits forever on a condition. Failures result in Hudson/Jenkins "Timeout occurred" error message with no information about where or why. Need to replace with TimeoutExceptions that throw a stack trace and useful info about the failure mode.
> Also investigate possible cause of failure.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-1829) TestNodeCount waits forever, errs
without giving information
Posted by "Matt Foley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matt Foley updated HDFS-1829:
-----------------------------
Description:
In three locations in the code, TestNodeCount waits forever on a condition. Failures result in Hudson/Jenkins "Timeout occurred" error message with no information about where or why. Need to replace with TimeoutExceptions that throw a stack trace and useful info about the failure mode.
Also investigate possible cause of failure.
was:
In three locations in the code, TestBalancer waits forever on a condition. Failures result in Hudson/Jenkins "Timeout occurred" error message with no information about where or why. Need to replace with TimeoutExceptions that throw a stack trace and useful info about the failure mode.
Also investigate possible cause of failure.
> TestNodeCount waits forever, errs without giving information
> ------------------------------------------------------------
>
> Key: HDFS-1829
> URL: https://issues.apache.org/jira/browse/HDFS-1829
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.23.0
> Reporter: Matt Foley
> Assignee: Matt Foley
> Fix For: 0.23.0
>
>
> In three locations in the code, TestNodeCount waits forever on a condition. Failures result in Hudson/Jenkins "Timeout occurred" error message with no information about where or why. Need to replace with TimeoutExceptions that throw a stack trace and useful info about the failure mode.
> Also investigate possible cause of failure.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1829) TestNodeCount waits forever, errs
without giving information
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13021378#comment-13021378 ]
Konstantin Boudnik commented on HDFS-1829:
------------------------------------------
Ah, 'better simpler than clever'! You've avoided callables all together yet the code doesn't have original dups. I like it.
+1 patch looks good.
What about failing tests? Are they related?
> TestNodeCount waits forever, errs without giving information
> ------------------------------------------------------------
>
> Key: HDFS-1829
> URL: https://issues.apache.org/jira/browse/HDFS-1829
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.23.0
> Reporter: Matt Foley
> Assignee: Matt Foley
> Fix For: 0.23.0
>
> Attachments: 1829_TestNodeCount_v4.patch, TestNodeCount.java.patch, TestNodeCount_v2.patch
>
>
> In three locations in the code, TestNodeCount waits forever on a condition. Failures result in Hudson/Jenkins "Timeout occurred" error message with no information about where or why. Need to replace with TimeoutExceptions that throw a stack trace and useful info about the failure mode.
> Also investigate possible cause of failure.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1829) TestNodeCount waits forever, errs
without giving information
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13022595#comment-13022595 ]
Eli Collins commented on HDFS-1829:
-----------------------------------
bq. Eli, can we open another Jira for that?
Absolutely. What you have here is the right direction, we can always refactor the wait to DFSTestUtil later.
+1 on 1829_TestNodeCount_v4.patch
> TestNodeCount waits forever, errs without giving information
> ------------------------------------------------------------
>
> Key: HDFS-1829
> URL: https://issues.apache.org/jira/browse/HDFS-1829
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.23.0
> Reporter: Matt Foley
> Assignee: Matt Foley
> Fix For: 0.23.0
>
> Attachments: 1829_TestNodeCount_v4.patch, TestNodeCount.java.patch, TestNodeCount_v2.patch
>
>
> In three locations in the code, TestNodeCount waits forever on a condition. Failures result in Hudson/Jenkins "Timeout occurred" error message with no information about where or why. Need to replace with TimeoutExceptions that throw a stack trace and useful info about the failure mode.
> Also investigate possible cause of failure.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-1829) TestNodeCount waits forever, errs
without giving information
Posted by "Matt Foley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matt Foley updated HDFS-1829:
-----------------------------
Attachment: 1829_TestNodeCount_v4.patch
re-upload to trigger Hudson
> TestNodeCount waits forever, errs without giving information
> ------------------------------------------------------------
>
> Key: HDFS-1829
> URL: https://issues.apache.org/jira/browse/HDFS-1829
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.23.0
> Reporter: Matt Foley
> Assignee: Matt Foley
> Fix For: 0.23.0
>
> Attachments: 1829_TestNodeCount_v4.patch, 1829_TestNodeCount_v4.patch, TestNodeCount.java.patch, TestNodeCount_v2.patch
>
>
> In three locations in the code, TestNodeCount waits forever on a condition. Failures result in Hudson/Jenkins "Timeout occurred" error message with no information about where or why. Need to replace with TimeoutExceptions that throw a stack trace and useful info about the failure mode.
> Also investigate possible cause of failure.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1829) TestNodeCount waits forever, errs
without giving information
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13021687#comment-13021687 ]
Eli Collins commented on HDFS-1829:
-----------------------------------
How about handling these as is done for HDFS-1562? You could augment NameNodeAdapter#getReplicaInfo to return excess and live replica counts as well and then just add waitFor[Live|Excess]Replicas methods to DFSTestUtil and have TestNodeCount call them. This way we could re-use them in the other replication tests.
> TestNodeCount waits forever, errs without giving information
> ------------------------------------------------------------
>
> Key: HDFS-1829
> URL: https://issues.apache.org/jira/browse/HDFS-1829
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.23.0
> Reporter: Matt Foley
> Assignee: Matt Foley
> Fix For: 0.23.0
>
> Attachments: 1829_TestNodeCount_v4.patch, TestNodeCount.java.patch, TestNodeCount_v2.patch
>
>
> In three locations in the code, TestNodeCount waits forever on a condition. Failures result in Hudson/Jenkins "Timeout occurred" error message with no information about where or why. Need to replace with TimeoutExceptions that throw a stack trace and useful info about the failure mode.
> Also investigate possible cause of failure.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-1829) TestNodeCount waits forever, errs
without giving information
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HDFS-1829:
------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I've committed this. Thanks Matt!
> TestNodeCount waits forever, errs without giving information
> ------------------------------------------------------------
>
> Key: HDFS-1829
> URL: https://issues.apache.org/jira/browse/HDFS-1829
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.23.0
> Reporter: Matt Foley
> Assignee: Matt Foley
> Fix For: 0.23.0
>
> Attachments: 1829_TestNodeCount_v4.patch, 1829_TestNodeCount_v4.patch, TestNodeCount.java.patch, TestNodeCount_v2.patch
>
>
> In three locations in the code, TestNodeCount waits forever on a condition. Failures result in Hudson/Jenkins "Timeout occurred" error message with no information about where or why. Need to replace with TimeoutExceptions that throw a stack trace and useful info about the failure mode.
> Also investigate possible cause of failure.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1829) TestNodeCount waits forever, errs
without giving information
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13026279#comment-13026279 ]
Hudson commented on HDFS-1829:
------------------------------
Integrated in Hadoop-Hdfs-trunk #650 (See [https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/650/])
> TestNodeCount waits forever, errs without giving information
> ------------------------------------------------------------
>
> Key: HDFS-1829
> URL: https://issues.apache.org/jira/browse/HDFS-1829
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.23.0
> Reporter: Matt Foley
> Assignee: Matt Foley
> Fix For: 0.23.0
>
> Attachments: 1829_TestNodeCount_v4.patch, 1829_TestNodeCount_v4.patch, TestNodeCount.java.patch, TestNodeCount_v2.patch
>
>
> In three locations in the code, TestNodeCount waits forever on a condition. Failures result in Hudson/Jenkins "Timeout occurred" error message with no information about where or why. Need to replace with TimeoutExceptions that throw a stack trace and useful info about the failure mode.
> Also investigate possible cause of failure.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1829) TestNodeCount waits forever, errs
without giving information
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13020168#comment-13020168 ]
Hadoop QA commented on HDFS-1829:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12476383/TestNodeCount_v2.patch
against trunk revision 1092534.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these core unit tests:
org.apache.hadoop.hdfs.server.datanode.TestBlockReport
org.apache.hadoop.hdfs.TestFileAppend4
org.apache.hadoop.hdfs.TestFileConcurrentReader
org.apache.hadoop.hdfs.TestLargeBlock
org.apache.hadoop.hdfs.TestWriteConfigurationToDFS
-1 contrib tests. The patch failed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/370//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/370//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/370//console
This message is automatically generated.
> TestNodeCount waits forever, errs without giving information
> ------------------------------------------------------------
>
> Key: HDFS-1829
> URL: https://issues.apache.org/jira/browse/HDFS-1829
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.23.0
> Reporter: Matt Foley
> Assignee: Matt Foley
> Fix For: 0.23.0
>
> Attachments: TestNodeCount.java.patch, TestNodeCount_v2.patch
>
>
> In three locations in the code, TestNodeCount waits forever on a condition. Failures result in Hudson/Jenkins "Timeout occurred" error message with no information about where or why. Need to replace with TimeoutExceptions that throw a stack trace and useful info about the failure mode.
> Also investigate possible cause of failure.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1829) TestNodeCount waits forever, errs
without giving information
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13020160#comment-13020160 ]
Konstantin Boudnik commented on HDFS-1829:
------------------------------------------
I think it makes sense to have a new private method instead of copying pretty much the same code 3 times. Surely the iterators in while loops are different methods but I think you can parametrized it via Callable.
> TestNodeCount waits forever, errs without giving information
> ------------------------------------------------------------
>
> Key: HDFS-1829
> URL: https://issues.apache.org/jira/browse/HDFS-1829
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.23.0
> Reporter: Matt Foley
> Assignee: Matt Foley
> Fix For: 0.23.0
>
> Attachments: TestNodeCount.java.patch, TestNodeCount_v2.patch
>
>
> In three locations in the code, TestNodeCount waits forever on a condition. Failures result in Hudson/Jenkins "Timeout occurred" error message with no information about where or why. Need to replace with TimeoutExceptions that throw a stack trace and useful info about the failure mode.
> Also investigate possible cause of failure.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1829) TestNodeCount waits forever, errs
without giving information
Posted by "Matt Foley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13022575#comment-13022575 ]
Matt Foley commented on HDFS-1829:
----------------------------------
Eli, can we open another Jira for that? My goal here was only to get rid of the recurring false positive in Hudson for this unit test, which this patch does in a clean way. Your suggestion would be a good contribution to the toolkit (and I have been trying to do that along the way, as you know), but I've already spent more time than I should on this issue.
> TestNodeCount waits forever, errs without giving information
> ------------------------------------------------------------
>
> Key: HDFS-1829
> URL: https://issues.apache.org/jira/browse/HDFS-1829
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.23.0
> Reporter: Matt Foley
> Assignee: Matt Foley
> Fix For: 0.23.0
>
> Attachments: 1829_TestNodeCount_v4.patch, TestNodeCount.java.patch, TestNodeCount_v2.patch
>
>
> In three locations in the code, TestNodeCount waits forever on a condition. Failures result in Hudson/Jenkins "Timeout occurred" error message with no information about where or why. Need to replace with TimeoutExceptions that throw a stack trace and useful info about the failure mode.
> Also investigate possible cause of failure.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1829) TestNodeCount waits forever, errs
without giving information
Posted by "Matt Foley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13022579#comment-13022579 ]
Matt Foley commented on HDFS-1829:
----------------------------------
Cos, this patch only modifies TestNodeCount, and TestNodeCount and its methods are not called from outside that unit test module, so other tests failing have nothing to do with this test. However, I am waiting for another run of Hudson and will respond to its results before asking for a commit. Thanks.
> TestNodeCount waits forever, errs without giving information
> ------------------------------------------------------------
>
> Key: HDFS-1829
> URL: https://issues.apache.org/jira/browse/HDFS-1829
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.23.0
> Reporter: Matt Foley
> Assignee: Matt Foley
> Fix For: 0.23.0
>
> Attachments: 1829_TestNodeCount_v4.patch, TestNodeCount.java.patch, TestNodeCount_v2.patch
>
>
> In three locations in the code, TestNodeCount waits forever on a condition. Failures result in Hudson/Jenkins "Timeout occurred" error message with no information about where or why. Need to replace with TimeoutExceptions that throw a stack trace and useful info about the failure mode.
> Also investigate possible cause of failure.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1829) TestNodeCount waits forever, errs
without giving information
Posted by "Matt Foley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13022629#comment-13022629 ]
Matt Foley commented on HDFS-1829:
----------------------------------
Thanks, Eli. Opened HDFS-1853 for the suggested refactoring. Also opened HDFS-1852 as an umbrella task for gathering and discussing many possible such improvements.
> TestNodeCount waits forever, errs without giving information
> ------------------------------------------------------------
>
> Key: HDFS-1829
> URL: https://issues.apache.org/jira/browse/HDFS-1829
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.23.0
> Reporter: Matt Foley
> Assignee: Matt Foley
> Fix For: 0.23.0
>
> Attachments: 1829_TestNodeCount_v4.patch, TestNodeCount.java.patch, TestNodeCount_v2.patch
>
>
> In three locations in the code, TestNodeCount waits forever on a condition. Failures result in Hudson/Jenkins "Timeout occurred" error message with no information about where or why. Need to replace with TimeoutExceptions that throw a stack trace and useful info about the failure mode.
> Also investigate possible cause of failure.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira