You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by cs...@apache.org on 2023/12/19 14:07:26 UTC

(impala) 01/03: IMPALA-12500: Reduce flakyness of test_global_exchange_counters

This is an automated email from the ASF dual-hosted git repository.

csringhofer pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git

commit 4391595f02d02ac9169bc0fd18a049e4a35eafe3
Author: Csaba Ringhofer <cs...@cloudera.com>
AuthorDate: Mon Dec 18 15:43:39 2023 +0100

    IMPALA-12500: Reduce flakyness of test_global_exchange_counters
    
    Ran the tests repeatedly and the failures I saw were only 0.01 off.
    Ignoring the last digit of ExchangeScanRatio seems to be enough
    to make the test consistently green.
    
    Change-Id: I530b690128d4c55a793440425dd39c6523741bf7
    Reviewed-on: http://gerrit.cloudera.org:8080/20811
    Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
    Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
 tests/query_test/test_observability.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/query_test/test_observability.py b/tests/query_test/test_observability.py
index d6cd299c6..d82b3b0d7 100644
--- a/tests/query_test/test_observability.py
+++ b/tests/query_test/test_observability.py
@@ -560,7 +560,8 @@ class TestObservability(ImpalaTestSuite):
     assert "  MemoryUsage" not in profile
     assert "- MemoryUsage" in profile
 
-    assert "ExchangeScanRatio: 4.63" in profile
+    # Usually 4.63. Ignoring last digit to deflake test (IMPALA-12500).
+    assert "ExchangeScanRatio: 4.6" in profile
 
     keys = ["TotalBytesSent", "TotalScanBytesSent", "TotalInnerBytesSent"]
     counters = defaultdict(int)