You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/06/21 20:34:51 UTC

[GitHub] williaster closed pull request #5263: [timeseries table] use verbose date in tooltip by default

williaster closed pull request #5263: [timeseries table] use verbose date in tooltip by default
URL: https://github.com/apache/incubator-superset/pull/5263
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/superset/assets/src/modules/dates.js b/superset/assets/src/modules/dates.js
index f8d8684f73..8b8dfa9dfc 100644
--- a/superset/assets/src/modules/dates.js
+++ b/superset/assets/src/modules/dates.js
@@ -114,7 +114,7 @@ export const formatDateVerbose = function (dttm) {
 
 export const formatDateThunk = function (format) {
   if (!format) {
-    return formatDate;
+    return formatDateVerbose;
   }
 
   const formatter = d3.time.format(format);


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org