You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2016/04/13 16:24:05 UTC
Review Request 46146: Fixed libprocess tests to use smart pointers.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46146/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier and Joris Van Remoortere.
Repository: mesos
Description
-------
This ensures that dynamically allocated memory is released when
a test aborts prematurely due to an EXPECT_XXX failure.
Diffs
-----
3rdparty/libprocess/src/tests/decoder_tests.cpp bd990c5eb77e47d7f617199bcc89e9432af7cc51
3rdparty/libprocess/src/tests/process_tests.cpp 274a76fa61a5cd4b1324be124f73979d4b980660
3rdparty/libprocess/src/tests/sequence_tests.cpp 566393fbf3f19644b86843f07194d1de36a2015e
Diff: https://reviews.apache.org/r/46146/diff/
Testing
-------
make check on OSX and Linux.
Thanks,
Neil Conway
Re: Review Request 46146: Fixed libprocess tests to use smart
pointers.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46146/#review128864
-----------------------------------------------------------
Ship it!
- Benjamin Bannier
On April 13, 2016, 4:24 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46146/
> -----------------------------------------------------------
>
> (Updated April 13, 2016, 4:24 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Joris Van Remoortere.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This ensures that dynamically allocated memory is released when
> a test aborts prematurely due to an EXPECT_XXX failure.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/tests/decoder_tests.cpp bd990c5eb77e47d7f617199bcc89e9432af7cc51
> 3rdparty/libprocess/src/tests/process_tests.cpp 274a76fa61a5cd4b1324be124f73979d4b980660
> 3rdparty/libprocess/src/tests/sequence_tests.cpp 566393fbf3f19644b86843f07194d1de36a2015e
>
> Diff: https://reviews.apache.org/r/46146/diff/
>
>
> Testing
> -------
>
> make check on OSX and Linux.
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 46146: Fixed libprocess tests to use smart
pointers.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46146/#review128722
-----------------------------------------------------------
Patch looks great!
Reviews applied: [45991, 45995, 45996, 45999, 46094, 46146]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On April 13, 2016, 2:24 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46146/
> -----------------------------------------------------------
>
> (Updated April 13, 2016, 2:24 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Joris Van Remoortere.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This ensures that dynamically allocated memory is released when
> a test aborts prematurely due to an EXPECT_XXX failure.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/tests/decoder_tests.cpp bd990c5eb77e47d7f617199bcc89e9432af7cc51
> 3rdparty/libprocess/src/tests/process_tests.cpp 274a76fa61a5cd4b1324be124f73979d4b980660
> 3rdparty/libprocess/src/tests/sequence_tests.cpp 566393fbf3f19644b86843f07194d1de36a2015e
>
> Diff: https://reviews.apache.org/r/46146/diff/
>
>
> Testing
> -------
>
> make check on OSX and Linux.
>
>
> Thanks,
>
> Neil Conway
>
>