You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ch...@apache.org on 2017/05/24 18:41:04 UTC
[16/50] [abbrv] commons-imaging git commit: Add final modifier to
method parameters.
Add final modifier to method parameters.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/imaging/trunk@1775888 13f79535-47bb-0310-9956-ffa450edef68
Project: http://git-wip-us.apache.org/repos/asf/commons-imaging/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-imaging/commit/56e0133a
Tree: http://git-wip-us.apache.org/repos/asf/commons-imaging/tree/56e0133a
Diff: http://git-wip-us.apache.org/repos/asf/commons-imaging/diff/56e0133a
Branch: refs/heads/master
Commit: 56e0133a0f9b7c89eb180696b13e53ba38007beb
Parents: b232532
Author: Gary D. Gregory <gg...@apache.org>
Authored: Fri Dec 23 18:58:51 2016 +0000
Committer: Gary D. Gregory <gg...@apache.org>
Committed: Fri Dec 23 18:58:51 2016 +0000
----------------------------------------------------------------------
.../java/org/apache/commons/imaging/ColorTools.java | 2 +-
src/main/java/org/apache/commons/imaging/ImageInfo.java | 4 ++--
.../org/apache/commons/imaging/color/ColorCieLab.java | 2 +-
.../org/apache/commons/imaging/color/ColorCieLch.java | 2 +-
.../org/apache/commons/imaging/color/ColorCieLuv.java | 2 +-
.../java/org/apache/commons/imaging/color/ColorCmy.java | 2 +-
.../org/apache/commons/imaging/color/ColorCmyk.java | 2 +-
.../java/org/apache/commons/imaging/color/ColorHsl.java | 2 +-
.../java/org/apache/commons/imaging/color/ColorHsv.java | 2 +-
.../apache/commons/imaging/color/ColorHunterLab.java | 2 +-
.../java/org/apache/commons/imaging/color/ColorXyz.java | 2 +-
.../commons/imaging/formats/bmp/BmpImageContents.java | 2 +-
.../apache/commons/imaging/formats/icns/IcnsType.java | 2 +-
.../commons/imaging/formats/jpeg/JpegImageParser.java | 2 +-
.../imaging/formats/jpeg/segments/App14Segment.java | 4 ++--
.../imaging/formats/jpeg/segments/AppnSegment.java | 2 +-
.../imaging/formats/jpeg/segments/ComSegment.java | 2 +-
.../imaging/formats/jpeg/segments/DhtSegment.java | 8 ++++----
.../imaging/formats/jpeg/segments/GenericSegment.java | 6 +++---
.../imaging/formats/jpeg/segments/UnknownSegment.java | 2 +-
.../commons/imaging/formats/png/InterlaceMethod.java | 2 +-
.../commons/imaging/formats/png/PngColorType.java | 8 ++++----
.../commons/imaging/formats/png/PngImageParser.java | 2 +-
.../apache/commons/imaging/formats/png/PngWriter.java | 2 +-
.../commons/imaging/formats/png/ScanExpediter.java | 2 +-
.../imaging/formats/png/ScanExpediterInterlaced.java | 12 ++++++------
.../imaging/formats/png/chunks/PngChunkIdat.java | 2 +-
.../imaging/formats/png/chunks/PngChunkIhdr.java | 2 +-
.../imaging/formats/png/chunks/PngChunkPhys.java | 2 +-
.../imaging/formats/png/chunks/PngChunkScal.java | 2 +-
.../png/transparencyfilters/TransparencyFilter.java | 2 +-
.../TransparencyFilterGrayscale.java | 2 +-
.../TransparencyFilterTrueColor.java | 2 +-
.../apache/commons/imaging/formats/pnm/PgmWriter.java | 2 +-
.../apache/commons/imaging/formats/pnm/PpmWriter.java | 2 +-
.../commons/imaging/formats/psd/ImageResourceType.java | 4 ++--
.../commons/imaging/formats/psd/PsdHeaderInfo.java | 2 +-
.../commons/imaging/formats/tiff/TiffDirectory.java | 2 +-
.../commons/imaging/formats/tiff/TiffImageData.java | 2 +-
.../apache/commons/imaging/formats/tiff/TiffTags.java | 2 +-
.../formats/tiff/datareaders/ImageDataReader.java | 2 +-
.../photometricinterpreters/PhotometricInterpreter.java | 2 +-
.../apache/commons/imaging/palette/ColorComponent.java | 4 ++--
.../apache/commons/imaging/ImagingGuessFormatTest.java | 2 +-
.../commons/imaging/common/RationalNumberTest.java | 2 +-
.../imaging/common/bytesource/ByteSourceDataTest.java | 2 +-
.../imaging/common/bytesource/ByteSourceImageTest.java | 2 +-
.../apache/commons/imaging/formats/bmp/BmpReadTest.java | 2 +-
.../apache/commons/imaging/formats/dcx/DcxReadTest.java | 2 +-
.../apache/commons/imaging/formats/gif/GifReadTest.java | 2 +-
.../commons/imaging/formats/icns/IcnsReadTest.java | 2 +-
.../apache/commons/imaging/formats/ico/IcoReadTest.java | 2 +-
.../commons/imaging/formats/jpeg/JpegReadTest.java | 2 +-
.../commons/imaging/formats/jpeg/exif/ExifDumpTest.java | 2 +-
.../commons/imaging/formats/jpeg/exif/GpsTest.java | 2 +-
.../imaging/formats/jpeg/exif/MakerNoteFieldTest.java | 2 +-
.../imaging/formats/jpeg/exif/MicrosoftTagTest.java | 2 +-
.../imaging/formats/jpeg/exif/SpecificExifTagTest.java | 2 +-
.../imaging/formats/jpeg/exif/TextFieldTest.java | 2 +-
.../formats/jpeg/exif/WriteExifMetadataExampleTest.java | 2 +-
.../commons/imaging/formats/jpeg/iptc/IptcAddTest.java | 2 +-
.../commons/imaging/formats/jpeg/iptc/IptcDumpTest.java | 2 +-
.../imaging/formats/jpeg/iptc/IptcFullDiscardTest.java | 4 ++--
.../imaging/formats/jpeg/iptc/IptcUpdateTest.java | 6 +++---
.../imaging/formats/jpeg/xmp/JpegXmpDumpTest.java | 2 +-
.../imaging/formats/jpeg/xmp/JpegXmpRewriteTest.java | 2 +-
.../imaging/palette/PaletteQuantizationTest.java | 6 +++---
.../commons/imaging/roundtrip/BitmapRoundtripTest.java | 2 +-
68 files changed, 90 insertions(+), 90 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/main/java/org/apache/commons/imaging/ColorTools.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/imaging/ColorTools.java b/src/main/java/org/apache/commons/imaging/ColorTools.java
index e4fb115..7f50f64 100644
--- a/src/main/java/org/apache/commons/imaging/ColorTools.java
+++ b/src/main/java/org/apache/commons/imaging/ColorTools.java
@@ -185,7 +185,7 @@ public class ColorTools {
return convertBetweenColorSpaces(bi, from, srgbCM.getColorSpace());
}
- public BufferedImage convertBetweenICCProfiles(BufferedImage bi, ICC_Profile from, ICC_Profile to) {
+ public BufferedImage convertBetweenICCProfiles(final BufferedImage bi, final ICC_Profile from, final ICC_Profile to) {
final ICC_ColorSpace csFrom = new ICC_ColorSpace(from);
final ICC_ColorSpace csTo = new ICC_ColorSpace(to);
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/main/java/org/apache/commons/imaging/ImageInfo.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/imaging/ImageInfo.java b/src/main/java/org/apache/commons/imaging/ImageInfo.java
index 781ed0d..e9de2ef 100644
--- a/src/main/java/org/apache/commons/imaging/ImageInfo.java
+++ b/src/main/java/org/apache/commons/imaging/ImageInfo.java
@@ -40,7 +40,7 @@ public class ImageInfo {
private String description;
- ColorType(String description) {
+ ColorType(final String description) {
this.description = description;
}
@@ -66,7 +66,7 @@ public class ImageInfo {
private String description;
- CompressionAlgorithm(String description) {
+ CompressionAlgorithm(final String description) {
this.description = description;
}
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/main/java/org/apache/commons/imaging/color/ColorCieLab.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/imaging/color/ColorCieLab.java b/src/main/java/org/apache/commons/imaging/color/ColorCieLab.java
index d04b47e..e9167f2 100644
--- a/src/main/java/org/apache/commons/imaging/color/ColorCieLab.java
+++ b/src/main/java/org/apache/commons/imaging/color/ColorCieLab.java
@@ -84,7 +84,7 @@ public final class ColorCieLab {
}
@Override
- public boolean equals(Object o) {
+ public boolean equals(final Object o) {
if (this == o) {
return true;
}
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/main/java/org/apache/commons/imaging/color/ColorCieLch.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/imaging/color/ColorCieLch.java b/src/main/java/org/apache/commons/imaging/color/ColorCieLch.java
index b9f56a4..8c9314a 100644
--- a/src/main/java/org/apache/commons/imaging/color/ColorCieLch.java
+++ b/src/main/java/org/apache/commons/imaging/color/ColorCieLch.java
@@ -84,7 +84,7 @@ public final class ColorCieLch {
}
@Override
- public boolean equals(Object o) {
+ public boolean equals(final Object o) {
if (this == o) {
return true;
}
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/main/java/org/apache/commons/imaging/color/ColorCieLuv.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/imaging/color/ColorCieLuv.java b/src/main/java/org/apache/commons/imaging/color/ColorCieLuv.java
index 20e4a45..456aa36 100644
--- a/src/main/java/org/apache/commons/imaging/color/ColorCieLuv.java
+++ b/src/main/java/org/apache/commons/imaging/color/ColorCieLuv.java
@@ -84,7 +84,7 @@ public final class ColorCieLuv {
}
@Override
- public boolean equals(Object o) {
+ public boolean equals(final Object o) {
if (this == o) {
return true;
}
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/main/java/org/apache/commons/imaging/color/ColorCmy.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/imaging/color/ColorCmy.java b/src/main/java/org/apache/commons/imaging/color/ColorCmy.java
index e8da778..15a1483 100644
--- a/src/main/java/org/apache/commons/imaging/color/ColorCmy.java
+++ b/src/main/java/org/apache/commons/imaging/color/ColorCmy.java
@@ -114,7 +114,7 @@ public final class ColorCmy {
}
@Override
- public boolean equals(Object o) {
+ public boolean equals(final Object o) {
if (this == o) {
return true;
}
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/main/java/org/apache/commons/imaging/color/ColorCmyk.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/imaging/color/ColorCmyk.java b/src/main/java/org/apache/commons/imaging/color/ColorCmyk.java
index da65fdf..15e1858 100644
--- a/src/main/java/org/apache/commons/imaging/color/ColorCmyk.java
+++ b/src/main/java/org/apache/commons/imaging/color/ColorCmyk.java
@@ -124,7 +124,7 @@ public final class ColorCmyk {
}
@Override
- public boolean equals(Object o) {
+ public boolean equals(final Object o) {
if (this == o) {
return true;
}
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/main/java/org/apache/commons/imaging/color/ColorHsl.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/imaging/color/ColorHsl.java b/src/main/java/org/apache/commons/imaging/color/ColorHsl.java
index c167651..c08b3d8 100644
--- a/src/main/java/org/apache/commons/imaging/color/ColorHsl.java
+++ b/src/main/java/org/apache/commons/imaging/color/ColorHsl.java
@@ -84,7 +84,7 @@ public final class ColorHsl {
}
@Override
- public boolean equals(Object o) {
+ public boolean equals(final Object o) {
if (this == o) {
return true;
}
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/main/java/org/apache/commons/imaging/color/ColorHsv.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/imaging/color/ColorHsv.java b/src/main/java/org/apache/commons/imaging/color/ColorHsv.java
index 39ca880..4e2b63a 100644
--- a/src/main/java/org/apache/commons/imaging/color/ColorHsv.java
+++ b/src/main/java/org/apache/commons/imaging/color/ColorHsv.java
@@ -84,7 +84,7 @@ public final class ColorHsv {
}
@Override
- public boolean equals(Object o) {
+ public boolean equals(final Object o) {
if (this == o) {
return true;
}
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/main/java/org/apache/commons/imaging/color/ColorHunterLab.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/imaging/color/ColorHunterLab.java b/src/main/java/org/apache/commons/imaging/color/ColorHunterLab.java
index cbb4db3..ee719d8 100644
--- a/src/main/java/org/apache/commons/imaging/color/ColorHunterLab.java
+++ b/src/main/java/org/apache/commons/imaging/color/ColorHunterLab.java
@@ -84,7 +84,7 @@ public final class ColorHunterLab {
}
@Override
- public boolean equals(Object o) {
+ public boolean equals(final Object o) {
if (this == o) {
return true;
}
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/main/java/org/apache/commons/imaging/color/ColorXyz.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/imaging/color/ColorXyz.java b/src/main/java/org/apache/commons/imaging/color/ColorXyz.java
index 1c30989..68491e2 100644
--- a/src/main/java/org/apache/commons/imaging/color/ColorXyz.java
+++ b/src/main/java/org/apache/commons/imaging/color/ColorXyz.java
@@ -84,7 +84,7 @@ public final class ColorXyz {
}
@Override
- public boolean equals(Object o) {
+ public boolean equals(final Object o) {
if (this == o) {
return true;
}
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/main/java/org/apache/commons/imaging/formats/bmp/BmpImageContents.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/imaging/formats/bmp/BmpImageContents.java b/src/main/java/org/apache/commons/imaging/formats/bmp/BmpImageContents.java
index ce56e7f..c3197b3 100644
--- a/src/main/java/org/apache/commons/imaging/formats/bmp/BmpImageContents.java
+++ b/src/main/java/org/apache/commons/imaging/formats/bmp/BmpImageContents.java
@@ -23,7 +23,7 @@ class BmpImageContents {
final byte[] imageData;
final PixelParser pixelParser;
- public BmpImageContents(BmpHeaderInfo bhi, byte[] colorTable, byte[] imageData, PixelParser pixelParser) {
+ public BmpImageContents(final BmpHeaderInfo bhi, final byte[] colorTable, final byte[] imageData, final PixelParser pixelParser) {
this.bhi = bhi;
this.colorTable = colorTable;
this.imageData = imageData;
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/main/java/org/apache/commons/imaging/formats/icns/IcnsType.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/imaging/formats/icns/IcnsType.java b/src/main/java/org/apache/commons/imaging/formats/icns/IcnsType.java
index 6d9a4fd..276da92 100644
--- a/src/main/java/org/apache/commons/imaging/formats/icns/IcnsType.java
+++ b/src/main/java/org/apache/commons/imaging/formats/icns/IcnsType.java
@@ -85,7 +85,7 @@ enum IcnsType {
private final int bitsPerPixel;
private final boolean hasMask;
- private IcnsType(String type, int width, int height, int bitsPerPixel, boolean hasMask) {
+ private IcnsType(final String type, final int width, final int height, final int bitsPerPixel, final boolean hasMask) {
this.type = typeAsInt(type);
this.width = width;
this.height = height;
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/main/java/org/apache/commons/imaging/formats/jpeg/JpegImageParser.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/imaging/formats/jpeg/JpegImageParser.java b/src/main/java/org/apache/commons/imaging/formats/jpeg/JpegImageParser.java
index 5ce2362..6b11c3a 100644
--- a/src/main/java/org/apache/commons/imaging/formats/jpeg/JpegImageParser.java
+++ b/src/main/java/org/apache/commons/imaging/formats/jpeg/JpegImageParser.java
@@ -199,7 +199,7 @@ public class JpegImageParser extends ImageParser {
return result;
}
- private byte[] assembleSegments(List<App2Segment> segments) throws ImageReadException {
+ private byte[] assembleSegments(final List<App2Segment> segments) throws ImageReadException {
try {
return assembleSegments(segments, false);
} catch (ImageReadException e) {
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/main/java/org/apache/commons/imaging/formats/jpeg/segments/App14Segment.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/imaging/formats/jpeg/segments/App14Segment.java b/src/main/java/org/apache/commons/imaging/formats/jpeg/segments/App14Segment.java
index e49877a..2685666 100644
--- a/src/main/java/org/apache/commons/imaging/formats/jpeg/segments/App14Segment.java
+++ b/src/main/java/org/apache/commons/imaging/formats/jpeg/segments/App14Segment.java
@@ -41,11 +41,11 @@ public class App14Segment extends AppnSegment {
ADOBE_PREFIX = adobe;
}
- public App14Segment(int marker, byte[] segmentData) throws IOException {
+ public App14Segment(final int marker, final byte[] segmentData) throws IOException {
this(marker, segmentData.length, new ByteArrayInputStream(segmentData));
}
- public App14Segment(int marker, int markerLength, InputStream is) throws IOException {
+ public App14Segment(final int marker, final int markerLength, final InputStream is) throws IOException {
super(marker, markerLength, is);
}
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/main/java/org/apache/commons/imaging/formats/jpeg/segments/AppnSegment.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/imaging/formats/jpeg/segments/AppnSegment.java b/src/main/java/org/apache/commons/imaging/formats/jpeg/segments/AppnSegment.java
index bee3a41..c6f3bd6 100644
--- a/src/main/java/org/apache/commons/imaging/formats/jpeg/segments/AppnSegment.java
+++ b/src/main/java/org/apache/commons/imaging/formats/jpeg/segments/AppnSegment.java
@@ -23,7 +23,7 @@ import org.apache.commons.imaging.formats.jpeg.JpegConstants;
public class AppnSegment extends GenericSegment {
- public AppnSegment(int marker, int markerLength, InputStream is) throws IOException {
+ public AppnSegment(final int marker, final int markerLength, final InputStream is) throws IOException {
super(marker, markerLength, is);
}
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/main/java/org/apache/commons/imaging/formats/jpeg/segments/ComSegment.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/imaging/formats/jpeg/segments/ComSegment.java b/src/main/java/org/apache/commons/imaging/formats/jpeg/segments/ComSegment.java
index e211aca..5665f67 100644
--- a/src/main/java/org/apache/commons/imaging/formats/jpeg/segments/ComSegment.java
+++ b/src/main/java/org/apache/commons/imaging/formats/jpeg/segments/ComSegment.java
@@ -25,7 +25,7 @@ public class ComSegment extends GenericSegment {
super(marker, segmentData);
}
- public ComSegment(int marker, int markerLength, InputStream is) throws IOException {
+ public ComSegment(final int marker, final int markerLength, final InputStream is) throws IOException {
super(marker, markerLength, is);
}
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/main/java/org/apache/commons/imaging/formats/jpeg/segments/DhtSegment.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/imaging/formats/jpeg/segments/DhtSegment.java b/src/main/java/org/apache/commons/imaging/formats/jpeg/segments/DhtSegment.java
index 2f106d5..81cfd20 100644
--- a/src/main/java/org/apache/commons/imaging/formats/jpeg/segments/DhtSegment.java
+++ b/src/main/java/org/apache/commons/imaging/formats/jpeg/segments/DhtSegment.java
@@ -114,19 +114,19 @@ public class DhtSegment extends Segment {
}
- public int getHuffVal(int i) {
+ public int getHuffVal(final int i) {
return huffVal[i];
}
- public int getMinCode(int i) {
+ public int getMinCode(final int i) {
return minCode[i];
}
- public int getMaxCode(int i) {
+ public int getMaxCode(final int i) {
return maxCode[i];
}
- public int getValPtr(int i) {
+ public int getValPtr(final int i) {
return valPtr[i];
}
}
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/main/java/org/apache/commons/imaging/formats/jpeg/segments/GenericSegment.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/imaging/formats/jpeg/segments/GenericSegment.java b/src/main/java/org/apache/commons/imaging/formats/jpeg/segments/GenericSegment.java
index 3aa49c0..e557f71 100644
--- a/src/main/java/org/apache/commons/imaging/formats/jpeg/segments/GenericSegment.java
+++ b/src/main/java/org/apache/commons/imaging/formats/jpeg/segments/GenericSegment.java
@@ -26,7 +26,7 @@ import static org.apache.commons.imaging.common.BinaryFunctions.*;
public abstract class GenericSegment extends Segment {
private final byte[] segmentData;
- public GenericSegment(int marker, int markerLength, InputStream is) throws IOException {
+ public GenericSegment(final int marker, final int markerLength, final InputStream is) throws IOException {
super(marker, markerLength);
segmentData = readBytes("Segment Data", is, markerLength, "Invalid Segment: insufficient data");
@@ -66,7 +66,7 @@ public abstract class GenericSegment extends Segment {
* @see GenericSegment#getSegmentData()
* @return the bye in the segment's contents
*/
- protected byte getSegmentData(int offset) {
+ protected byte getSegmentData(final int offset) {
return segmentData[offset];
}
@@ -76,7 +76,7 @@ public abstract class GenericSegment extends Segment {
* @return the encoded bytes
* @throws UnsupportedEncodingException
*/
- public String getSegmentDataAsString(String encoding) throws UnsupportedEncodingException {
+ public String getSegmentDataAsString(final String encoding) throws UnsupportedEncodingException {
return new String(segmentData, encoding);
}
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/main/java/org/apache/commons/imaging/formats/jpeg/segments/UnknownSegment.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/imaging/formats/jpeg/segments/UnknownSegment.java b/src/main/java/org/apache/commons/imaging/formats/jpeg/segments/UnknownSegment.java
index c94f37c..e52f7ed 100644
--- a/src/main/java/org/apache/commons/imaging/formats/jpeg/segments/UnknownSegment.java
+++ b/src/main/java/org/apache/commons/imaging/formats/jpeg/segments/UnknownSegment.java
@@ -20,7 +20,7 @@ import java.io.IOException;
import java.io.InputStream;
public class UnknownSegment extends GenericSegment {
- public UnknownSegment(int marker, int markerLength, InputStream is) throws IOException {
+ public UnknownSegment(final int marker, final int markerLength, final InputStream is) throws IOException {
super(marker, markerLength, is);
}
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/main/java/org/apache/commons/imaging/formats/png/InterlaceMethod.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/imaging/formats/png/InterlaceMethod.java b/src/main/java/org/apache/commons/imaging/formats/png/InterlaceMethod.java
index c8d890d..c25cdd9 100644
--- a/src/main/java/org/apache/commons/imaging/formats/png/InterlaceMethod.java
+++ b/src/main/java/org/apache/commons/imaging/formats/png/InterlaceMethod.java
@@ -28,7 +28,7 @@ public enum InterlaceMethod {
private final boolean progressive;
- private InterlaceMethod(boolean progressive) {
+ private InterlaceMethod(final boolean progressive) {
this.progressive = progressive;
}
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/main/java/org/apache/commons/imaging/formats/png/PngColorType.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/imaging/formats/png/PngColorType.java b/src/main/java/org/apache/commons/imaging/formats/png/PngColorType.java
index 27a1ce6..4be7660 100644
--- a/src/main/java/org/apache/commons/imaging/formats/png/PngColorType.java
+++ b/src/main/java/org/apache/commons/imaging/formats/png/PngColorType.java
@@ -35,7 +35,7 @@ public enum PngColorType {
private final int samplesPerPixel;
private final int[] allowedBitDepths;
- PngColorType(int value, boolean greyscale, boolean alpha, int samplesPerPixel, int[] allowedBitDepths) {
+ PngColorType(final int value, final boolean greyscale, final boolean alpha, final int samplesPerPixel, final int[] allowedBitDepths) {
this.value = value;
this.greyscale = greyscale;
this.alpha = alpha;
@@ -59,11 +59,11 @@ public enum PngColorType {
return samplesPerPixel;
}
- boolean isBitDepthAllowed(int bitDepth) {
+ boolean isBitDepthAllowed(final int bitDepth) {
return Arrays.binarySearch(allowedBitDepths, bitDepth) >= 0;
}
- public static PngColorType getColorType(int value) {
+ public static PngColorType getColorType(final int value) {
for (PngColorType type : values()) {
if (type.value == value) {
return type;
@@ -73,7 +73,7 @@ public enum PngColorType {
return null;
}
- static PngColorType getColorType(boolean alpha, boolean grayscale) {
+ static PngColorType getColorType(final boolean alpha, final boolean grayscale) {
if (grayscale) {
if (alpha) {
return PngColorType.GREYSCALE_WITH_ALPHA;
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/main/java/org/apache/commons/imaging/formats/png/PngImageParser.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/imaging/formats/png/PngImageParser.java b/src/main/java/org/apache/commons/imaging/formats/png/PngImageParser.java
index be37af3..0dfa167 100644
--- a/src/main/java/org/apache/commons/imaging/formats/png/PngImageParser.java
+++ b/src/main/java/org/apache/commons/imaging/formats/png/PngImageParser.java
@@ -306,7 +306,7 @@ public class PngImageParser extends ImageParser {
// BinaryFileParser
// I may not have always preserved byte order correctly.
- private TransparencyFilter getTransparencyFilter(PngColorType pngColorType, PngChunk pngChunktRNS)
+ private TransparencyFilter getTransparencyFilter(final PngColorType pngColorType, final PngChunk pngChunktRNS)
throws ImageReadException, IOException {
switch (pngColorType) {
case GREYSCALE: // 1,2,4,8,16 Each pixel is a grayscale sample.
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/main/java/org/apache/commons/imaging/formats/png/PngWriter.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/imaging/formats/png/PngWriter.java b/src/main/java/org/apache/commons/imaging/formats/png/PngWriter.java
index 6edb2b8..2589a14 100644
--- a/src/main/java/org/apache/commons/imaging/formats/png/PngWriter.java
+++ b/src/main/java/org/apache/commons/imaging/formats/png/PngWriter.java
@@ -97,7 +97,7 @@ class PngWriter {
public ImageHeader(final int width, final int height, final byte bitDepth,
final PngColorType pngColorType, final byte compressionMethod, final byte filterMethod,
- InterlaceMethod interlaceMethod) {
+ final InterlaceMethod interlaceMethod) {
this.width = width;
this.height = height;
this.bitDepth = bitDepth;
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/main/java/org/apache/commons/imaging/formats/png/ScanExpediter.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/imaging/formats/png/ScanExpediter.java b/src/main/java/org/apache/commons/imaging/formats/png/ScanExpediter.java
index 073abb7..4d58f79 100644
--- a/src/main/java/org/apache/commons/imaging/formats/png/ScanExpediter.java
+++ b/src/main/java/org/apache/commons/imaging/formats/png/ScanExpediter.java
@@ -171,7 +171,7 @@ abstract class ScanExpediter {
}
}
- ScanlineFilter getScanlineFilter(FilterType filterType, int bytesPerPixel) throws ImageReadException {
+ ScanlineFilter getScanlineFilter(final FilterType filterType, final int bytesPerPixel) throws ImageReadException {
switch (filterType) {
case NONE:
return new ScanlineFilterNone();
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/main/java/org/apache/commons/imaging/formats/png/ScanExpediterInterlaced.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/imaging/formats/png/ScanExpediterInterlaced.java b/src/main/java/org/apache/commons/imaging/formats/png/ScanExpediterInterlaced.java
index 3def0e3..8e8a513 100644
--- a/src/main/java/org/apache/commons/imaging/formats/png/ScanExpediterInterlaced.java
+++ b/src/main/java/org/apache/commons/imaging/formats/png/ScanExpediterInterlaced.java
@@ -32,12 +32,12 @@ class ScanExpediterInterlaced extends ScanExpediter {
// private static final int Block_Height[] = { 8, 8, 4, 4, 2, 2, 1 };
// private static final int Block_Width[] = { 8, 4, 4, 2, 2, 1, 1 };
- ScanExpediterInterlaced(int width, int height, InputStream is,
- BufferedImage bi,
- PngColorType pngColorType, int bitDepth, int bitsPerPixel,
- PngChunkPlte fPNGChunkPLTE,
- GammaCorrection gammaCorrection,
- TransparencyFilter transparencyFilter)
+ ScanExpediterInterlaced(final int width, final int height, final InputStream is,
+ final BufferedImage bi,
+ final PngColorType pngColorType, final int bitDepth, final int bitsPerPixel,
+ final PngChunkPlte fPNGChunkPLTE,
+ final GammaCorrection gammaCorrection,
+ final TransparencyFilter transparencyFilter)
{
super(width, height, is, bi, pngColorType, bitDepth, bitsPerPixel,
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/main/java/org/apache/commons/imaging/formats/png/chunks/PngChunkIdat.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/imaging/formats/png/chunks/PngChunkIdat.java b/src/main/java/org/apache/commons/imaging/formats/png/chunks/PngChunkIdat.java
index 27dcaf7..171ecbd 100644
--- a/src/main/java/org/apache/commons/imaging/formats/png/chunks/PngChunkIdat.java
+++ b/src/main/java/org/apache/commons/imaging/formats/png/chunks/PngChunkIdat.java
@@ -18,7 +18,7 @@ package org.apache.commons.imaging.formats.png.chunks;
public class PngChunkIdat extends PngChunk {
- public PngChunkIdat(int length, int chunkType, int crc, byte[] bytes) {
+ public PngChunkIdat(final int length, final int chunkType, final int crc, final byte[] bytes) {
super(length, chunkType, crc, bytes);
}
}
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/main/java/org/apache/commons/imaging/formats/png/chunks/PngChunkIhdr.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/imaging/formats/png/chunks/PngChunkIhdr.java b/src/main/java/org/apache/commons/imaging/formats/png/chunks/PngChunkIhdr.java
index dda2282..cb5ffab 100644
--- a/src/main/java/org/apache/commons/imaging/formats/png/chunks/PngChunkIhdr.java
+++ b/src/main/java/org/apache/commons/imaging/formats/png/chunks/PngChunkIhdr.java
@@ -34,7 +34,7 @@ public class PngChunkIhdr extends PngChunk {
public final int filterMethod;
public final InterlaceMethod interlaceMethod;
- public PngChunkIhdr(int length, int chunkType, int crc, byte[] bytes) throws ImageReadException, IOException {
+ public PngChunkIhdr(final int length, final int chunkType, final int crc, final byte[] bytes) throws ImageReadException, IOException {
super(length, chunkType, crc, bytes);
final ByteArrayInputStream is = new ByteArrayInputStream(bytes);
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/main/java/org/apache/commons/imaging/formats/png/chunks/PngChunkPhys.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/imaging/formats/png/chunks/PngChunkPhys.java b/src/main/java/org/apache/commons/imaging/formats/png/chunks/PngChunkPhys.java
index 2e37dd3..2fd914d 100644
--- a/src/main/java/org/apache/commons/imaging/formats/png/chunks/PngChunkPhys.java
+++ b/src/main/java/org/apache/commons/imaging/formats/png/chunks/PngChunkPhys.java
@@ -26,7 +26,7 @@ public class PngChunkPhys extends PngChunk {
public final int pixelsPerUnitYAxis;
public final int unitSpecifier;
- public PngChunkPhys(int length, int chunkType, int crc, byte[] bytes) throws IOException {
+ public PngChunkPhys(final int length, final int chunkType, final int crc, final byte[] bytes) throws IOException {
super(length, chunkType, crc, bytes);
final ByteArrayInputStream is = new ByteArrayInputStream(bytes);
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/main/java/org/apache/commons/imaging/formats/png/chunks/PngChunkScal.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/imaging/formats/png/chunks/PngChunkScal.java b/src/main/java/org/apache/commons/imaging/formats/png/chunks/PngChunkScal.java
index 9a585e2..6de9c99 100644
--- a/src/main/java/org/apache/commons/imaging/formats/png/chunks/PngChunkScal.java
+++ b/src/main/java/org/apache/commons/imaging/formats/png/chunks/PngChunkScal.java
@@ -27,7 +27,7 @@ public class PngChunkScal extends PngChunk {
public final double unitsPerPixelYAxis;
public final int unitSpecifier;
- public PngChunkScal(int length, int chunkType, int crc, byte[] bytes)
+ public PngChunkScal(final int length, final int chunkType, final int crc, final byte[] bytes)
throws ImageReadException, IOException {
super(length, chunkType, crc, bytes);
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/main/java/org/apache/commons/imaging/formats/png/transparencyfilters/TransparencyFilter.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/imaging/formats/png/transparencyfilters/TransparencyFilter.java b/src/main/java/org/apache/commons/imaging/formats/png/transparencyfilters/TransparencyFilter.java
index 9a87759..ce04042 100644
--- a/src/main/java/org/apache/commons/imaging/formats/png/transparencyfilters/TransparencyFilter.java
+++ b/src/main/java/org/apache/commons/imaging/formats/png/transparencyfilters/TransparencyFilter.java
@@ -35,7 +35,7 @@ public abstract class TransparencyFilter extends BinaryFileParser {
/**
* @return a byte
*/
- public byte getByte(int offset) {
+ public byte getByte(final int offset) {
return bytes[offset];
}
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/main/java/org/apache/commons/imaging/formats/png/transparencyfilters/TransparencyFilterGrayscale.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/imaging/formats/png/transparencyfilters/TransparencyFilterGrayscale.java b/src/main/java/org/apache/commons/imaging/formats/png/transparencyfilters/TransparencyFilterGrayscale.java
index fc9281d..fb121c6 100644
--- a/src/main/java/org/apache/commons/imaging/formats/png/transparencyfilters/TransparencyFilterGrayscale.java
+++ b/src/main/java/org/apache/commons/imaging/formats/png/transparencyfilters/TransparencyFilterGrayscale.java
@@ -26,7 +26,7 @@ import static org.apache.commons.imaging.common.BinaryFunctions.*;
public class TransparencyFilterGrayscale extends TransparencyFilter {
private final int transparentColor;
- public TransparencyFilterGrayscale(byte[] bytes) throws IOException {
+ public TransparencyFilterGrayscale(final byte[] bytes) throws IOException {
super(bytes);
ByteArrayInputStream is = new ByteArrayInputStream(bytes);
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/main/java/org/apache/commons/imaging/formats/png/transparencyfilters/TransparencyFilterTrueColor.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/imaging/formats/png/transparencyfilters/TransparencyFilterTrueColor.java b/src/main/java/org/apache/commons/imaging/formats/png/transparencyfilters/TransparencyFilterTrueColor.java
index 31bc130..ecc42d9 100644
--- a/src/main/java/org/apache/commons/imaging/formats/png/transparencyfilters/TransparencyFilterTrueColor.java
+++ b/src/main/java/org/apache/commons/imaging/formats/png/transparencyfilters/TransparencyFilterTrueColor.java
@@ -26,7 +26,7 @@ import static org.apache.commons.imaging.common.BinaryFunctions.*;
public class TransparencyFilterTrueColor extends TransparencyFilter {
private final int transparentColor;
- public TransparencyFilterTrueColor(byte[] bytes) throws IOException {
+ public TransparencyFilterTrueColor(final byte[] bytes) throws IOException {
super(bytes);
ByteArrayInputStream is = new ByteArrayInputStream(bytes);
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/main/java/org/apache/commons/imaging/formats/pnm/PgmWriter.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/imaging/formats/pnm/PgmWriter.java b/src/main/java/org/apache/commons/imaging/formats/pnm/PgmWriter.java
index e46f672..caed6a7 100644
--- a/src/main/java/org/apache/commons/imaging/formats/pnm/PgmWriter.java
+++ b/src/main/java/org/apache/commons/imaging/formats/pnm/PgmWriter.java
@@ -27,7 +27,7 @@ class PgmWriter implements PnmWriter {
private final boolean rawbits;
- public PgmWriter(boolean rawbits) {
+ public PgmWriter(final boolean rawbits) {
this.rawbits = rawbits;
}
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/main/java/org/apache/commons/imaging/formats/pnm/PpmWriter.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/imaging/formats/pnm/PpmWriter.java b/src/main/java/org/apache/commons/imaging/formats/pnm/PpmWriter.java
index ef54269..146f2eb 100644
--- a/src/main/java/org/apache/commons/imaging/formats/pnm/PpmWriter.java
+++ b/src/main/java/org/apache/commons/imaging/formats/pnm/PpmWriter.java
@@ -27,7 +27,7 @@ class PpmWriter implements PnmWriter {
private final boolean rawbits;
- public PpmWriter(boolean rawbits) {
+ public PpmWriter(final boolean rawbits) {
this.rawbits = rawbits;
}
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/main/java/org/apache/commons/imaging/formats/psd/ImageResourceType.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/imaging/formats/psd/ImageResourceType.java b/src/main/java/org/apache/commons/imaging/formats/psd/ImageResourceType.java
index 6cf293b..5b330b5 100644
--- a/src/main/java/org/apache/commons/imaging/formats/psd/ImageResourceType.java
+++ b/src/main/java/org/apache/commons/imaging/formats/psd/ImageResourceType.java
@@ -127,13 +127,13 @@ class ImageResourceType {
public final String description;
- public ImageResourceType(int id, String description) {
+ public ImageResourceType(final int id, final String description) {
this.from = id;
this.to = id;
this.description = description;
}
- public ImageResourceType(int id, int id2, String description) {
+ public ImageResourceType(final int id, final int id2, final String description) {
this.from = id;
this.to = id2;
this.description = description;
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/main/java/org/apache/commons/imaging/formats/psd/PsdHeaderInfo.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/imaging/formats/psd/PsdHeaderInfo.java b/src/main/java/org/apache/commons/imaging/formats/psd/PsdHeaderInfo.java
index 0305980..6eac7c8 100644
--- a/src/main/java/org/apache/commons/imaging/formats/psd/PsdHeaderInfo.java
+++ b/src/main/java/org/apache/commons/imaging/formats/psd/PsdHeaderInfo.java
@@ -29,7 +29,7 @@ public class PsdHeaderInfo {
public final int depth;
public final int mode;
- public PsdHeaderInfo(int version, byte[] reserved, int channels, int rows, int columns, int depth, int mode) {
+ public PsdHeaderInfo(final int version, final byte[] reserved, final int channels, final int rows, final int columns, final int depth, final int mode) {
this.version = version;
this.reserved = reserved.clone();
this.channels = channels;
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/main/java/org/apache/commons/imaging/formats/tiff/TiffDirectory.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/imaging/formats/tiff/TiffDirectory.java b/src/main/java/org/apache/commons/imaging/formats/tiff/TiffDirectory.java
index 53be341..84cd1c8 100644
--- a/src/main/java/org/apache/commons/imaging/formats/tiff/TiffDirectory.java
+++ b/src/main/java/org/apache/commons/imaging/formats/tiff/TiffDirectory.java
@@ -64,7 +64,7 @@ public class TiffDirectory extends TiffElement {
private TiffImageData tiffImageData;
private JpegImageData jpegImageData;
- public TiffDirectory(int type, List<TiffField> entries, long offset, long nextDirectoryOffset) {
+ public TiffDirectory(final int type, final List<TiffField> entries, final long offset, final long nextDirectoryOffset) {
super(offset, TiffConstants.TIFF_DIRECTORY_HEADER_LENGTH
+ entries.size() * TiffConstants.TIFF_ENTRY_LENGTH
+ TiffConstants.TIFF_DIRECTORY_FOOTER_LENGTH);
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/main/java/org/apache/commons/imaging/formats/tiff/TiffImageData.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/imaging/formats/tiff/TiffImageData.java b/src/main/java/org/apache/commons/imaging/formats/tiff/TiffImageData.java
index 3b3d405..2996229 100644
--- a/src/main/java/org/apache/commons/imaging/formats/tiff/TiffImageData.java
+++ b/src/main/java/org/apache/commons/imaging/formats/tiff/TiffImageData.java
@@ -104,7 +104,7 @@ public abstract class TiffImageData {
return strips;
}
- public TiffElement.DataElement getImageData(int offset) {
+ public TiffElement.DataElement getImageData(final int offset) {
return strips[offset];
}
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/main/java/org/apache/commons/imaging/formats/tiff/TiffTags.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/imaging/formats/tiff/TiffTags.java b/src/main/java/org/apache/commons/imaging/formats/tiff/TiffTags.java
index 18e0969..339726c 100644
--- a/src/main/java/org/apache/commons/imaging/formats/tiff/TiffTags.java
+++ b/src/main/java/org/apache/commons/imaging/formats/tiff/TiffTags.java
@@ -110,7 +110,7 @@ final class TiffTags {
return map;
}
- static Integer getTagCount(int tag) {
+ static Integer getTagCount(final int tag) {
return TAG_COUNTS.get(tag);
}
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/main/java/org/apache/commons/imaging/formats/tiff/datareaders/ImageDataReader.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/imaging/formats/tiff/datareaders/ImageDataReader.java b/src/main/java/org/apache/commons/imaging/formats/tiff/datareaders/ImageDataReader.java
index 217e480..ab182e2 100644
--- a/src/main/java/org/apache/commons/imaging/formats/tiff/datareaders/ImageDataReader.java
+++ b/src/main/java/org/apache/commons/imaging/formats/tiff/datareaders/ImageDataReader.java
@@ -85,7 +85,7 @@ public abstract class ImageDataReader {
* @param size the size to check
* @return true if all the bits per sample entries are the same
*/
- protected boolean isHomogenous(int size) {
+ protected boolean isHomogenous(final int size) {
for (final int element : bitsPerSample) {
if (element != size) {
return false;
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/main/java/org/apache/commons/imaging/formats/tiff/photometricinterpreters/PhotometricInterpreter.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/imaging/formats/tiff/photometricinterpreters/PhotometricInterpreter.java b/src/main/java/org/apache/commons/imaging/formats/tiff/photometricinterpreters/PhotometricInterpreter.java
index 508fd61..c3c707c 100644
--- a/src/main/java/org/apache/commons/imaging/formats/tiff/photometricinterpreters/PhotometricInterpreter.java
+++ b/src/main/java/org/apache/commons/imaging/formats/tiff/photometricinterpreters/PhotometricInterpreter.java
@@ -40,7 +40,7 @@ public abstract class PhotometricInterpreter {
public abstract void interpretPixel(ImageBuilder imageBuilder,
int[] samples, int x, int y) throws ImageReadException, IOException;
- protected int getBitsPerSample(int offset) {
+ protected int getBitsPerSample(final int offset) {
return bitsPerSample[offset];
}
}
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/main/java/org/apache/commons/imaging/palette/ColorComponent.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/imaging/palette/ColorComponent.java b/src/main/java/org/apache/commons/imaging/palette/ColorComponent.java
index be88d79..77ac38b 100644
--- a/src/main/java/org/apache/commons/imaging/palette/ColorComponent.java
+++ b/src/main/java/org/apache/commons/imaging/palette/ColorComponent.java
@@ -24,11 +24,11 @@ enum ColorComponent {
private final int shift;
- private ColorComponent(int shift) {
+ private ColorComponent(final int shift) {
this.shift = shift;
}
- public int argbComponent(int argb) {
+ public int argbComponent(final int argb) {
return (argb >> shift) & 0xff;
}
}
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/test/java/org/apache/commons/imaging/ImagingGuessFormatTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/imaging/ImagingGuessFormatTest.java b/src/test/java/org/apache/commons/imaging/ImagingGuessFormatTest.java
index b0be8bc..a15a317 100644
--- a/src/test/java/org/apache/commons/imaging/ImagingGuessFormatTest.java
+++ b/src/test/java/org/apache/commons/imaging/ImagingGuessFormatTest.java
@@ -72,7 +72,7 @@ public class ImagingGuessFormatTest extends ImagingTest {
);
}
- public ImagingGuessFormatTest(ImageFormats expectedFormat, String pathToFile) {
+ public ImagingGuessFormatTest(final ImageFormats expectedFormat, final String pathToFile) {
this.expectedFormat = expectedFormat;
this.pathToFile = pathToFile;
}
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/test/java/org/apache/commons/imaging/common/RationalNumberTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/imaging/common/RationalNumberTest.java b/src/test/java/org/apache/commons/imaging/common/RationalNumberTest.java
index c3d4d21..a1f1412 100644
--- a/src/test/java/org/apache/commons/imaging/common/RationalNumberTest.java
+++ b/src/test/java/org/apache/commons/imaging/common/RationalNumberTest.java
@@ -108,7 +108,7 @@ public class RationalNumberTest extends ImagingTest {
);
}
- public RationalNumberTest(double testValue) {
+ public RationalNumberTest(final double testValue) {
this.testValue = testValue;
}
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/test/java/org/apache/commons/imaging/common/bytesource/ByteSourceDataTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/imaging/common/bytesource/ByteSourceDataTest.java b/src/test/java/org/apache/commons/imaging/common/bytesource/ByteSourceDataTest.java
index f4fdddb..0cb154c 100644
--- a/src/test/java/org/apache/commons/imaging/common/bytesource/ByteSourceDataTest.java
+++ b/src/test/java/org/apache/commons/imaging/common/bytesource/ByteSourceDataTest.java
@@ -43,7 +43,7 @@ public class ByteSourceDataTest extends ByteSourceTest {
return Arrays.asList(getTestByteArrays());
}
- public ByteSourceDataTest(byte[] testByteArray) {
+ public ByteSourceDataTest(final byte[] testByteArray) {
this.testByteArray = testByteArray;
}
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/test/java/org/apache/commons/imaging/common/bytesource/ByteSourceImageTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/imaging/common/bytesource/ByteSourceImageTest.java b/src/test/java/org/apache/commons/imaging/common/bytesource/ByteSourceImageTest.java
index d296eca..0593640 100644
--- a/src/test/java/org/apache/commons/imaging/common/bytesource/ByteSourceImageTest.java
+++ b/src/test/java/org/apache/commons/imaging/common/bytesource/ByteSourceImageTest.java
@@ -54,7 +54,7 @@ public class ByteSourceImageTest extends ByteSourceTest {
return getTestImages();
}
- public ByteSourceImageTest(File imageFile) {
+ public ByteSourceImageTest(final File imageFile) {
this.imageFile = imageFile;
}
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/test/java/org/apache/commons/imaging/formats/bmp/BmpReadTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/imaging/formats/bmp/BmpReadTest.java b/src/test/java/org/apache/commons/imaging/formats/bmp/BmpReadTest.java
index 43c6348..7327cf7 100644
--- a/src/test/java/org/apache/commons/imaging/formats/bmp/BmpReadTest.java
+++ b/src/test/java/org/apache/commons/imaging/formats/bmp/BmpReadTest.java
@@ -44,7 +44,7 @@ public class BmpReadTest extends BmpBaseTest {
return getBmpImages();
}
- public BmpReadTest(File imageFile) {
+ public BmpReadTest(final File imageFile) {
this.imageFile = imageFile;
}
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/test/java/org/apache/commons/imaging/formats/dcx/DcxReadTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/imaging/formats/dcx/DcxReadTest.java b/src/test/java/org/apache/commons/imaging/formats/dcx/DcxReadTest.java
index 8201880..d0484fa 100644
--- a/src/test/java/org/apache/commons/imaging/formats/dcx/DcxReadTest.java
+++ b/src/test/java/org/apache/commons/imaging/formats/dcx/DcxReadTest.java
@@ -40,7 +40,7 @@ public class DcxReadTest extends DcxBaseTest {
return getDcxImages();
}
- public DcxReadTest(File imageFile) {
+ public DcxReadTest(final File imageFile) {
this.imageFile = imageFile;
}
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/test/java/org/apache/commons/imaging/formats/gif/GifReadTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/imaging/formats/gif/GifReadTest.java b/src/test/java/org/apache/commons/imaging/formats/gif/GifReadTest.java
index ae30b9e..3ab4ba5 100644
--- a/src/test/java/org/apache/commons/imaging/formats/gif/GifReadTest.java
+++ b/src/test/java/org/apache/commons/imaging/formats/gif/GifReadTest.java
@@ -40,7 +40,7 @@ public class GifReadTest extends GifBaseTest {
return getGifImages();
}
- public GifReadTest(File imageFile) {
+ public GifReadTest(final File imageFile) {
this.imageFile = imageFile;
}
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/test/java/org/apache/commons/imaging/formats/icns/IcnsReadTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/imaging/formats/icns/IcnsReadTest.java b/src/test/java/org/apache/commons/imaging/formats/icns/IcnsReadTest.java
index adcd6d1..ea6ff3c 100644
--- a/src/test/java/org/apache/commons/imaging/formats/icns/IcnsReadTest.java
+++ b/src/test/java/org/apache/commons/imaging/formats/icns/IcnsReadTest.java
@@ -42,7 +42,7 @@ public class IcnsReadTest extends IcnsBaseTest {
return getIcnsImages();
}
- public IcnsReadTest(File imageFile) {
+ public IcnsReadTest(final File imageFile) {
this.imageFile = imageFile;
}
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/test/java/org/apache/commons/imaging/formats/ico/IcoReadTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/imaging/formats/ico/IcoReadTest.java b/src/test/java/org/apache/commons/imaging/formats/ico/IcoReadTest.java
index 3230894..dbb7325 100644
--- a/src/test/java/org/apache/commons/imaging/formats/ico/IcoReadTest.java
+++ b/src/test/java/org/apache/commons/imaging/formats/ico/IcoReadTest.java
@@ -40,7 +40,7 @@ public class IcoReadTest extends IcoBaseTest {
return getIcoImages();
}
- public IcoReadTest(File imageFile) {
+ public IcoReadTest(final File imageFile) {
this.imageFile = imageFile;
}
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/test/java/org/apache/commons/imaging/formats/jpeg/JpegReadTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/imaging/formats/jpeg/JpegReadTest.java b/src/test/java/org/apache/commons/imaging/formats/jpeg/JpegReadTest.java
index 35754e7..fd9f133 100644
--- a/src/test/java/org/apache/commons/imaging/formats/jpeg/JpegReadTest.java
+++ b/src/test/java/org/apache/commons/imaging/formats/jpeg/JpegReadTest.java
@@ -46,7 +46,7 @@ public class JpegReadTest extends JpegBaseTest {
return getJpegImages();
}
- public JpegReadTest(File imageFile) {
+ public JpegReadTest(final File imageFile) {
this.imageFile = imageFile;
}
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/ExifDumpTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/ExifDumpTest.java b/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/ExifDumpTest.java
index 7fa78f9..f904433 100644
--- a/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/ExifDumpTest.java
+++ b/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/ExifDumpTest.java
@@ -45,7 +45,7 @@ public class ExifDumpTest extends ExifBaseTest {
return getImagesWithExifData();
}
- public ExifDumpTest(File imageFile) {
+ public ExifDumpTest(final File imageFile) {
this.imageFile = imageFile;
}
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/GpsTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/GpsTest.java b/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/GpsTest.java
index b2c34c7..4be530b 100644
--- a/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/GpsTest.java
+++ b/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/GpsTest.java
@@ -41,7 +41,7 @@ public class GpsTest extends ExifBaseTest {
return getImagesWithExifData();
}
- public GpsTest(File imageFile) {
+ public GpsTest(final File imageFile) {
this.imageFile = imageFile;
}
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/MakerNoteFieldTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/MakerNoteFieldTest.java b/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/MakerNoteFieldTest.java
index c89005c..6ba57d3 100644
--- a/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/MakerNoteFieldTest.java
+++ b/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/MakerNoteFieldTest.java
@@ -28,7 +28,7 @@ import org.apache.commons.imaging.util.Debug;
public class MakerNoteFieldTest extends SpecificExifTagTest {
- public MakerNoteFieldTest(File imageFile) {
+ public MakerNoteFieldTest(final File imageFile) {
super(imageFile);
}
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/MicrosoftTagTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/MicrosoftTagTest.java b/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/MicrosoftTagTest.java
index b765e32..9333c96 100644
--- a/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/MicrosoftTagTest.java
+++ b/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/MicrosoftTagTest.java
@@ -75,7 +75,7 @@ public class MicrosoftTagTest extends ExifBaseTest {
}
}
- private byte[] cleanImage(File imageWithExif) throws ImageReadException, ImageWriteException, IOException {
+ private byte[] cleanImage(final File imageWithExif) throws ImageReadException, ImageWriteException, IOException {
// Windows doesn't show XP tags if same-meaning tags exist in IPTC or XMP. Remove them:
final ByteArrayOutputStream noXmp = new ByteArrayOutputStream();
new JpegXmpRewriter().removeXmpXml(imageWithExif, noXmp);
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/SpecificExifTagTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/SpecificExifTagTest.java b/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/SpecificExifTagTest.java
index 728f81c..30d2102 100644
--- a/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/SpecificExifTagTest.java
+++ b/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/SpecificExifTagTest.java
@@ -46,7 +46,7 @@ public abstract class SpecificExifTagTest extends ExifBaseTest {
return getImagesWithExifData();
}
- public SpecificExifTagTest(File imageFile) {
+ public SpecificExifTagTest(final File imageFile) {
this.imageFile = imageFile;
}
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/TextFieldTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/TextFieldTest.java b/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/TextFieldTest.java
index d1d13e5..a6f8023 100644
--- a/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/TextFieldTest.java
+++ b/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/TextFieldTest.java
@@ -31,7 +31,7 @@ import org.junit.Assert;
public class TextFieldTest extends SpecificExifTagTest {
- public TextFieldTest(File imageFile) {
+ public TextFieldTest(final File imageFile) {
super(imageFile);
}
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/WriteExifMetadataExampleTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/WriteExifMetadataExampleTest.java b/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/WriteExifMetadataExampleTest.java
index 09f4664..5cd48f2 100644
--- a/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/WriteExifMetadataExampleTest.java
+++ b/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/WriteExifMetadataExampleTest.java
@@ -36,7 +36,7 @@ public class WriteExifMetadataExampleTest extends ExifBaseTest {
return getJpegImages();
}
- public WriteExifMetadataExampleTest(File imageFile) {
+ public WriteExifMetadataExampleTest(final File imageFile) {
this.imageFile = imageFile;
}
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/test/java/org/apache/commons/imaging/formats/jpeg/iptc/IptcAddTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/imaging/formats/jpeg/iptc/IptcAddTest.java b/src/test/java/org/apache/commons/imaging/formats/jpeg/iptc/IptcAddTest.java
index b467fc7..5c7128c 100644
--- a/src/test/java/org/apache/commons/imaging/formats/jpeg/iptc/IptcAddTest.java
+++ b/src/test/java/org/apache/commons/imaging/formats/jpeg/iptc/IptcAddTest.java
@@ -49,7 +49,7 @@ public class IptcAddTest extends IptcBaseTest {
return getJpegImages();
}
- public IptcAddTest(File imageFile) {
+ public IptcAddTest(final File imageFile) {
this.imageFile = imageFile;
}
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/test/java/org/apache/commons/imaging/formats/jpeg/iptc/IptcDumpTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/imaging/formats/jpeg/iptc/IptcDumpTest.java b/src/test/java/org/apache/commons/imaging/formats/jpeg/iptc/IptcDumpTest.java
index 4e17f40..e19dddd 100644
--- a/src/test/java/org/apache/commons/imaging/formats/jpeg/iptc/IptcDumpTest.java
+++ b/src/test/java/org/apache/commons/imaging/formats/jpeg/iptc/IptcDumpTest.java
@@ -44,7 +44,7 @@ public class IptcDumpTest extends IptcBaseTest {
return getImagesWithIptcData();
}
- public IptcDumpTest(File imageFile) {
+ public IptcDumpTest(final File imageFile) {
this.imageFile = imageFile;
}
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/test/java/org/apache/commons/imaging/formats/jpeg/iptc/IptcFullDiscardTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/imaging/formats/jpeg/iptc/IptcFullDiscardTest.java b/src/test/java/org/apache/commons/imaging/formats/jpeg/iptc/IptcFullDiscardTest.java
index f4a8e22..faafec3 100644
--- a/src/test/java/org/apache/commons/imaging/formats/jpeg/iptc/IptcFullDiscardTest.java
+++ b/src/test/java/org/apache/commons/imaging/formats/jpeg/iptc/IptcFullDiscardTest.java
@@ -29,7 +29,7 @@ import org.junit.Test;
public class IptcFullDiscardTest {
- private byte[] addMetaData(byte[] bytes) throws Exception {
+ private byte[] addMetaData(final byte[] bytes) throws Exception {
IptcRecord record = new IptcRecord(IptcTypes.KEYWORDS, "meta; data");
PhotoshopApp13Data data = new PhotoshopApp13Data(Collections.singletonList(record), Collections.<IptcBlock> emptyList());
ByteArrayOutputStream byteArrayOutputStream = new ByteArrayOutputStream();
@@ -46,7 +46,7 @@ public class IptcFullDiscardTest {
return byteArrayOutputStream.toByteArray();
}
- private byte[] removeMetaData(byte[] bytes, boolean removeApp13Segment) throws Exception {
+ private byte[] removeMetaData(final byte[] bytes, final boolean removeApp13Segment) throws Exception {
ByteArrayOutputStream byteArrayOutputStream = new ByteArrayOutputStream();
new JpegIptcRewriter().removeIPTC(bytes, byteArrayOutputStream, removeApp13Segment);
return byteArrayOutputStream.toByteArray();
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/test/java/org/apache/commons/imaging/formats/jpeg/iptc/IptcUpdateTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/imaging/formats/jpeg/iptc/IptcUpdateTest.java b/src/test/java/org/apache/commons/imaging/formats/jpeg/iptc/IptcUpdateTest.java
index 4f17c8d..863435a 100644
--- a/src/test/java/org/apache/commons/imaging/formats/jpeg/iptc/IptcUpdateTest.java
+++ b/src/test/java/org/apache/commons/imaging/formats/jpeg/iptc/IptcUpdateTest.java
@@ -51,7 +51,7 @@ public class IptcUpdateTest extends IptcBaseTest {
return getImagesWithIptcData();
}
- public IptcUpdateTest(File imageFile) {
+ public IptcUpdateTest(final File imageFile) {
this.imageFile = imageFile;
}
@@ -80,7 +80,7 @@ public class IptcUpdateTest extends IptcBaseTest {
|| outMetadata.getItems().size() == 0);
}
- public File removeIptc(ByteSource byteSource) throws Exception {
+ public File removeIptc(final ByteSource byteSource) throws Exception {
final File noIptcFile = createTempFile(imageFile.getName() + ".iptc.remove.", ".jpg");
try (OutputStream os = new BufferedOutputStream(new FileOutputStream(noIptcFile))) {
@@ -160,7 +160,7 @@ public class IptcUpdateTest extends IptcBaseTest {
assertTrue(outMetadata.getItems().size() == 2);
}
- public File writeIptc(ByteSource byteSource, PhotoshopApp13Data newData) throws IOException, ImageReadException, ImageWriteException {
+ public File writeIptc(final ByteSource byteSource, final PhotoshopApp13Data newData) throws IOException, ImageReadException, ImageWriteException {
final File updated = createTempFile(imageFile.getName()
+ ".iptc.update.", ".jpg");
try (FileOutputStream fos = new FileOutputStream(updated);
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/test/java/org/apache/commons/imaging/formats/jpeg/xmp/JpegXmpDumpTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/imaging/formats/jpeg/xmp/JpegXmpDumpTest.java b/src/test/java/org/apache/commons/imaging/formats/jpeg/xmp/JpegXmpDumpTest.java
index 96e9c08..53d1a0c 100644
--- a/src/test/java/org/apache/commons/imaging/formats/jpeg/xmp/JpegXmpDumpTest.java
+++ b/src/test/java/org/apache/commons/imaging/formats/jpeg/xmp/JpegXmpDumpTest.java
@@ -41,7 +41,7 @@ public class JpegXmpDumpTest extends JpegXmpBaseTest {
return getImagesWithXmpData();
}
- public JpegXmpDumpTest(File imageFile) {
+ public JpegXmpDumpTest(final File imageFile) {
this.imageFile = imageFile;
}
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/test/java/org/apache/commons/imaging/formats/jpeg/xmp/JpegXmpRewriteTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/imaging/formats/jpeg/xmp/JpegXmpRewriteTest.java b/src/test/java/org/apache/commons/imaging/formats/jpeg/xmp/JpegXmpRewriteTest.java
index 74e0b42..1e3d1ce 100644
--- a/src/test/java/org/apache/commons/imaging/formats/jpeg/xmp/JpegXmpRewriteTest.java
+++ b/src/test/java/org/apache/commons/imaging/formats/jpeg/xmp/JpegXmpRewriteTest.java
@@ -46,7 +46,7 @@ public class JpegXmpRewriteTest extends JpegXmpBaseTest {
return getImagesWithXmpData();
}
- public JpegXmpRewriteTest(File imageFile) {
+ public JpegXmpRewriteTest(final File imageFile) {
this.imageFile = imageFile;
}
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/test/java/org/apache/commons/imaging/palette/PaletteQuantizationTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/imaging/palette/PaletteQuantizationTest.java b/src/test/java/org/apache/commons/imaging/palette/PaletteQuantizationTest.java
index 626a001..2b0638d 100644
--- a/src/test/java/org/apache/commons/imaging/palette/PaletteQuantizationTest.java
+++ b/src/test/java/org/apache/commons/imaging/palette/PaletteQuantizationTest.java
@@ -63,7 +63,7 @@ public class PaletteQuantizationTest extends ImagingTest {
checkPaletteDetails(rainbowImage, 2, 2);
}
- private void checkPaletteDetails(BufferedImage image, final int limit, final int expectedSize) throws ImageWriteException {
+ private void checkPaletteDetails(final BufferedImage image, final int limit, final int expectedSize) throws ImageWriteException {
PaletteFactory paletteFactory = new PaletteFactory();
Palette palette;
@@ -103,7 +103,7 @@ public class PaletteQuantizationTest extends ImagingTest {
}
}
- private void checkUniqueColors(BufferedImage src, Palette palette) throws ImageWriteException {
+ private void checkUniqueColors(final BufferedImage src, final Palette palette) throws ImageWriteException {
BufferedImage dst = new BufferedImage(src.getWidth(), src.getHeight(), BufferedImage.TYPE_INT_RGB);
dst.getGraphics().drawImage(src, 0, 0, src.getWidth(), src.getHeight(), null);
Dithering.applyFloydSteinbergDithering(dst, palette);
@@ -111,7 +111,7 @@ public class PaletteQuantizationTest extends ImagingTest {
assertEquals(palette.length(), ditheredPalette.length());
}
- private void checkPixelsAreIdentical(BufferedImage src, Palette palette) throws ImageWriteException {
+ private void checkPixelsAreIdentical(final BufferedImage src, final Palette palette) throws ImageWriteException {
BufferedImage dst = new BufferedImage(src.getWidth(), src.getHeight(), BufferedImage.TYPE_INT_RGB);
dst.getGraphics().drawImage(src, 0, 0, src.getWidth(), src.getHeight(), null);
Dithering.applyFloydSteinbergDithering(dst, palette);
http://git-wip-us.apache.org/repos/asf/commons-imaging/blob/56e0133a/src/test/java/org/apache/commons/imaging/roundtrip/BitmapRoundtripTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/imaging/roundtrip/BitmapRoundtripTest.java b/src/test/java/org/apache/commons/imaging/roundtrip/BitmapRoundtripTest.java
index 6c0a049..dd94354 100644
--- a/src/test/java/org/apache/commons/imaging/roundtrip/BitmapRoundtripTest.java
+++ b/src/test/java/org/apache/commons/imaging/roundtrip/BitmapRoundtripTest.java
@@ -44,7 +44,7 @@ public class BitmapRoundtripTest extends RoundtripBase {
public static FormatInfo[] formatInfos = FormatInfo.READ_WRITE_FORMATS;
@Theory
- public void testBitmapRoundtrip(BufferedImage testImage, FormatInfo formatInfo) throws Exception {
+ public void testBitmapRoundtrip(final BufferedImage testImage, final FormatInfo formatInfo) throws Exception {
roundtrip(formatInfo, testImage, "bitmap", true);
}
}