You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by "Eric Olander (JIRA)" <ji...@apache.org> on 2015/01/22 23:20:34 UTC

[jira] [Commented] (KAFKA-1818) Code cleanup in ReplicationUtils including unit test

    [ https://issues.apache.org/jira/browse/KAFKA-1818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14288328#comment-14288328 ] 

Eric Olander commented on KAFKA-1818:
-------------------------------------

In review: https://reviews.apache.org/r/29840/

> Code cleanup in ReplicationUtils including unit test
> ----------------------------------------------------
>
>                 Key: KAFKA-1818
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1818
>             Project: Kafka
>          Issue Type: Improvement
>          Components: replication
>    Affects Versions: 0.8.1.1
>            Reporter: Eric Olander
>            Assignee: Neha Narkhede
>            Priority: Trivial
>         Attachments: 0001-KAFKA-1818-clean-up-code-to-more-idiomatic-scala-usa.patch
>
>
> Code in getLeaderIsrAndEpochForPartition() and parseLeaderAndIsr() was essentially reimplementing the flatMap function on the Option type.  The attached patch refactors that code to more idiomatic Scala and provides a unit test over the affected code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)