You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by purplecabbage <gi...@git.apache.org> on 2016/03/11 22:48:52 UTC
[GitHub] cordova-ios pull request: Expose supportedOrientations method
GitHub user purplecabbage opened a pull request:
https://github.com/apache/cordova-ios/pull/203
Expose supportedOrientations method
Expose supportedOrientations getter/setter so native code can override the current behavior.
I think this would require a minor version bump only, as we are exposing a new (native) API, but not breaking any existing functionality.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/purplecabbage/cordova-ios SupportedOrientations
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/203.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #203
----
commit 7b0a28323d66e13de3f545848ef4b1a61157b665
Author: Jesse MacFadyen <pu...@gmail.com>
Date: 2016-03-11T21:46:45Z
Expose supportedOrientations methods so native code can override the current behavior
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: Expose supportedOrientations method
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-ios/pull/203#issuecomment-218004990
Filed: https://issues.apache.org/jira/browse/CB-11238
Can you prefix the PR title with "CB-11238"? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: Expose supportedOrientations method
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-ios/pull/203#issuecomment-195603847
This pull-request is somewhat less important now that I have found a way to do this with the existing code.
This can still be added to a future minor release so that in the future this accessor is exposed publicly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request #203: CB-11238 Expose supportedOrientations method
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-ios/pull/203
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org