[Bug 54121] add a option to disable checkThreadLocalMapForLeaks

[bu...@apache.org]

https://issues.apache.org/bugzilla/show_bug.cgi?id=54121

Alex Panchenko <al...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|INVALID                     |---

--- Comment #3 from Alex Panchenko <al...@gmail.com> ---
I would like to reopen this bug, IMHO reporting this does not help at all as
most of the time it is reported for external libraries, so the only result is
wasted disk space.

I believe everybody just restarts the tomcat process after updating their web
applications - the most reliable approach.

E.g. we have the following in logs:

Dec 18, 2014 1:58:10 PM org.apache.catalina.loader.WebappClassLoader
checkThreadLocalMapForLeaks
SEVERE: The web application [] created a ThreadLocal with key of type
[com.google.common.escape.Platform$1] (value
[com.google.common.escape.Platform$1@3fae9355]) and a value of type [char[]]
(value [[C@27d94f22]) but failed to remove it when the web application was
stopped. Threads are going to be renewed over time to try and avoid a probable
memory leak.

this is just char[1024] reused and I am fine with that.

And a few similar cases from other libraries, which we can't fix or stop using
at the moment.

I wonder if this warning is reported in each web project bugtracker, e.g.
https://code.google.com/p/google-gson/issues/detail?id=402
https://www.jfrog.com/jira/browse/RTFACT-5567
https://confluence.atlassian.com/display/STASHKB/Harmless+checkThreadLocalMapForLeaks+messages+on+catalina.out

I see 2 possible ways to fix this message which we don't care about:
- an option to disable it per webapp/server
- reporting it as INFO/WARN so the message can be suppressed in logging
configuration

What do you think of this?

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org