[GitHub] [arrow] kou commented on a diff in pull request #14585: ARROW-17884: [C++] Add Intel®-IAA/QPL-based Parquet RLE Decode

[GitBox <gi...@apache.org>]

kou commented on code in PR #14585:
URL: https://github.com/apache/arrow/pull/14585#discussion_r1030859062


##########
cpp/CMakeLists.txt:
##########
@@ -347,6 +347,12 @@ if(UNIX)
   add_custom_target(iwyu-all ${BUILD_SUPPORT_DIR}/iwyu/iwyu.sh all)
 endif(UNIX)
 
+if(ENABLE_QPL)
+  add_subdirectory(build-support/qpl-cmake)
+  add_definitions(-DENABLE_QPL_ANALYSIS)

Review Comment:
   We want to use a CMake target instead of `add_definitions()` like other third party dependency.



##########
cpp/cmake_modules/DefineOptions.cmake:
##########
@@ -375,6 +375,8 @@ takes precedence over ccache if a storage backend is configured" ON)
 
   define_option(ARROW_PLASMA "Build the plasma object store along with Arrow" OFF)
 
+  define_option(ENABLE_QPL "Enable Intel® Query Processing Library" OFF)

Review Comment:
   We use `ARROW_${FEATURE}` for option name.



##########
cpp/CMakeLists.txt:
##########
@@ -528,6 +534,12 @@ message(STATUS "CMAKE_CXX_FLAGS: ${CMAKE_CXX_FLAGS}")
 include_directories(${CMAKE_CURRENT_BINARY_DIR}/src)
 include_directories(src)
 
+if(ENABLE_QPL)
+  set (QPL_PROJECT_DIR "${PROJECT_SOURCE_DIR}/submodules/qpl")
+  include_directories(${QPL_PROJECT_DIR})

Review Comment:
   We want to use a CMake target instead of `include_directories()` like other third party dependency.



##########
cpp/src/arrow/util/qpl_job_pool.cc:
##########
@@ -0,0 +1,118 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include <exception>

Review Comment:
   We use `arrow::Status` and `arrow::Result` instead of C++ exception to report an error.



##########
cpp/src/arrow/util/qpl_job_pool.cc:
##########
@@ -0,0 +1,118 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include <exception>
+#include "parquet/exception.h"

Review Comment:
   We don't want to depend on `cpp/src/parquet/` in `cpp/src/arrow/util/`.



##########
cpp/CMakeLists.txt:
##########
@@ -347,6 +347,12 @@ if(UNIX)
   add_custom_target(iwyu-all ${BUILD_SUPPORT_DIR}/iwyu/iwyu.sh all)
 endif(UNIX)
 
+if(ENABLE_QPL)
+  add_subdirectory(build-support/qpl-cmake)

Review Comment:
   We want to use `externalproject_add()` in `cpp/cmake_modules/ThirdpartyToolchain.cmake` instead of `add_subdirectory()` like other third party dependency.



##########
.gitmodules:
##########
@@ -4,3 +4,6 @@
 [submodule "testing"]
 	path = testing
 	url = https://github.com/apache/arrow-testing
+[submodule "cpp/submodules/qpl"]
+	path = cpp/submodules/qpl
+	url = https://github.com/intel/qpl.git

Review Comment:
   We don't want to use submodule for a third party dependency.
   Could you use `externalproject_add()` like other third party dependencies?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org