You are viewing a plain text version of this content. The canonical link for it is here.
Posted to xbean-scm@geronimo.apache.org by db...@apache.org on 2008/05/29 04:08:46 UTC

svn commit: r661180 - in /geronimo/xbean/trunk/xbean-finder: pom.xml src/main/java/org/apache/xbean/finder/ClassFinder.java

Author: dblevins
Date: Wed May 28 19:08:46 2008
New Revision: 661180

URL: http://svn.apache.org/viewvc?rev=661180&view=rev
Log:
Upgrade to ASM 3.1 and enable class reading speed boosts

Modified:
    geronimo/xbean/trunk/xbean-finder/pom.xml
    geronimo/xbean/trunk/xbean-finder/src/main/java/org/apache/xbean/finder/ClassFinder.java

Modified: geronimo/xbean/trunk/xbean-finder/pom.xml
URL: http://svn.apache.org/viewvc/geronimo/xbean/trunk/xbean-finder/pom.xml?rev=661180&r1=661179&r2=661180&view=diff
==============================================================================
--- geronimo/xbean/trunk/xbean-finder/pom.xml (original)
+++ geronimo/xbean/trunk/xbean-finder/pom.xml Wed May 28 19:08:46 2008
@@ -37,13 +37,13 @@
         <dependency>
            <groupId>asm</groupId>
            <artifactId>asm</artifactId>
-           <version>2.2.3</version>
+           <version>3.1</version>
            <scope>provided</scope>
         </dependency>
         <dependency>
            <groupId>asm</groupId>
            <artifactId>asm-commons</artifactId>
-           <version>2.2.3</version>
+           <version>3.1</version>
            <scope>provided</scope>
         </dependency>
     </dependencies>

Modified: geronimo/xbean/trunk/xbean-finder/src/main/java/org/apache/xbean/finder/ClassFinder.java
URL: http://svn.apache.org/viewvc/geronimo/xbean/trunk/xbean-finder/src/main/java/org/apache/xbean/finder/ClassFinder.java?rev=661180&r1=661179&r2=661180&view=diff
==============================================================================
--- geronimo/xbean/trunk/xbean-finder/src/main/java/org/apache/xbean/finder/ClassFinder.java (original)
+++ geronimo/xbean/trunk/xbean-finder/src/main/java/org/apache/xbean/finder/ClassFinder.java Wed May 28 19:08:46 2008
@@ -65,6 +65,7 @@
 
     private final ClassLoader classLoader;
     private final List<String> classesNotLoaded = new ArrayList<String>();
+    private final int ASM_FLAGS = ClassReader.SKIP_CODE + ClassReader.SKIP_DEBUG + ClassReader.SKIP_FRAMES;
 
     /**
      * Creates a ClassFinder that will search the urls in the specified classloader
@@ -674,7 +675,7 @@
                 InputStream in = resource.openStream();
                 try {
                     ClassReader classReader = new ClassReader(in);
-                    classReader.accept(new InfoBuildingVisitor(), true);
+                    classReader.accept(new InfoBuildingVisitor(), ASM_FLAGS);
                 } finally {
                     in.close();
                 }