You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "vincev (via GitHub)" <gi...@apache.org> on 2023/02/14 14:41:47 UTC

[GitHub] [arrow-datafusion] vincev opened a new pull request, #5282: Prevent optimizer from pruning UnnestExec.

vincev opened a new pull request, #5282:
URL: https://github.com/apache/arrow-datafusion/pull/5282

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #5281.
   
   # Rationale for this change
   
   When running an aggregate count on an unnested column the aggregate_statistics optimizer removes UnnestExec from the ExecutionPlan.
   
   # What changes are included in this PR?
   
   `UnnestExec::statistics` returns default statistics instead of returning child statistics.
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   # Are these changes tested?
   
   Tests for the fix is [here](https://github.com/vincev/arrow-datafusion/blob/047803a879e7af7e894280eb9c51edb5f931c249/datafusion/core/tests/dataframe.rs#L640)
   
   # Are there any user-facing changes?
   
   Aggregate count on unnested column now works as expected.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb merged pull request #5282: Prevent optimizer from pruning UnnestExec.

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #5282:
URL: https://github.com/apache/arrow-datafusion/pull/5282


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] vincev commented on pull request #5282: Prevent optimizer from pruning UnnestExec.

Posted by "vincev (via GitHub)" <gi...@apache.org>.
vincev commented on PR #5282:
URL: https://github.com/apache/arrow-datafusion/pull/5282#issuecomment-1432675082

   Thank you @jackwener, @alamb 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] ursabot commented on pull request #5282: Prevent optimizer from pruning UnnestExec.

Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #5282:
URL: https://github.com/apache/arrow-datafusion/pull/5282#issuecomment-1433554934

   Benchmark runs are scheduled for baseline = ac2222a021206ec7278597a90e7547b7739d3da3 and contender = afb73bead31b9b14a387560d23b7162d64edd7a6. afb73bead31b9b14a387560d23b7162d64edd7a6 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/60793428d7374d4099b72e563f412554...dc8949c8708e49abaa273d83f1d89693/)
   [Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/7a33a3790cd049fb9e88490c1bdcd929...14602a494c0845c5a6fd4c2ed5854b70/)
   [Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/f8e15b98a9fd4ba58b8c8a827aa8eec5...5626649ba64d4616bf6cfaecbd8d82d8/)
   [Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/8aacf9c9a83e4050bade6529d813b939...a06f913550af40eab6283f559494baed/)
   Buildkite builds:
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org