You are viewing a plain text version of this content. The canonical link for it is here.

Posted to oak-issues@jackrabbit.apache.org by "angela (JIRA)" <ji...@apache.org> on 2018/04/05 16:01:00 UTC

[jira] [Commented] (OAK-7288) Change default JAAS ranking of ExternalLoginModuleFactory

    [ https://issues.apache.org/jira/browse/OAK-7288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16427159#comment-16427159 ] 

angela commented on OAK-7288:
-----------------------------

[~chaotic], thanks for the patch. however it doesn't come with any test coverage nor documentation update explaining the change. Also you stated this would be a performance improvement: why? and if it is, you should also provide some benchmarks illustrating the improvement.

> Change default JAAS ranking of ExternalLoginModuleFactory
> ---------------------------------------------------------
>
>                 Key: OAK-7288
>                 URL: https://issues.apache.org/jira/browse/OAK-7288
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: auth-external
>            Reporter: Lars Krapf
>            Priority: Minor
>         Attachments: oak-external-auth.patch
>
>
> In order to improve performance for the (most common?) use case of mostly external users, and to allow potential SSO modules to work with internal and external users OOTB I propose to change the default JAAS ranking of the ExternalLoginModuleFactory to be higher than the one of the default module (e.g 150). 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)